Solved [TFS 1.2], [TFS 0.4], [OTHire] Monster cast beam and wave through wall (Critical bug)

[LuisPro]

Screens from OTHire:

If monster stay 1 sqm from wall and monster cast beam or wave, everything is right, here screen:

But when monster is in front to wall (anything, any wall, magic wall, or closed doors) and he is blocked by player, monster cast beam and wave through wall!

Screens from TFS 1.2:

Screens from TFS 0.4:

If monster is full traped for example by walls or magic walls (also in front to any wall) and have no blocker, monster are not cast spells through wall.

Issue exist in every distro! included:
TFS 1.2
https://github.com/otland/forgottenserver/issues/1690
OTHire
https://github.com/TwistedScorpio/OTHire/issues/53
TFS 0.4
etc...

Any help are welcome.
Greetings.

 

[darkshin]

Probably a good look through the sources could fix it. Doesn't seems hard.

 

[LuisPro]

Probably a good look through the sources could fix it. Doesn't seems hard.

Probably you right.

 

[LuisPro]

↑

 

[LuisPro]

↑

 

[LuisPro]

↑

 

[averatec]

https://github.com/kamil-karkus/forgottenserver/commit/a9657bd208dbbb224e8fcb9bf5a4359de3f9ed3d
It works on 0.4 and my distro so I think it'll work on 1.2

 

[StreamSide]

https://github.com/kamil-karkus/forgottenserver/commit/a9657bd208dbbb224e8fcb9bf5a4359de3f9ed3d
It works on 0.4 and my distro so I think it'll work on 1.2

great work bro

 

[LuisPro]

https://github.com/kamil-karkus/forgottenserver/commit/a9657bd208dbbb224e8fcb9bf5a4359de3f9ed3d
It works on 0.4 and my distro so I think it'll work on 1.2

OMG GIVE THIS GUY A FUCKING MEDAL!!!!!!!
thanks bro, i love you!!!

im using OTHire so here is fix for this distro:

in combat.cpp under:

bool AreaCombat::getList(const Position& centerPos, const Position& targetPos, std::list<Tile*>& list) const
{
    Tile* tile = g_game.getTile(targetPos.x, targetPos.y, targetPos.z);

add this:

    if (tile->hasProperty(BLOCKSOLID)) {
        return false;
    }

SOLVED BITCHES!!!

 

[Xapafe]

I tested my stock OTHire 0.0.2 and it doesn't have this bug.. weird!

I complied a new version anyways just in case I notice it later though.