TFS 1.3 abilities

[Ovnyx]

hi i was using a compiled of this repo: Vulcanx/forgottenserver (https://github.com/Vulcanx/forgottenserver/tree/abilities-remove)
and i was trying to add new abilities that are here: extra item abilities, core itemabilities fixes · stigmatic/engine@14aaddb (https://github.com/stigmatic/engine/commit/14aaddb810c960da26bb672422c0bfd0cfe4f40c)

but when i was to edit items.cpp to add the new abilities i notice that i dont have even the ones that should be there like speed or health gain, same for the cases arent present in my code, is something i forget to do? because i test it with health regeneration and speed ability and it works perfect

thanks in advice!

 

[Infernum]

Are you saying that ITEM_PARSE_SPEED/HEALTHGAIN doesn't exist in your sources? If not, just add them. They obviously exist in my sources so just copy what's in there to your engine.

 

[Ovnyx]

i mean, here for example:

they are not present because even that const std::unordered_map<std::string, ItemParseAttributes_t> ItemParseAttributes doesnt exist, so should i replace the items.cpp whole file in stigmatic repo and use it in my sources?

 

[Infernum]

i mean, here for example:
View attachment 38655
they are not present because even that const std::unordered_map<std::string, ItemParseAttributes_t> ItemParseAttributes doesnt exist, so should i replace the items.cpp whole file in stigmatic repo and use it in my sources?

You're pretty out of date: Use switch to load items.xml (#2481) · otland/forgottenserver@709fb34 (https://github.com/otland/forgottenserver/commit/709fb3464a43865d6fc0d90206a6c2d4714fea09#diff-cdbcf3a5db86a021022fed1a9f317741)
If you don't have any major changes in your current sources you should just compile master branch and use that instead of what you're currently using.

 

[Ovnyx]

ah ok i will see i was using the vulcanx repom compiled i guess is out of date over there too, thank you very much i will update that !!

 

[Infernum]

My source back then wasn't outdated, the items.xml was changed in July, I made the code in August.

 

[Ovnyx]

My source back then wasn't outdated, the items.xml was changed in July, I made the code in August.

hmm i tried to compile stigmatic repo but when i start the server have a error in login.lua with isPremium() function and cant login, maybe u know why is caused this?

 

[Infernum]

hmm i tried to compile stigmatic repo but when i start the server have a error in login.lua with isPremium() function and cant login, maybe u know why is caused this?

You might've accidentally removed it from luascript.cpp in the process of adding my new functions.

 

[Ovnyx]

You might've accidentally removed it from luascript.cpp in the process of adding my new functions.

no, i compile stigmatic/engine (https://github.com/stigmatic/engine)this one, and the server is called, azeria engine, and isPremium is present, maybe i did something wrong, gonna keep trying,
maybe this is realted with that error?

 

[Infernum]

no, i compile stigmatic/engine (https://github.com/stigmatic/engine)this one, and the server is called, azeria engine, and isPremium is present, maybe i did something wrong, gonna keep trying,
maybe this is realted with that error?
View attachment 38656

That's the repo for my old server, there's a reason I told you to add code to your existing repo, not compile year-old sources. You also didn't follow the instructions at the very top of my thread: Lua Function - [TFS 1.3] Item abilities via Lua (https://otland.net/threads/tfs-1-3-item-abilities-via-lua.260156/).

 

[Ovnyx]

That's the repo for my old server, there's a reason I told you to add code to your existing repo, not compile year-old sources. You also didn't follow the instructions at the very top of my thread: Lua Function - [TFS 1.3] Item abilities via Lua (https://otland.net/threads/tfs-1-3-item-abilities-via-lua.260156/).

noo i did!, but since it didnt work i tried to compile that one to check if i can do it work by that way, i will compile tfs 1.3 again and i will add everything again, sorry for the inconvenience

 

[Engradiel]

Hi everyone, sorry for back this topic, these skills really are very good.

But the only thing missing was the dodge, can anyone add?

Implement dodge please!