tfs 1.3 compile error

[kimokimo]

I added a small edit to function combatHealth in game.cpp

        if (targetPlayer = dynamic_cast<Player*> (target)) {
            std::string value;
            double damageReduction = 0;
            uint32_t storage[33];
            sprintf(storage, "%d", g_config.getNumber(ConfigManager::DAMAGE_REDUCTION_STORAGE));
            targetPlayer->getStorage(storage, value);
            if (atoi(value.c_str()) < 0) {
                actualDamage = initialDamage;
            } else {
                damageReduction = atof(value.c_str());
                actualDamage = initialDamage * (1 - (damageReduction / 100));
            }

#ifdef __CUSTOM_DEBUG__
            std::cout << "Player named " << targetPlayer->getName() << " has a damage reductin of " << damageReduction << "%.\n";
            std::cout << "Incoming damage: " << initialDamage << ", actual damage dealt: " << actualDamage << "\n";
#endif
        }

here's what happened

Gyazo

gyazo.com

 

[Infernum]

It's getStorageValue, not getStorage. You're using so much weird shit that you don't need to be doing, like using dynamic_cast and a raw int array for storage key, just use this:

        if (Player* targetPlayer = target->getPlayer()) {
            int32_t value;
            double damageReduction = 0;
            uint32_t storage = g_config.getNumber(ConfigManager::DAMAGE_REDUCTION_STORAGE);
            targetPlayer->getStorage(storage, value);
            if (value < 0) {
                actualDamage = initialDamage;
            } else {
                damageReduction = value;
                actualDamage = initialDamage * (1 - (damageReduction / 100));
            }

#ifdef __CUSTOM_DEBUG__
            std::cout << "Player named " << targetPlayer->getName() << " has a damage reduction of " << damageReduction << "%.\n";
            std::cout << "Incoming damage: " << initialDamage << ", actual damage dealt: " << actualDamage << "\n";
#endif
        }

Storage values are no longer strings as well for future reference.