TFS 1.X+ TFS 1.3 CTRL + ARROW for staff members ( NOT seeking onTurn event solutions! )

[Snavy]

I am trying to allow GM+ groups to be able to walk through solid objects as it has already been done in TFS 0.4.

I have found the following method in Game.cpp but I'm not sure how to modify it.

forgottenserver/game.cpp at master · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - forgottenserver/game.cpp at master · otland/forgottenserver

github.com

void Game::playerTurn(uint32_t playerId, Direction dir)
{
    Player* player = getPlayerByID(playerId);
    if (!player) {
        return;
    }

    if (!g_events->eventPlayerOnTurn(player, dir)) {
        return;
    }

    player->resetIdleTime();
    internalCreatureTurn(player, dir);
}

How can I allow GMs or higher groups to walk trough solid objects using CTRL + ARROW keys ?

 

[celohere]

[Event] Walkthrough everything Ctrl + Arrow keys [TFS 1.X] (https://otland.net/threads/event-walkthrough-everything-ctrl-arrow-keys-tfs-1-x.226973/)

 

[Snavy]

[Event] Walkthrough everything Ctrl + Arrow keys [TFS 1.X] (https://otland.net/threads/event-walkthrough-everything-ctrl-arrow-keys-tfs-1-x.226973/)

please, read the title.

NOT seeking onTurn event solutions!

 

[Evil Hero]

Well I don't understand why you do not want to have it in lua.
However here's what you asked for.

void Game::playerTurn(uint32_t playerId, Direction dir)
{
    Player* player = getPlayerByID(playerId);
    if (!player) {
        return;
    }

    if (player->getGroup()->access) {
        if (player->getDirection() == dir) {
            auto pos = player->getPosition();
            auto nextPos = getNextPosition(dir, pos);
            internalTeleport(player, nextPos, true);
        }
    }

    if (!g_events->eventPlayerOnTurn(player, dir)) {
        return;
    }

    player->resetIdleTime();
    internalCreatureTurn(player, dir);
}

 

[Snavy]

Well I don't understand why you do not want to have it in lua.
However here's what you asked for.

void Game::playerTurn(uint32_t playerId, Direction dir)
{
    Player* player = getPlayerByID(playerId);
    if (!player) {
        return;
    }

    if (player->getGroup()->access) {
        if (player->getDirection() == dir) {
            auto pos = player->getPosition();
            auto nextPos = getNextPosition(dir, pos);
            internalTeleport(player, nextPos, true);
        }
    }

    if (!g_events->eventPlayerOnTurn(player, dir)) {
        return;
    }

    player->resetIdleTime();
    internalCreatureTurn(player, dir);
}

Lord pepe is very thankful to you, Master Evil hero

 

[Snavy]

Well I don't understand why you do not want to have it in lua.
However here's what you asked for.

void Game::playerTurn(uint32_t playerId, Direction dir)
{
    Player* player = getPlayerByID(playerId);
    if (!player) {
        return;
    }

    if (player->getGroup()->access) {
        if (player->getDirection() == dir) {
            auto pos = player->getPosition();
            auto nextPos = getNextPosition(dir, pos);
            internalTeleport(player, nextPos, true);
        }
    }

    if (!g_events->eventPlayerOnTurn(player, dir)) {
        return;
    }

    player->resetIdleTime();
    internalCreatureTurn(player, dir);
}

I am not sure why, but at some places e.g mountain edges there are no tiles and yet I am able to walk a few more sqm's with CTRL+WALK.
Also I am suspecting that this might have been the cause of a few crashes where I could reproduce it atleast twice doing the same process.
( doesn't happen atm will keep lookin ).

Would It maybe be possible to not let the admin/gm walk onto places without any tiles?

 

[Sarah Wesker]

You can check like this:

Tile* tile = map.getTile(pos);
if (tile) {
    // things
}

 

[Evil Hero]

that's already handled in internalTeleport function

Tile* toTile = map.getTile(newPos);
if (!toTile) {
    return RETURNVALUE_NOTPOSSIBLE;
}

Hit me up on Discord and show me how to reproduce it, might be able to find it out then
Evil Hero#8530