TFS 1.X+ TFS 1.3 - Emote spells

[Ovnyx]

Hi, i was trying to change how the cast spell works, i enabled in config lua the emote flag, and what i am looking for is that when a player cast a spell the words show are not the "Words" , instead i want to show the "Name" so if i cast exura it will say "Light healing".

i was looking into this function in game.cpp:

bool Game::playerSaySpell(Player* player, SpeakClasses type, const std::string& text)
{
    std::string words = text;

    TalkActionResult_t result = g_talkActions->playerSaySpell(player, type, words);
    if (result == TALKACTION_BREAK) {
        return true;
    }

    result = g_spells->playerSaySpell(player, words);
    if (result == TALKACTION_BREAK) {
        if (!g_config.getBoolean(ConfigManager::EMOTE_SPELLS)) {
            return internalCreatureSay(player, TALKTYPE_SAY, words, false);
        } else {
            //LOOKING HERE TO CHANGE
            return internalCreatureSay(player, TALKTYPE_MONSTER_SAY, words, false);
        }

    } else if (result == TALKACTION_FAILED) {
        return true;
    }

    return false;
}

is there a way to create a Spell or Spells instance with the "words", in order to use something like getName() and i wan use that string instead of the words?
i tryied this:

 Spells spell = Spells();
 spell.getInstantSpell(words);

but im getting this erro while compiling:

i looked for the functions and getInstantSpell actually exist.

Thanks in advice!

 

[Adorius Black]

BUHP.

 

[zbizu]

line where output words are created: forgottenserver/spells.cpp at 67353332b03b8c1648192c90f48a8e018adcda94 · otland/forgottenserver (https://github.com/otland/forgottenserver/blob/67353332b03b8c1648192c90f48a8e018adcda94/src/spells.cpp#L88)

you will need to add getSpellNameByWords method in spells.cpp which is basically this function: forgottenserver/spells.cpp at 67353332b03b8c1648192c90f48a8e018adcda94 · otland/forgottenserver (https://github.com/otland/forgottenserver/blob/67353332b03b8c1648192c90f48a8e018adcda94/src/spells.cpp#L232)

but your new function should return const std::string& type so you should return result->getName() instead of just result
the line I'm speaking of: forgottenserver/spells.cpp at 67353332b03b8c1648192c90f48a8e018adcda94 · otland/forgottenserver (https://github.com/otland/forgottenserver/blob/67353332b03b8c1648192c90f48a8e018adcda94/src/spells.cpp#L262)

if you want it in config.lua, you may use this commit as an example of adding new config value:
Add monsters walking back to spawn (#3604) · otland/forgottenserver@5a4558d (https://github.com/otland/forgottenserver/commit/5a4558db00f56c88ef1f9d98e2c762fef6ea3a0d#diff-41ebed0867fb6bc8676568dd635813d639f92062d0101ccd9cc64658d35bb594)

 

[Adorius Black]

line where output words are created: forgottenserver/spells.cpp at 67353332b03b8c1648192c90f48a8e018adcda94 · otland/forgottenserver (https://github.com/otland/forgottenserver/blob/67353332b03b8c1648192c90f48a8e018adcda94/src/spells.cpp#L88)

you will need to add getSpellNameByWords method in spells.cpp which is basically this function: forgottenserver/spells.cpp at 67353332b03b8c1648192c90f48a8e018adcda94 · otland/forgottenserver (https://github.com/otland/forgottenserver/blob/67353332b03b8c1648192c90f48a8e018adcda94/src/spells.cpp#L232)

but your new function should return const std::string& type so you should return result->getName() instead of just result
the line I'm speaking of: forgottenserver/spells.cpp at 67353332b03b8c1648192c90f48a8e018adcda94 · otland/forgottenserver (https://github.com/otland/forgottenserver/blob/67353332b03b8c1648192c90f48a8e018adcda94/src/spells.cpp#L262)

if you want it in config.lua, you may use this commit as an example of adding new config value:
Add monsters walking back to spawn (#3604) · otland/forgottenserver@5a4558d (https://github.com/otland/forgottenserver/commit/5a4558db00f56c88ef1f9d98e2c762fef6ea3a0d#diff-41ebed0867fb6bc8676568dd635813d639f92062d0101ccd9cc64658d35bb594)

I am trying to understand what are you writing but it seems that I am missing something :/

 

[zbizu]

C++ methods:

type Class::methodName(params){
type variable;
//code
return variable;
}

You declared a different type than you returned

Besides that, I told you to make a new function using that one as an example. The function you're editing is still in use.