TFS 1.X+ TFS 1.3 Healing causes critical

[Crobattis]

Hey guys, I am pretty new to making an Open Tibia server.
I have tried to find an answer to this, but couldn't find any.

I have compiled my server to TFS 1.3 and am using the attribute criticalhitchange in items.xml, which works perfectly.
However, when I use healing spells, they also crit. Is there any way to remove that?

Thanks in advance!

 

[Nekiro]

Is this default tfs 1.3 from otland repository? If so, you should create issue there, as it is a bug. I reworked criticals and stuff some time ago and I might have missed the check for healing spells.

Changes to fix this: Fix combat leech/criticals issue by nekiro · Pull Request #3368 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/3368)
(NOT TESTED)

 

[Crobattis]

I got everything from otland/forgottenserver (https://github.com/otland/forgottenserver) and chose master.
I tried the fix you suggested, however now the critical chance completely dissapeard.
Anything else I could try?

 

[Evil Puncker]

I got everything from otland/forgottenserver (https://github.com/otland/forgottenserver) and chose master.
I tried the fix you suggested, however now the critical chance completely dissapeard.
Anything else I could try?

he added new changes, please test it again:

Fix combat leech/criticals issue by nekiro · Pull Request #3368 · otland/forgottenserver

Fixes some issues with leeching positive damage and calculating criticals for healing also small code cleanup

github.com

 

[Crobattis]

You're a hero!
The new changes fixed it.
I really appreciate it.