TFS 1.X+ [tfs 1.3] How can i make player dont lose skill Fishing dying

[roriscrave]

How can I make the player not lose skill fishing dying?
just skill fishing

 

[Yalasari]

In file player.cpp You have structure like this

//Skill loss
        for (uint8_t i = SKILL_FIRST; i <= SKILL_LAST; ++i) { //for each skill
            uint64_t sumSkillTries = 0;
            for (uint16_t c = 11; c <= skills[i].level; ++c) { //sum up all required tries for all skill levels
                sumSkillTries += vocation->getReqSkillTries(i, c);
            }

            sumSkillTries += skills[i].tries;

            uint32_t lostSkillTries = static_cast<uint32_t>(sumSkillTries * deathLossPercent);
            while (lostSkillTries > skills[i].tries) {
                lostSkillTries -= skills[i].tries;

                if (skills[i].level <= 10) {
                    skills[i].level = 10;
                    skills[i].tries = 0;
                    lostSkillTries = 0;
                    break;
                }

                skills[i].tries = vocation->getReqSkillTries(i, skills[i].level);
                skills[i].level--;
            }

            skills[i].tries = std::max<int32_t>(0, skills[i].tries - lostSkillTries);
            skills[i].percent = Player::getPercentLevel(skills[i].tries, vocation->getReqSkillTries(i, skills[i].level));
        }

Replace this fragment of code

uint32_t lostSkillTries = static_cast<uint32_t>(sumSkillTries * deathLossPercent);

with

if (i == SKILL_FISHING) {
    uint32_t lostSkillTries = 0;
} else {
    uint32_t lostSkillTries = static_cast<uint32_t>(sumSkillTries * deathLossPercent);
}

When skill loss counting loop "targets" fishing skill, instead of calculating lost tries, it will set it to 0, what means that no skill tries will be lost,
No skill tries loss equals no skill loss.

 

[Infernum]

In file player.cpp You have structure like this

//Skill loss
        for (uint8_t i = SKILL_FIRST; i <= SKILL_LAST; ++i) { //for each skill
            uint64_t sumSkillTries = 0;
            for (uint16_t c = 11; c <= skills[i].level; ++c) { //sum up all required tries for all skill levels
                sumSkillTries += vocation->getReqSkillTries(i, c);
            }

            sumSkillTries += skills[i].tries;

            uint32_t lostSkillTries = static_cast<uint32_t>(sumSkillTries * deathLossPercent);
            while (lostSkillTries > skills[i].tries) {
                lostSkillTries -= skills[i].tries;

                if (skills[i].level <= 10) {
                    skills[i].level = 10;
                    skills[i].tries = 0;
                    lostSkillTries = 0;
                    break;
                }

                skills[i].tries = vocation->getReqSkillTries(i, skills[i].level);
                skills[i].level--;
            }

            skills[i].tries = std::max<int32_t>(0, skills[i].tries - lostSkillTries);
            skills[i].percent = Player::getPercentLevel(skills[i].tries, vocation->getReqSkillTries(i, skills[i].level));
        }

Replace this fragment of code

uint32_t lostSkillTries = static_cast<uint32_t>(sumSkillTries * deathLossPercent);

with

if (i == SKILL_FISHING) {
    uint32_t lostSkillTries = 0;
} else {
    uint32_t lostSkillTries = static_cast<uint32_t>(sumSkillTries * deathLossPercent);
}

When skill loss counting loop "targets" fishing skill, instead of calculating lost tries, it will set it to 0, what means that no skill tries will be lost,
No skill tries loss equals no skill loss.

Those variables are inaccessible because of the scope you're declaring them in, you're not reassigning.
Either way you should just be replacing the loop condition's limit:

for (uint8_t i = SKILL_FIRST; i <= SKILL_LAST - 1; ++i) { //for each skill

OR

for (uint8_t i = SKILL_FIRST; i < SKILL_LAST; ++i) { //for each skill

 

[Yalasari]

@Stigma I see my mistake, and of course answer which You provided is correct.
However my intention in making code such like this was to ensure that no matter which skill is last (SKILL_LAST) code will run correctly,
of course my previous code wasn't working but i just wonder if using something like this will be safer and non-dependent from number of skills and their index

Inside for loop at beginning

if (i == SKILL_FISHING)
    continue;

 

[Infernum]

@Stigma I see my mistake, and of course answer which You provided is correct.
However my intention in making code such like this was to ensure that no matter which skill is last (SKILL_LAST) code will run correctly,
of course my previous code wasn't working but i just wonder if using something like this will be safer and non-dependent from number of skills and their index

Inside for loop at beginning

if (i == SKILL_FISHING)
    continue;

Originally I was going to go with a continue statement like that, but then I realized fishing was SKILL_LAST, so the better solution is removing that iteration completely rather than just skipping it 100% of the time.