TFS 1.X+ tfs 1.3 not support dotted exp stages.

[roriscrave]

Hi, I noticed that in tfs 1.3 there is a bug, stages.xml does not support dotted exp stages.

<?xml version="1.0" encoding="UTF-8"?>
<stages>
    <config enabled="1" />
        <stage minlevel="1" maxlevel="10" multiplier="10"/>
        <stage minlevel="101" maxlevel="200" multiplier="5"/>
        <stage minlevel="201" maxlevel="300" multiplier="2.5"/>
        <stage minlevel="301" maxlevel="400" multiplier="1.5"/>
        <stage minlevel="401" maxlevel="500" multiplier="1"/>
        <stage minlevel="501" multiplier="0.5"/>
</stages>

for exemple, if player is in stage (201 to 300) and i print

Game.getExperienceStage(self:getLevel())

it print 0, because have a dot in multiplier (2.5)
if i put multiplier value 2 or 3 it print correct....

I triedto change
uint32_t to float here:
game.cpp

multiplier = pugi::cast<float>(multiplierAttribute.value());

and

float Game::getExperienceStage(uint32_t level)

game.h

std::map<uint32_t, float> stages;

and

float getExperienceStage(uint32_t level);

but with this new configurations (float) it print.
if stage is 3.7 -> return 3
if stage is 1.5 -> return 1
if stage is 0.8 -> return 0
it seems to round down
what was left to do?

 

[roriscrave]

not possible?

 

[Lvitz]

Already noticed this problem
<stage minlevel="1" maxlevel="10" multiplier="10"/>
Should be maxlevel="100"

multiplier = pugi::cast<float>(multiplierAttribute.value());
float means rounding to lower

No idea, how looks correct solution, but it could help you, logically:
x = (float(exp * multiplier * 10)) / 10
multiply all stages by 10, delete all float, add dividing by 10 to each place where stage is checked.

 

[Evil Puncker]

you noticed it once again?

TFS 1.X+ - [tfs 1.3] stages.xml dont accept (dotted numbers)

Hi, I noticed that in tfs 1.3 there is a bug, stages.xml does not support dotted exp stages. for exemple, if player is in stage (201 to 300) and i print Game.getExperienceStage(self:getLevel()) it print 0, because have a dot in...

otland.net

 

[roriscrave]

you noticed it once again?

TFS 1.X+ - [tfs 1.3] stages.xml dont accept (dotted numbers)

Hi, I noticed that in tfs 1.3 there is a bug, stages.xml does not support dotted exp stages. for exemple, if player is in stage (201 to 300) and i print Game.getExperienceStage(self:getLevel()) it print 0, because have a dot in...

otland.net

because i need another solution

 

[roriscrave]

not possible?

 

[Evil Puncker]

as delusion said in the other thread, there is a lot to change in order to achieve it, and my bet is you have to hire someone to do it for you

 

[Infernum]

It's not a lot to change, it's just more work in comparison to using a perfectly working system that I gave premade code for.

 

[roriscrave]

It's not a lot to change, it's just more work in comparison to using a perfectly working system that I gave premade code for.

because i dont want to use math.max in code

 

[Infernum]

There is no math.max in the commit I sent. And either way, you're looking at a benchmark of 1 million runs of both sets of code, and math.max is ~0.2 sec slower which is approximately 200 nanoseconds per call to math.max, and 100 nanoseconds to the < operator, you're not going to tell the difference when a server is running and executing those at separate times with unpredictable intervals, not 1 million executions at a time.
If you're going to actually believe what that says, then you should just stop using functions altogether since functions add a few nanoseconds of execution time just to lookup the function in the environment and call it.
I'm not saying that the code is wrong, I'm just saying it's dumb to use benchmarks like that to completely avoid using a function in exchange for a few nanoseconds of execution time, especially in code that's lightweight and won't be running that often to make a difference in your server.

 

[StreamSide]

what about lua exp stages like we do

 

[roriscrave]

what about lua exp stages like we do

View attachment 39083

how is your code?

 

[Infernum]

how is your code?

The exact same code I sent you the first time, Move experience stages to Lua by ranisalt · Pull Request #1642 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/1642/files)

 

[goo_pile]

Already noticed this problem
<stage minlevel="1" maxlevel="10" multiplier="10"/>
Should be maxlevel="100"

multiplier = pugi::cast<float>(multiplierAttribute.value());
float means rounding to lower

No idea, how looks correct solution, but it could help you, logically:
x = (float(exp * multiplier * 10)) / 10
multiply all stages by 10, delete all float, add dividing by 10 to each place where stage is checked.

THIS NEED TO BE ON TOP ANSWER!!!!!!!!!!!!!!

i did exactly what you said and it worked perfectly! i've been looking for an answer for at least an hour !


<stage minlevel="1" maxlevel="4" multiplier="10" />
<stage minlevel="5" maxlevel="9" multiplier="12" />
<stage minlevel="10" maxlevel="14" multiplier="14" />
...

instead of


<stage minlevel="1" maxlevel="4" multiplier="1.0" />
<stage minlevel="5" maxlevel="9" multiplier="1.2" />
<stage minlevel="10" maxlevel="14" multiplier="1.4" />
...
then in data/events/scripts/player.lua

look for that function

function Player: onGainExperience(source, exp, rawExp)
...
exp = exp * 0.1 <-- add this line at the end!!!!
return exp
end


easy manipulation that require no time! thanks again!!