TFS 1.X+ TFS 1.3 summons teleport to master

[Mjmackan]

As topic says, I found something in sources of latest tfs 1.3 repo but is it a borked function or what do these lines even do?

        if (!summons.empty()) {
            //check if any of our summons is out of range (+/- 2 floors or 30 tiles away)
            std::forward_list<Creature*> despawnList;
            for (Creature* summon : summons) {
                const Position& pos = summon->getPosition();
                if (Position::getDistanceZ(newPos, pos) > 2 || (std::max<int32_t>(Position::getDistanceX(newPos, pos), Position::getDistanceY(newPos, pos)) > 30)) {
                    despawnList.push_front(summon);
                }
            }

            for (Creature* despawnCreature : despawnList) {
                g_game.removeCreature(despawnCreature, true);
            }
        }

I tried to change to internal teleport instead but without any success: (credits to: otservbr)

        if (!summons.empty()) {
            //check if any of our summons is out of range (+/- 2 floors or 30 tiles away)
            std::forward_list<Creature*> despawnList;
            for (Creature* summon : summons) {
                const Position& pos = summon->getPosition();
                if (Position::getDistanceZ(newPos, pos) > 1 || (std::max<int32_t>(Position::getDistanceX(newPos, pos), Position::getDistanceY(newPos, pos)) > 5)) {
                    g_game.internalTeleport(summon, summon->getMaster()->getPosition(), true);
                }
            }

            for (Creature* despawnCreature : despawnList) {
                g_game.removeCreature(despawnCreature, true);
            }
        }

On a sidenote, Is it possible to let summons walk in/out of PZ without an entire change of sources?

 

[Kotetso]

if (oldPos.z != newPos.z) {
            if (!summons.empty()) {

                for (Creature* summon : summons) {
                    g_game.addMagicEffect(this->getPosition(), 1);
                    g_game.internalTeleport(summon, summon->getMaster()->getPosition(), true);
                }
            }
        }

 

[zbizu]

As topic says, I found something in sources of latest tfs 1.3 repo but is it a borked function or what do these lines even do?

remove your summon when you walk away

 

[lexus21]

TFS 1.4
creature.cpp

        if (oldPos.z != newPos.z) {
            if (!summons.empty()) {
                std::forward_list<Creature*> despawnList;
                for (Creature* summon : summons) {
                    g_game.addMagicEffect(this->getPosition(), 1);
                    g_game.internalTeleport(summon, summon->getMaster()->getPosition(), true);
                }
                for (Creature* despawnCreature : despawnList) {
                    g_game.removeCreature(despawnCreature, true);
                }
            }
        }
        }