TFS 1.X+ TFS 1.5 Downgrade Nekiro 772 - Dont Work showTextDialog

[Forkz]

Hi otlanders,

After I added the system below, my "player:showTextDialog" stopped working, I did the tests and that is really the reason, but I didn't find out why.

https://github.com/OTAcademy/otclientv8/pull/29

https://github.com/Oen44/tfs-new-decay/commit/f72bde7c08a580c93336d33cbf857b1a008a2764

The problem is in this code below, if anyone can help me, I would be very grateful.

void NetworkMessage::addItem(const Item* item)
{
    const ItemType& it = Item::items[item->getID()];

    add<uint16_t>(it.clientId);
    //addByte(0xFF); // MARK_UNMARKED

    /*if (it.stackable) {
        addByte(std::min<uint16_t>(0xFF, item->getItemCount()));
    } else if (it.isSplash() || it.isFluidContainer()) {
        addByte(fluidMap[item->getFluidType() & 7]);
    }

    if (it.isAnimation) {
        addByte(0xFE); // random phase (0xFF for async)
    }*/

    if (it.stackable) {
        addByte(std::min<uint16_t>(0xFF, item->getItemCount()));
    }
    else if (it.isSplash() || it.isFluidContainer()) {
        addByte(item->getSubType());
    }
    
    // duration
    if (item->hasAttribute(ITEM_ATTRIBUTE_DURATION) && item->getDuration() > 0) {
        if (item->isPickupable() && !item->getContainer()) {
            addByte(0x01);
            add<uint32_t>(item->getDuration());
            addByte(it.stopTime ? 1 : 0);
        }
        else {
            addByte(0x00);
        }
    }
    else {
        addByte(0x00);
    }
}

If I remove the //duration part, the player:showTextDialog works normally, but if this part of the script is activated, it does not work.


OTClient Error

ERROR: ProtocolGame parse message exception (121 bytes, 106 unread, last opcode is 0x96 (150), prev opcode is 0xffffffff (-1)): InputMessage eof reached
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 772)

packet

ProtocolGame parse message exception (121 bytes, 106 unread, last opcode is 0x96 (150), prev opcode is 0xffffffff (-1), proto: 772): InputMessage eof reached
78 00 75 00
96 01 00 00 00 fe 0a 00 00 02 67 00 21 61 75 74 6f 6c 6f 6f 74 0a 21 62 6c 65 73 73 0a 21 62 75 79 0a 21 63 68 61 6e 67 65 73 65 78 0a 21 63 6f 6d 6d 61 6e 64 73 0a 21 66 72 61 67 73 0a 21 6f 6e 6c 69 6e 65 0a 21 70 72 6f 6d 6f 74 69 6f 6e 0a 21 73 61 76 65 6d 65 0a 21 73 65 72 76 65 72 69 6e 66 6f 0a 21 73 70 65 6c 6c 73 0a 21 74 72 61 69 6e 00 00

 

[Error 502]

problem is in

void ProtocolGame::sendTextWindow(uint32_t windowTextId, uint16_t itemId,

or

void ProtocolGame::sendTextWindow(uint32_t windowTextId, Item* item
   ....
   msg.addItem(item);

try change to
addItemId
-----------------------------------------------------------------------------------------------------------------

I don't know why it sends so many bytes, if the cipsoft system only requires u32 and u8.

 

[Forkz]

my code is like this

void ProtocolGame::sendTextWindow(uint32_t windowTextId, Item* item, uint16_t maxlen, bool canWrite)
{
    NetworkMessage msg;
    msg.addByte(0x96);
    msg.add<uint32_t>(windowTextId);
    msg.addItem(item);

    if (canWrite) {
        msg.add<uint16_t>(maxlen);
        msg.addString(item->getText());
    } else {
        const std::string& text = item->getText();
        msg.add<uint16_t>(text.size());
        msg.addString(text);
    }

    msg.addString(item->getWriter());
    /*if (!writer.empty()) {
        msg.addString(writer);
    } else {
        msg.add<uint16_t>(0x00);
    }*/

    /*time_t writtenDate = item->getDate();
    if (writtenDate != 0) {
        msg.addString(formatDateShort(writtenDate));
    } else {
        msg.add<uint16_t>(0x00);
    }*/

    writeToOutputBuffer(msg);
}

void ProtocolGame::sendTextWindow(uint32_t windowTextId, uint32_t itemId, const std::string& text)
{
    NetworkMessage msg;
    msg.addByte(0x96);
    msg.add<uint32_t>(windowTextId);
    msg.addItem(itemId, 1);
    msg.add<uint16_t>(text.size());
    msg.addString(text);
    //msg.add<uint16_t>(0x00);
    //msg.add<uint16_t>(0x00);
    msg.addString("");
    writeToOutputBuffer(msg);
}

 

[ond]

From Google:

C++ String empty() function The empty() function checks wheter a string is empty or not. It returns 1 if the string is empty, otherwise 0.

Edit: Nevermind the google result, didn't notice the answer regarded the empty() function

So try this:

void ProtocolGame::sendTextWindow(uint32_t windowTextId, Item* item, uint16_t maxlen, bool canWrite)
{
    NetworkMessage msg;
    msg.addByte(0x96);
    msg.add<uint32_t>(windowTextId);
    msg.addItem(item);

    if (canWrite) {
        msg.add<uint16_t>(maxlen);
        msg.addString(item->getText());
    } else {
        const std::string& text = item->getText();
        msg.add<uint16_t>(text.size());
        msg.addString(text);
    }

    const std::string& writer = item->getWriter();
    if (!writer.empty()) {
        msg.addString(writer);
    }
    else {
        msg.addString("");
    }

    writeToOutputBuffer(msg);
}