TFS 1.5 Global Bank request

[pichetas]

I'm using the latest TFS 1.5 downgraded to 8.6 by Nekiro, and i'm having problems to add the option that you can but items from npcs without having the money in your backpack and instead taking the cash from bp and also the rest from the bank.

Can anyone help me? I already search the whole forum and didnt find a solved for this version.

Thanks

 

[Nottinghster]

That function

TFS-1.5-Downgrades/data/lib/core/player.lua at 8.60 · nekiro/TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - nekiro/TFS-1.5-Downgrades

github.com

 

[pichetas]

That function

TFS-1.5-Downgrades/data/lib/core/player.lua at 8.60 · nekiro/TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - nekiro/TFS-1.5-Downgrades

github.com

I already have that function.
The only times I see it works is when buying houses, it seems like npcs doesnt consider the players bank balance.

Does anybody know where I can check that? I'm thinking the error is there

Edit: I think it may be in this part of the 050-function.lua, I thinks there's a function missing like doPlayerRemoveTotalMoney

function doPlayerWithdrawMoney(cid, amount)
    if(not getBooleanFromString(getConfigInfo('bankSystem'))) then
        return false
    end

    local balance = getPlayerBalance(cid)
    if(amount > balance or not doPlayerAddMoney(cid, amount)) then
        return false
    end

    doPlayerSetBalance(cid, balance - amount)
    return true
end

function doPlayerDepositMoney(cid, amount)
    if(not getBooleanFromString(getConfigInfo('bankSystem'))) then
        return false
    end

    if(not doPlayerRemoveMoney(cid, amount)) then
        return false
    end

    doPlayerSetBalance(cid, getPlayerBalance(cid) + amount)
    return true
end

 

[Evil Puncker]

tfs 1.5 doesn't have 050-function.lua, your problem is that you replaced original data/npc/lib files with files that doesn't support the data/lib/player.lua functions...

take a look at these changes and see what you need to change:

Added Bank support to trading NPCs (#2712) · otland/forgottenserver@8628da5

As of 10.94 update, Premium players no longer need to bring any money to pay for services or wares, as the concerned NPCs now deducts any money missing from their inventory from their Bank Account....

github.com

 

[pichetas]

tfs 1.5 doesn't have 050-function.lua, your problem is that you replaced original data/npc/lib files with files that doesn't support the data/lib/player.lua functions...

take a look at these changes and see what you need to change:

Added Bank support to trading NPCs (#2712) · otland/forgottenserver@8628da5

As of 10.94 update, Premium players no longer need to bring any money to pay for services or wares, as the concerned NPCs now deducts any money missing from their inventory from their Bank Account....

github.com

I tried it but didnt work, still the npcs doesnt see the money on my bank balance, just the one in my backpack.

I saw that the protocolgame.cpp in that tutorial shows this change:

    msg.add<uint64_t>(player->getMoney());
    msg.add<uint64_t>(player->getMoney() + player->getBankBalance());

mine was like this:

    msg.add<uint32_t>(player->getMoney());

I've tried with the change adding getbankbalance for 64 and 32, didnt work either way, but I dont know if that number has something to do

 

[Evil Puncker]

I tried it but didnt work, still the npcs doesnt see the money on my bank balance, just the one in my backpack.

have you checked the change made on protocolgame.cpp file?

 

[pichetas]

have you checked the change made on protocolgame.cpp file?

I've just eddited that answer, yeah I've tried

 

[Evil Puncker]

so you changed:

msg.add<uint32_t>(player->getMoney());

to:
msg.add<uint32_t>(player->getMoney() + player->getBankBalance());

and recompiled your server and it didn't work still?

 

[pichetas]

so you changed:

msg.add<uint32_t>(player->getMoney());

to:
msg.add<uint32_t>(player->getMoney() + player->getBankBalance());

and recompiled your server and it didn't work still?

I didnt know I had to recompile, thank you!! it works now perfectly

 

[johnsamir]

for which function should be doPlayerWithdrawMoney replaced?
i was having that error so then i added the function in global.lua
everything is updated, i compare with changes that evil punker linked

function doPlayerWithdrawMoney(cid, amount)
    if(not getBooleanFromString(getConfigInfo('bankSystem'))) then
        return false
    end

    local balance = getPlayerBalance(cid)
    if(amount > balance or not doPlayerAddMoney(cid, amount)) then
        return false
    end

    doPlayerSetBalance(cid, balance - amount)
    return true
end

and there are no error in console now but nothing happen either

can deposit money, ask for balance but when try withdraw nothing happen

 

[Evil Puncker]

for which function should be doPlayerWithdrawMoney replaced?

forgottenserver/player.lua at master · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - forgottenserver/player.lua at master · otland/forgottenserver

github.com