C++ Trade with NPC, nekiro downgrade 1.5 8.0

[Bee King]

Here’s the translation:

---

I am using TFS 1.5 downgrade 8.0 from nekiro, and I want to add the NPC trade option, where the modal window opens and makes buying/selling with them easier...


I found something related here, but it’s a bit vague. If someone has already implemented this and knows the path I should follow, please help me! I've been trying for some time now.


I’m using only OTC, so I won’t have issues with debugging on the client side.

 

[L0FIC]

Here’s the translation:

---

I am using TFS 1.5 downgrade 8.0 from nekiro, and I want to add the NPC trade option, where the modal window opens and makes buying/selling with them easier...


I found something related here, but it’s a bit vague. If someone has already implemented this and knows the path I should follow, please help me! I've been trying for some time now.


I’m using only OTC, so I won’t have issues with debugging on the client side.

@Bee King hey man, did you manage to do it? A little help would be very much appreciated, and im sure i have some solutions i can share with you as well.

 

[Sorky]

i dont feel like it's c++ code, it seems more like lua/otc code

@Bee King hey man, did you manage to do it? A little help would be very much appreciated, and im sure i have some solutions i can share with you as well.

 

[L0FIC]

i dont feel like it's c++ code, it seems more like lua/otc code

Yeah it all seems to be in the TFS 1.5 source code to be honest. Feels like npc lib files that needs to be edited, but i tried nekiro 8.6 lib files and also tfs 1.4 but no success. I can get the npc to say "Of course, browse through my wares" when I say Trade, but no modal window popping up with the items..

 

[Sorky]

Yeah it all seems to be in the TFS 1.5 source code to be honest. Feels like npc lib files that needs to be edited, but i tried nekiro 8.6 lib files and also tfs 1.4 but no success. I can get the npc to say "Of course, browse through my wares" when I say Trade, but no modal window popping up with the items..

do your npc have those attribute?
<parameter key="module_shop" value="1" />
<parameter key="shop_buyable" value="parcel,2595,15;letter,2597,10" />


I tried it with npc Deruno (default one from tfs by nekiro, 8.6)

Im using ot client by menah tho

 

[Tenzhiro]

data/npc/lib/npcsystem/modules.lua

Line 28/29

Change whatever you have to TRADE

    -- Used shop mode
    SHOPMODULE_MODE = SHOPMODULE_MODE_TRADE

TFS-1.5-Downgrades/data/npc/lib/npcsystem/modules.lua at 8.0 · nekiro/TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - nekiro/TFS-1.5-Downgrades

github.com

 

[L0FIC]

data/npc/lib/npcsystem/modules.lua

Line 28/29

Change whatever you have to TRADE

    -- Used shop mode
    SHOPMODULE_MODE = SHOPMODULE_MODE_TRADE

TFS-1.5-Downgrades/data/npc/lib/npcsystem/modules.lua at 8.0 · nekiro/TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - nekiro/TFS-1.5-Downgrades

github.com

Yeah man thanks, i missed that! Still get nothing when writing trade though.

Any pointers towards the source code edit too? Thanks a lot man appreciate it.
And was this the only npc libs edit needed?

@Sorky yeah tfs 1.5, 8.6 version has the correct commits in source code. I am using tfs1.5, protocol 7.7 mate

 

[Tenzhiro]

Yeah man thanks, i missed that! Still get nothing when writing trade though.

Any pointers towards the source code edit too? Thanks a lot man appreciate it.
And was this the only npc libs edit needed?

@Sorky yeah tfs 1.5, 8.6 version has the correct commits in source code. I am using tfs1.5, protocol 7.7 mate

Perhaps change it to

SHOPMODULE_MODE = SHOPMODULE_MODE_BOTH

 

[L0FIC]

Perhaps change it to

SHOPMODULE_MODE = SHOPMODULE_MODE_BOTH

Tried it, doesnt work mate. But yeah that needs to be config:ed as well for sure.

I need the source edits. I saw @Error 502 posting the solution partly in another thread, i tried my very best to do what he said but I did not get it to work. :/ involves protocolgame.cpp and .h and some other source edits.

 

[Mateus Robeerto]

Many people asked me how to add NPC trade for TFS 1.5 7.72 and 8.0 as well. So, I decided to do it in a simple way. Here's the commit—be happy and enjoy it for the OTland community!

Add working NPC trade for 7.72 and 8.0. Works great! · Mateuzkl/TFS-1.5-772@73081a1

Alternative forgottenserver versions for older protocols support - Add working NPC trade for 7.72 and 8.0. Works great! · Mateuzkl/TFS-1.5-772@73081a1

github.com

Just ignore the NPC XML and Lua part; I was testing and forgot to remove it before committing. So, yes, just follow the NPC modules and the rest of the CPP and H files, and your NPC trade will be working fine!

 

[Forkz]

Many people asked me how to add NPC trade for TFS 1.5 7.72 and 8.0 as well. So, I decided to do it in a simple way. Here's the commit—be happy and enjoy it for the OTland community!

Add working NPC trade for 7.72 and 8.0. Works great! · Mateuzkl/TFS-1.5-772@73081a1

Alternative forgottenserver versions for older protocols support - Add working NPC trade for 7.72 and 8.0. Works great! · Mateuzkl/TFS-1.5-772@73081a1

github.com

Just ignore the NPC XML and Lua part; I was testing and forgot to remove it before committing. So, yes, just follow the NPC modules and the rest of the CPP and H files, and your NPC trade will be working fine!

View attachment 90782View attachment 90784

I have a problem with the cap, otclient is not recognizing the correct capacity. I'm using TFS 1.5 downgrade nekiro 772!


OTClientv8/invetory.lua

function onFreeCapacityChange(player, freeCapacity)
  if not freeCapacity then return end
  if freeCapacity > 99 then
    freeCapacity = math.floor(freeCapacity * 10) / 10
  end
  if freeCapacity > 999 then
    freeCapacity = math.floor(freeCapacity)
  end
  if freeCapacity > 99999 then
    freeCapacity = math.min(9999, math.floor(freeCapacity/1000)) .. "k"
  end
  capLabel:setText(tr('Cap') .. ':\n' .. freeCapacity * 100)
end

protocolgame.cpp

    msg.add<uint16_t>(player->getFreeCapacity() / 100);

 

[Sorky]

View attachment 90786

I have a problem with the cap, otclient is not recognizing the correct capacity. I'm using TFS 1.5 downgrade nekiro 772!


OTClientv8/invetory.lua

function onFreeCapacityChange(player, freeCapacity)
  if not freeCapacity then return end
  if freeCapacity > 99 then
    freeCapacity = math.floor(freeCapacity * 10) / 10
  end
  if freeCapacity > 999 then
    freeCapacity = math.floor(freeCapacity)
  end
  if freeCapacity > 99999 then
    freeCapacity = math.min(9999, math.floor(freeCapacity/1000)) .. "k"
  end
  capLabel:setText(tr('Cap') .. ':\n' .. freeCapacity * 100)
end

protocolgame.cpp

    msg.add<uint16_t>(player->getFreeCapacity() / 100);

this if if if statements is kidna wierd because with 100k cap it will go throught each of them
It will divide in first, go to second and then to third to add k.

  if freeCapacity > 99999 then
    freeCapacity = math.min(9999, math.floor(freeCapacity / 1000)) .. "k"
  elseif freeCapacity > 999 then
    freeCapacity = math.floor(freeCapacity)
  elseif freeCapacity > 99 then
    freeCapacity = math.floor(freeCapacity * 10) / 10
  end

replace with it

 

[Forkz]

this if if if statements is kidna wierd because with 100k cap it will go throught each of them
It will divide in first, go to second and then to third to add k.

  if freeCapacity > 99999 then
    freeCapacity = math.min(9999, math.floor(freeCapacity / 1000)) .. "k"
  elseif freeCapacity > 999 then
    freeCapacity = math.floor(freeCapacity)
  elseif freeCapacity > 99 then
    freeCapacity = math.floor(freeCapacity * 10) / 10
  end

replace with it

This is the default form of OTClientv8, I don't know why to write the code this way. My problem is how the trade module is "reading" the cap information. It is not in the correct form of the player's capacity

 

[Sorky]

This is the default form of OTClientv8, I don't know why to write the code this way. My problem is how the trade module is "reading" the cap information. It is not in the correct form of the player's capacity

i've gave you answer how to fix it

 

[Forkz]

this if if if statements is kidna wierd because with 100k cap it will go throught each of them
It will divide in first, go to second and then to third to add k.

  if freeCapacity > 99999 then
    freeCapacity = math.min(9999, math.floor(freeCapacity / 1000)) .. "k"
  elseif freeCapacity > 999 then
    freeCapacity = math.floor(freeCapacity)
  elseif freeCapacity > 99 then
    freeCapacity = math.floor(freeCapacity * 10) / 10
  end

replace with it

Not work

function onFreeCapacityChange(player, freeCapacity)
  if not freeCapacity then return end
  if freeCapacity > 99999 then
    freeCapacity = math.min(9999, math.floor(freeCapacity / 1000)) .. "k"
  elseif freeCapacity > 999 then
    freeCapacity = math.floor(freeCapacity)
  elseif freeCapacity > 99 then
    freeCapacity = math.floor(freeCapacity * 10) / 10
  end
  capLabel:setText(tr('Cap') .. ':\n' .. freeCapacity * 100)
end

I think the problem is in npctrade.lua

 

[Sorky]

Not work

function onFreeCapacityChange(player, freeCapacity)
  if not freeCapacity then return end
  if freeCapacity > 99999 then
    freeCapacity = math.min(9999, math.floor(freeCapacity / 1000)) .. "k"
  elseif freeCapacity > 999 then
    freeCapacity = math.floor(freeCapacity)
  elseif freeCapacity > 99 then
    freeCapacity = math.floor(freeCapacity * 10) / 10
  end
  capLabel:setText(tr('Cap') .. ':\n' .. freeCapacity * 100)
end

I think the problem is in npctrade.lua

you need to share it, i don't have your scripts

 

[Forkz]

you need to share it, i don't have your scripts

Sorry, rsrsrs

https://github.com/OTAcademy/otclientv8/blob/master/modules/game_npctrade/npctrade.lua

 

[Forkz]

up

 

[Bee King]

Our friend Mateus Roberto will fix this soon... but let's be patient, after all, it's help without financial return hahaha. When he has some free time, he will definitely do it, don't worry, my friend... in the meantime, tell the players to select the "ignored cap" option in the trade modal.

 

[L0FIC]

Many people asked me how to add NPC trade for TFS 1.5 7.72 and 8.0 as well. So, I decided to do it in a simple way. Here's the commit—be happy and enjoy it for the OTland community!

Add working NPC trade for 7.72 and 8.0. Works great! · Mateuzkl/TFS-1.5-772@73081a1

Alternative forgottenserver versions for older protocols support - Add working NPC trade for 7.72 and 8.0. Works great! · Mateuzkl/TFS-1.5-772@73081a1

github.com

Just ignore the NPC XML and Lua part; I was testing and forgot to remove it before committing. So, yes, just follow the NPC modules and the rest of the CPP and H files, and your NPC trade will be working fine!

View attachment 90782View attachment 90784

actual legend.. it works. thanks!!!