[TFS 1.5] Parcel window not closing if standing next to the mailbox.

[Oldesta]

I am working on a side project and have discovered a problem with TFS 1.5 where parcels are not closed when the player is standing next to the mailbox and sending the parcel.

What could be the reason for this?
Do want the parcel window to close when you send a parcel.
However, it closes if you stand a little away from the mailbox, but if you stand right next to the mailbox, the parcel window does not close.

 

[Sarah Wesker]

In the GitHub repository there is something related, maybe you have missed something:

Mailbox steal depot items bug, crash OTS bug [clone items] · Issue #4536 · otland/forgottenserver

Tested on TFS 1.4 Steps to reproduce You will need: 2 players mailbox within 1 SQM from depot [as it's in Kazordoon on 13+], so player can stand next to depot and mailbox in same time Test 1 is ran...

github.com

fix: close parcel send thru mail system to other player by omarcopires · Pull Request #4538 · otland/forgottenserver

Pull Request Prelude I have followed proper The Forgotten Server code styling. I have read and understood the contribution guidelines before making this PR. I am aware that this PR may be clo...

github.com

 

[Sorky]

I've done similliar fix on blacktek, the handling of closing containers in tfs is so fricking bad :/

issue-104: fix autoCloseContainers bahavior by Sorky96 · Pull Request #122 · Black-Tek/BlackTek-Server

A 2D Top Down (MMORPG) Game Server, with the goal of becoming a rapid development game engine someday - issue-104: fix autoCloseContainers bahavior by Sorky96 · Pull Request #122 · Black-Tek/BlackTek-Server

github.com

 

[Oldesta]

I've done similliar fix on blacktek, the handling of closing containers in tfs is so fricking bad :/

issue-104: fix autoCloseContainers bahavior by Sorky96 · Pull Request #122 · Black-Tek/BlackTek-Server

A 2D Top Down (MMORPG) Game Server, with the goal of becoming a rapid development game engine someday - issue-104: fix autoCloseContainers bahavior by Sorky96 · Pull Request #122 · Black-Tek/BlackTek-Server

github.com

I made the changes, but it does not compile properly after applying the changes.
Did you miss something maybe? Thanks

 

[Sorky]

I made the changes, but it does not compile properly after applying the changes.
Did you miss something maybe? Thanks

View attachment 94992

It's not tfs.
You would need adapt this code to tfs

 

[Oldesta]

I made the changes, but it does not compile properly after applying the changes.
Did you miss something maybe? Thanks

View attachment 94992

Works now, my bad. Thank you!