Tfs 1.5 weapon charges doesn't get decayed

[3alola1]

Hello

I have a problem with weapons where the charges doesn't decay at all how to solve this?

 

[VitoxMaster]

Maybe it will be my lucky guess but check your weapons.xml

<melee id="7858" level="45" action="removecharge" unproperly="1">
    <vocation name="Knight" />
</melee>

You have to define that this weapon will loose charges.
Additionally check your items.xml

    <item id="7858" article="an" name="earth dragon slayer">
        <attribute key="weight" value="8200" />
        <attribute key="defense" value="28" />
        <attribute key="attack" value="35" />
        <attribute key="weaponType" value="sword" />
        <attribute key="slotType" value="two-handed" />
        <attribute key="elementEarth" value="9" />
        <attribute key="charges" value="1000" />
        <attribute key="showcharges" value="1" />
        <attribute key="decayTo" value="7402" />
    </item>

 

[3alola1]

Maybe it will be my lucky guess but check your weapons.xml

<melee id="7858" level="45" action="removecharge" unproperly="1">
    <vocation name="Knight" />
</melee>

You have to define that this weapon will loose charges.
Additionally check your items.xml

    <item id="7858" article="an" name="earth dragon slayer">
        <attribute key="weight" value="8200" />
        <attribute key="defense" value="28" />
        <attribute key="attack" value="35" />
        <attribute key="weaponType" value="sword" />
        <attribute key="slotType" value="two-handed" />
        <attribute key="elementEarth" value="9" />
        <attribute key="charges" value="1000" />
        <attribute key="showcharges" value="1" />
        <attribute key="decayTo" value="7402" />
    </item>

yeah everything is set like this but still doesn't get decayed.

 

[VitoxMaster]

Do you have such property in your config.lua?

removeWeaponCharges = true

How does your implementation of removecharge look like?

        case WEAPONACTION_REMOVECHARGE: {
            uint16_t charges = item->getCharges();
            if (charges != 0 && g_config.getBoolean(ConfigManager::REMOVE_WEAPON_CHARGES)) {
                g_game.transformItem(item, item->getID(), charges - 1);
            }
            break;
        }

or lua binding

int LuaScriptInterface::luaWeaponAction(lua_State* L)
{
    // weapon:action(callback)
    Weapon* weapon = getUserdata<Weapon>(L, 1);
    if (weapon) {
        std::string typeName = getString(L, 2);
        std::string tmpStr = asLowerCaseString(typeName);
        if (tmpStr == "removecount") {
            weapon->action = WEAPONACTION_REMOVECOUNT;
        } else if (tmpStr == "removecharge") {
            weapon->action = WEAPONACTION_REMOVECHARGE;
        } else if (tmpStr == "move") {
            weapon->action = WEAPONACTION_MOVE;
        } else {
            std::cout << "Error: [Weapon::action] No valid action " << typeName << std::endl;
            pushBoolean(L, false);
        }
        pushBoolean(L, true);
    } else {
        lua_pushnil(L);
    }
    return 1;
}