TFS 1.X+ Tfs 1.x High CPU usage (think is attack Speed)

[roriscrave]

Hi, i'm getting cpu usage 70~85%, and i looking this topic i think it can be because attack Speed system

Solve my servers performance issue

Helllo, i am looking for someone that can solve my servers performance issues some info about server: the server i have worked on is mostly a project for me to learn lua and c++, but i have still been very cautious about adding loops and addevent that can ruin my performance. i have looked...

otland.net

But I use in config.lua

classicAttackSpeed = false

but i have changed this part of my player.h

forgottenserver/player.h at 8.6-downgrade · nekiro/forgottenserver

A free and open-source MMORPG server emulator written in C++ - forgottenserver/player.h at 8.6-downgrade · nekiro/forgottenserver

github.com

to it:

            int32_t SpeedAttack;
            SpeedAttack = vocation->getAttackSpeed() - player->getLevel());
                if (SpeedAttack < 500) {
                    return 500;
                } else {
                    return (uint32_t) SpeedAttack;
                }
        }

some players have speed attack 500ms, can it be the problem of high cpu usage?

 

[Ralumbi]

What kind of server are you running in first place? If its <= 8.6 I would say stick to classicAttackSpeed = true in your config.lua and see what the differences are.

And have you tried to reverse what you have changed?

If you're using the newer versions I would ask you to post your entire player.cpp and player.h in Pastebin.com - #1 paste tool since 2002! (https://pastebin.com/) and drop the links here so I(we all) can check what might be off in your code. Not sure if you've been changing a lot by yourself, could also cause issues if not thought about using same functions more then once and have it on loop by accident.
Those two files are connected to each other. I would not really go for the if/else you made there.

Sincerely,
Ralumbi(Caleb)

 

[roriscrave]

What kind of server are you running in first place? If its <= 8.6 I would say stick to classicAttackSpeed = true in your config.lua and see what the differences are.

And have you tried to reverse what you have changed?

If you're using the newer versions I would ask you to post your entire player.cpp and player.h in Pastebin.com - #1 paste tool since 2002! (https://pastebin.com/) and drop the links here so I(we all) can check what might be off in your code. Not sure if you've been changing a lot by yourself, could also cause issues if not thought about using same functions more then once and have it on loop by accident.
Those two files are connected to each other. I would not really go for the if/else you made there.

Sincerely,
Ralumbi(Caleb)

i dont make any changes in player.cpp
so here is my player.h, the unique change i made is in line 1171:

Ubuntu Pastebin

paste.ubuntu.com

default is:

        uint32_t getAttackSpeed() const {
            return vocation->getAttackSpeed();
        }

i changed to:

        uint32_t getAttackSpeed() const {
            int32_t SpeedAttack;
            SpeedAttack = vocation->getAttackSpeed() - player->getLevel());

                if (SpeedAttack < 500) {
                    return 500;
                } else {
                    return (uint32_t) SpeedAttack;
                }
        }

 

[Ralumbi]

In my head this piece of extra code does exactly nothing. Specially since you only did the change only in the header file.

 

[roriscrave]

In my head this piece of extra code does exactly nothing. Specially since you only did the change only in the header file.

but it work fine, i tested it.
so i dont know if my high cpu usage is because of this modification

 

[Ninja]

Install something like perf to determine whether the scheduler is being throttled or not. Someone might be taking advantage of the House bug that were brought to light a few days ago (See this).

 

[gudan garam]

Can you post prints of a perf top on your server?

 

[roriscrave]

Install something like perf to determine whether the scheduler is being throttled or not. Someone might be taking advantage of the House bug that were brought to light a few days ago (See this).

already make this change, but not change in my cpu usage

Can you post prints of a perf top on your server?

command perf top


command top: