Lua TFS 1.x - player:getStorageValue not working with this script?

[Extrodus]

So I'm trying to create a script that checks if the player has all the storages from Act I in order to start Act II but currently, all it does is tell me I have already started Act II even though I don't have the storages.

Here's the code, I'm sure I have a small error somewhere.

function onUse(cid, item, fromPosition, target, toPosition, isHotkey)
   local player = Player(cid)
     if not Player(player) then
  return false
  end
  if item:getActionId(6001) and player:getStorageValue(37113) and player:getStorageValue(37114) and player:getStorageValue(37115) and player:getStorageValue(37116) and player:getStorageValue(37117) and player:getStorageValue(37118) then
       player:sendTextMessage(MESSAGE_INFO_DESCR, "You have unlocked the Temporal Shrine of [Act II]!")
       player:setStorageValue(37121, 1)
       player:setStorageValue(37122, 1)
     else
       player:sendTextMessage(MESSAGE_INFO_DESCR, "You need to activate all the shrines of [Act I] before continuing!")
       return false
     end
   if item:getActionId(6001) and player:getStorageValue(37121,1) then
     player:sendTextMessage(MESSAGE_INFO_DESCR, "You have already started [Act II]! Say !travel to continue.")
     return true
   end
  return true
end

Thanks in advance!

 

[narko]

You missed the storage's value in the condition, for example: player:getStorageValue(37113) =< 1

 

[WibbenZ]

Also you can't do a check in the getStorageValue function (last if statment).
The correct way is to compare it to an integer ex.

player:getStorageValue(37121) == 1

 

[hellboy]

On TFS 1.2, (maybe 1.1 too?) you should remove lines:

local player = Player(cid)
if not Player(player) then
return false
end

And change function declaration to:

function onUse(player, item, fromPosition, target, toPosition, isHotkey)

 

[Extrodus]

Thanks a ton guys! The fix was clarifying the storages like @WibbenZ suggested, also thanks @hellboy for the tip on change the onUse function; cleans the script up Rep++

Here's what it looks like now thanks to your help, and also if anyone needs a script like this for other purposes ;D Little bit cleaner now, and re-organized to work properly.

function onUse(player, item, fromPosition, target, toPosition, isHotkey)
     if item:getActionId(6001) and player:getStorageValue(37121) == 1 then
        player:sendTextMessage(MESSAGE_INFO_DESCR, "You have already started [Act II]! Say !travel to continue.")
     elseif player:getStorageValue(37113) == 1 and player:getStorageValue(37114) == 1 and player:getStorageValue(37115) == 1 and player:getStorageValue(37116) == 1 and player:getStorageValue(37117) == 1 and player:getStorageValue(37118) == 1 then
        player:sendTextMessage(MESSAGE_INFO_DESCR, "You have unlocked the Temporal Shrine of [Act II]!")
        player:setStorageValue(37121, 1)
        player:setStorageValue(37122, 1)
     else
        player:sendTextMessage(MESSAGE_INFO_DESCR, "You need to activate all the shrines of [Act I] before continuing!")
     end
  return true
end