• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Tfs 1x Guild bonus online

T

theduck

Member
Joined
Dec 6, 2018
Messages
246
Reaction score
20
Code: 
function onLogin(cid)
    local g = getPlayerGuildId(cid)
    if g ~= 0 then
        local n = 1
        for _, pid in ipairs(getPlayersOnline()) do
            if getPlayerGuildId(pid) == g then
                n = n + 1
                if n == 5 then
                    doPlayerSetRate(pid, SKILL__LEVEL, 1.05)
doPlayerSendTextMessage(pid, MESSAGE_INFO_DESCR, 'You received 5% extra experience for being in a guild with more than five players online.')
                    break
                end
            end
        end
    end

    return true
end

I'm having problems with this script
: attempt to call global 'getPlayersOnline' (a nil value
 
Solution
Z
Hello,
Try this one:
Lua: 
function onLogin(player)
    local playerGuild = player:getGuild() --get player guild
    if playerGuild then --if player have a guild
        if #playerGuild:getMembersOnline() >= 5 then --get online members in the guild, if more than 5
            player:setStorageValue(1577534,1) --give storage to player
            player:sendTextMessage(MESSAGE_EVENT_ADVANCE , '[Boost]: You received 5% extra experience for being in a guild with more than five players online.') --send msg to player
        end
    end
    return true
end
My onLogin function already pass the player userdata as variable, if your don't, just change back and use in line 2: local player = Player(cid) to access the...
Sort by date Sort by votes
Try this
Lua: 
function onLogin(cid)
    local g = getPlayerGuildId(cid)
    if g ~= 0 then
        local n = 1
        for _, pid in ipairs(Game.getPlayers()) do
            if getPlayerGuildId(pid) == g then
                n = n + 1
                if n == 5 then
                    doPlayerSetRate(pid, SKILL__LEVEL, 1.05)
doPlayerSendTextMessage(pid, MESSAGE_INFO_DESCR, 'You received 5% extra experience for being in a guild with more than five players online.')
                    break
                end
            end
        end
    end

    return true
end
 
Upvote 0 Downvote
M0ustafa said:
Try this
Lua: 
function onLogin(cid)
    local g = getPlayerGuildId(cid)
    if g ~= 0 then
        local n = 1
        for _, pid in ipairs(Game.getPlayers()) do
            if getPlayerGuildId(pid) == g then
                n = n + 1
                if n == 5 then
                    doPlayerSetRate(pid, SKILL__LEVEL, 1.05)
doPlayerSendTextMessage(pid, MESSAGE_INFO_DESCR, 'You received 5% extra experience for being in a guild with more than five players online.')
                    break
                end
            end
        end
    end

    return true
end
Click to expand...
attempt to call global 'doPlayerSetRate' (a nil value)
 
Upvote 0 Downvote
tfs 1.x doesn't have doPlayerSetRate, you will need to set a storage and on the player.lua OnGainExperience event add the storage check and exp multiplier
 
Upvote 0 Downvote
Evil Puncker said:
tfs 1.x doesn't have doPlayerSetRate, you will need to set a storage and on the player.lua OnGainExperience event add the storage check and exp multiplier
Click to expand...
Yes! I was about to comment on this now the only problem that now he is giving storage to everyone even those who do not have guild
Code: 
function onLogin(cid)
    local player = Player(cid)
    local g = getPlayerGuildId(cid)
    if g ~= 0 then
        local n = 1
        for _, pid in ipairs(Game.getPlayers()) do
            if getPlayerGuildId(pid) == g then
                n = n + 1
                if n == 2 then
                 player:setStorageValue(1577534,1)
     player:sendTextMessage(MESSAGE_EVENT_ADVANCE , '[Boost]: You received 5% extra experience for being in a guild with more than five players online.') 
                    break
                end
            end
        end
    end

    return true
end
 
Upvote 0 Downvote
Hello,
Try this one:
Lua: 
function onLogin(player)
    local playerGuild = player:getGuild() --get player guild
    if playerGuild then --if player have a guild
        if #playerGuild:getMembersOnline() >= 5 then --get online members in the guild, if more than 5
            player:setStorageValue(1577534,1) --give storage to player
            player:sendTextMessage(MESSAGE_EVENT_ADVANCE , '[Boost]: You received 5% extra experience for being in a guild with more than five players online.') --send msg to player
        end
    end
    return true
end
My onLogin function already pass the player userdata as variable, if your don't, just change back and use in line 2: local player = Player(cid) to access the player userdata.
 
Upvote 0 Downvote
Solution
zxmatzx said:
Hello,
Try this one:
Lua: 
function onLogin(player)
    local playerGuild = player:getGuild() --get player guild
    if playerGuild then --if player have a guild
        if #playerGuild:getMembersOnline() >= 5 then --get online members in the guild, if more than 5
            player:setStorageValue(1577534,1) --give storage to player
            player:sendTextMessage(MESSAGE_EVENT_ADVANCE , '[Boost]: You received 5% extra experience for being in a guild with more than five players online.') --send msg to player
        end
    end
    return true
end
My onLogin function already pass the player userdata as variable, if your don't, just change back and use in line 2: local player = Player(cid) to access the player userdata.
Click to expand...
Perfect! a doubt is it possible to check the ip?
 
Upvote 0 Downvote
theduck said:
Perfect! a doubt is it possible to check the ip?
Click to expand...
Try this:
Lua: 
function onLogin(player)
    local playerGuild = player:getGuild() --get player guild
    if playerGuild then --if player have a guild
        local GuildOnlineMembers = playerGuild:getMembersOnline() --get all online player in player guild
        local realOnlineMembers = {} --empty table to hold all players that is online and don't have same ip; tableStructure = {[ip] = {playerOnThisIp}}
        for i = 1, #GuildOnlineMembers do --for each player in online members
            local tempPlayer = GuildOnlineMembers[i] --get player userdata
            if not realOnlineMembers[tempPlayer:getIp()] then --if don't exist index with tempPlayer ip
                realOnlineMembers[tempPlayer:getIp()] = {tempPlayer} --create a index with tempPlayer ip and store tempPlayer userdata as value
            else--if already exist tempPlayer IP as index
                table.insert(realOnlineMembers[tempPlayer:getIp()], tempPlayer) --insert player userdata in the IP index
            end
        end
       
        if #realOnlineMembers >= 5 then --get online ips in guild, if more than 5
            player:setStorageValue(1577534,1) --give storage to player
            player:sendTextMessage(MESSAGE_EVENT_ADVANCE , '[Boost]: You received 5% extra experience for being in a guild with more than five players online.') --send msg to player
        end
    end
    return true
end

Not tested.
 
Upvote 0 Downvote
zxmatzx said:
Try this:
Lua: 
function onLogin(player)
    local playerGuild = player:getGuild() --get player guild
    if playerGuild then --if player have a guild
        local GuildOnlineMembers = playerGuild:getMembersOnline() --get all online player in player guild
        local realOnlineMembers = {} --empty table to hold all players that is online and don't have same ip; tableStructure = {[ip] = {playerOnThisIp}}
        for i = 1, #GuildOnlineMembers do --for each player in online members
            local tempPlayer = GuildOnlineMembers[i] --get player userdata
            if not realOnlineMembers[tempPlayer:getIp()] then --if don't exist index with tempPlayer ip
                realOnlineMembers[tempPlayer:getIp()] = {tempPlayer} --create a index with tempPlayer ip and store tempPlayer userdata as value
            else--if already exist tempPlayer IP as index
                table.insert(realOnlineMembers[tempPlayer:getIp()], tempPlayer) --insert player userdata in the IP index
            end
        end
      
        if #realOnlineMembers >= 5 then --get online ips in guild, if more than 5
            player:setStorageValue(1577534,1) --give storage to player
            player:sendTextMessage(MESSAGE_EVENT_ADVANCE , '[Boost]: You received 5% extra experience for being in a guild with more than five players online.') --send msg to player
        end
    end
    return true
end

Not tested.
Click to expand...
so test is not showing the bonus msg

but there is no error on the console
 
Upvote 0 Downvote
theduck said:
so test is not showing the bonus msg

but there is no error on the console
Click to expand...
use debug.print to help find where the issues are. This lets you see what is being loaded and what isnt. So add like debug.print("Loaded player storage" or whatever in your code. It helps isolate issues more or less
 
Upvote 0 Downvote
athenso said:
use debug.print to help find where the issues are. This lets you see what is being loaded and what isnt. So add like debug.print("Loaded player storage" or whatever in your code. It helps isolate issues more or less
Click to expand...
print is not a part of the debug library, it's a global function.


Use this, the # operator does not work on unordered tables.
Lua: 
function table.size(t, deep)
    local size = 0
    for k, v in pairs(t) do
        size = size + 1
        if type(v) == 'table' and deep then
            size = size + table.size(v, deep)
        end
    end
    return size
end

function onLogin(player)
    local playerGuild = player:getGuild() --get player guild
    if playerGuild then --if player have a guild
        local GuildOnlineMembers = playerGuild:getMembersOnline() --get all online player in player guild
        local realOnlineMembers = {} --empty table to hold all players that is online and don't have same ip; tableStructure = {[ip] = {playerOnThisIp}}
        for i = 1, #GuildOnlineMembers do --for each player in online members
            local tempPlayer = GuildOnlineMembers[i] --get player userdata
            if not realOnlineMembers[tempPlayer:getIp()] then --if don't exist index with tempPlayer ip
                realOnlineMembers[tempPlayer:getIp()] = {tempPlayer} --create a index with tempPlayer ip and store tempPlayer userdata as value
            else--if already exist tempPlayer IP as index
                table.insert(realOnlineMembers[tempPlayer:getIp()], tempPlayer) --insert player userdata in the IP index
            end
        end
       
        if table.size(realOnlineMembers) >= 5 then --get online ips in guild, if more than 5
            player:setStorageValue(1577534,1) --give storage to player
            player:sendTextMessage(MESSAGE_EVENT_ADVANCE , '[Boost]: You received 5% extra experience for being in a guild with more than five players online.') --send msg to player
        end
    end
    return true
end
 
Upvote 0 Downvote
Delusion said:
print is not a part of the debug library, it's a global function.


Use this, the # operator does not work on unordered tables.
Lua: 
function table.size(t, deep)
    local size = 0
    for k, v in pairs(t) do
        size = size + 1
        if type(v) == 'table' and deep then
            size = size + table.size(v, deep)
        end
    end
    return size
end

function onLogin(player)
    local playerGuild = player:getGuild() --get player guild
    if playerGuild then --if player have a guild
        local GuildOnlineMembers = playerGuild:getMembersOnline() --get all online player in player guild
        local realOnlineMembers = {} --empty table to hold all players that is online and don't have same ip; tableStructure = {[ip] = {playerOnThisIp}}
        for i = 1, #GuildOnlineMembers do --for each player in online members
            local tempPlayer = GuildOnlineMembers[i] --get player userdata
            if not realOnlineMembers[tempPlayer:getIp()] then --if don't exist index with tempPlayer ip
                realOnlineMembers[tempPlayer:getIp()] = {tempPlayer} --create a index with tempPlayer ip and store tempPlayer userdata as value
            else--if already exist tempPlayer IP as index
                table.insert(realOnlineMembers[tempPlayer:getIp()], tempPlayer) --insert player userdata in the IP index
            end
        end
      
        if table.size(realOnlineMembers) >= 5 then --get online ips in guild, if more than 5
            player:setStorageValue(1577534,1) --give storage to player
            player:sendTextMessage(MESSAGE_EVENT_ADVANCE , '[Boost]: You received 5% extra experience for being in a guild with more than five players online.') --send msg to player
        end
    end
    return true
end
Click to expand...
worked perfectly
thank you all!
 
Upvote 0 Downvote
zxmatzx said:
Try this:
Lua: 
function onLogin(player)
    local playerGuild = player:getGuild() --get player guild
    if playerGuild then --if player have a guild
        local GuildOnlineMembers = playerGuild:getMembersOnline() --get all online player in player guild
        local realOnlineMembers = {} --empty table to hold all players that is online and don't have same ip; tableStructure = {[ip] = {playerOnThisIp}}
        for i = 1, #GuildOnlineMembers do --for each player in online members
            local tempPlayer = GuildOnlineMembers[i] --get player userdata
            if not realOnlineMembers[tempPlayer:getIp()] then --if don't exist index with tempPlayer ip
                realOnlineMembers[tempPlayer:getIp()] = {tempPlayer} --create a index with tempPlayer ip and store tempPlayer userdata as value
            else--if already exist tempPlayer IP as index
                table.insert(realOnlineMembers[tempPlayer:getIp()], tempPlayer) --insert player userdata in the IP index
            end
        end
      
        if #realOnlineMembers >= 5 then --get online ips in guild, if more than 5
            player:setStorageValue(1577534,1) --give storage to player
            player:sendTextMessage(MESSAGE_EVENT_ADVANCE , '[Boost]: You received 5% extra experience for being in a guild with more than five players online.') --send msg to player
        end
    end
    return true
end

Not tested.
Click to expand...
can you help me installing this?
 
Upvote 0 Downvote
Lua: 
player:setStorageValue(1577534,1) --give storage to player

so this storagevalue holds the formula for extra 5%exp right?
where is this storagevalue registered? is it meant to be in player.lua?
 
Upvote 0 Downvote

Similar threads

G
  • Solved
Lua amendment Reset System (otx-8.60)
Replies
13
Views
1K
Mateus Robeerto
Mateus Robeerto
A
  • Question
Lua Convert Script TFS 0.4 to TFS 1.5 downgrade
Replies
7
Views
577
stevanmayan
S
L
  • Question
RevScripts I need help TASK SYSTEM TFS 1.3
Replies
3
Views
345
adric21
adric21
I
  • Question
Lua TFS 1.3 Task System with points
Replies
4
Views
698
Icaraii
I
OTcreator
  • Question
Collection TFS 1.4.2
Replies
4
Views
678
delikerem
D
potinho
  • Question
Lua [TFS 0.X] Improve Reward Chest System
Replies
1
Views
239
potinho
potinho
B
  • Question
Lua Error in Reset System (TFS 0.4)
Replies
1
Views
398
Mateus Robeerto
Mateus Robeerto
OTcreator
  • Question
Edit Snavy box script.
Replies
0
Views
184
OTcreator
OTcreator
G
  • Question
Lua amendment/ Full Script Resets distinct
Replies
0
Views
84
Gaber Zen
G
thokito
  • Question
real castle error
Replies
0
Views
140
thokito
thokito
Back
Top