The problem with the declaration

[vvafel]

Hello, I have a small problem


In combat.ccp:

void Combat::getMinMaxValues(Creature* creature, Creature* target, int32_t& min, int32_t& max) const
{
	if(!creature){
		return;
	}

	if(Player* player = creature->getPlayer()){
		if(params.valueCallback){
			params.valueCallback->getMinMaxValues(player, min, max);
		}
		else{
			switch(formulaType){
				case FORMULA_LEVELMAGIC:
				{
					max = (int32_t)((player->getLevel() * 2 + player->getMagicLevel() * 3) * 1. * mina + minb);
					min = (int32_t)((player->getLevel() * 2 + player->getMagicLevel() * 3) * 1. * maxa + maxb);
					break;
				}

I change for:

void Combat::getMinMaxValues(Creature* creature, Creature* target, int32_t& min, int32_t& max) const
{
	if(!creature){
		return;
	}

	if(Player* player = creature->getPlayer()){
		if(params.valueCallback){
			params.valueCallback->getMinMaxValues(player, min, max);
		}
		else{
			switch(formulaType){
				case FORMULA_LEVELMAGIC:
				{
					max = (int32_t)(((player->getLevel() * 2 + player->getMagicLevel() * 3) * 1. * mina + minb) * vocation->getMagicDamage());
					min = (int32_t)(((player->getLevel() * 2 + player->getMagicLevel() * 3) * 1. * maxa + maxb) * vocation->getMagicDamage());
					break;
				}

Then an error appears:

../combat.cpp: In member function `void Combat::getMinMaxValues(Creature*, Creature*, int32_t&, int32_t&) const':
../combat.cpp:77: error: `vocation' was not declared in this scope

make.exe: *** [../combat.o] Error 1

Please help. Vvafel

 

[Pitufo™]

Idk if this works because im outdated from sources, long time since looking at the sources.

Change:

vocation->getMagicDamage()

To:

player->getVocation()->getMagicDamage()

 

[vvafel]

Also do not work ;/

 

[Pitufo™]

Try this one:

player->getVocation()->getMultiplier(MULTIPLIER_MAGIC)

Edit: I tried with this one on my sources and it works fine.

 

[vvafel]

../combat.cpp: In member function `void Combat::getMinMaxValues(Creature*, Creature*, int32_t&, int32_t&) const':
../combat.cpp:77: error: 'class Player' has no member named 'getVocation'
../combat.cpp:77: error: `MULTIPLIER_MAGIC' was not declared in this scope

../combat.cpp:78: error: 'class Player' has no member named 'getVocation'

make.exe: *** [../combat.o] Error 1

 

[Pitufo™]

Which sources are you using?

 

[vvafel]

Hey i have Devland 8.0 sql 0.97b

I invented that I can do this:

In combat.ccp

void Combat::getMinMaxValues(Creature* creature, Creature* target, int32_t& min, int32_t& max) const
{
	if(!creature){
		return;
	}

	if(Player* player = creature->getPlayer()){
		if(params.valueCallback){
			params.valueCallback->getMinMaxValues(player, min, max);
		}
		else{
			switch(formulaType){
				case FORMULA_LEVELMAGIC:
				{
					max = (int32_t)(((player->getLevel() * 2 + player->getMagicLevel() * 3) * 1. * mina + minb) * player->getMagicDamage());
					min = (int32_t)(((player->getLevel() * 2 + player->getMagicLevel() * 3) * 1. * maxa + maxb) * player->getMagicDamage());
					break;
				}

In player.ccp I added to:

uint16_t Player::getMagicDamage()
{
	return vocation->getMagicDamage();
}

And, unfortunately, an error occurred:

../combat.cpp: In member function `void Combat::getMinMaxValues(Creature*, Creature*, int32_t&, int32_t&) const':
../combat.cpp:77: error: 'class Player' has no member named 'getMagicDamage'

../combat.cpp:78: error: 'class Player' has no member named 'getMagicDamage'

make.exe: *** [../combat.o] Error 1

 

[Pitufo™]

OMG very old sources, i dont have those sources... I suggest you downloading newest sources.

 

[vvafel]

No way, too many have already done here.

 

[Pitufo™]

Well, then what you can make its try to find the variable of the "magic multiplier" of the player's vocation in the whole project and then in anyway you can implement it to your function.

 

[Evil Hero]

add at top:

#include "vocations.h"

and try it like this:

player->Vocation::getMagicDamage()

 

[Pitufo™]

The problem is that in his sources there is not getMagicDamage() function...

 

[koob]

so write one ?