• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

TFS 1.X+ Trying to get a Monster Counter

Szka

Szka

Member
Joined
Jul 27, 2016
Messages
65
Reaction score
11
Location
Chile
Hello, I'm using TFS 1.5 the Nekiro downgraded version 8.60. And I managed to get the questlog working perfectly, but I'm trying to get the player an update eachtime a rotworm gets killed.
For now, I'm not getting the missionstate updated when the rotworm is getting killed, and I use a "print" to check if the script is being trigerred but it is not.

Here it is my script when killing a rotworm, I added it on creaturescripts.xml as an "kill" event type.


Lua: 
function onKill(player, target)
    print("onKill function triggered")  -- Debugging line

    if target:getName():lower() ~= "rotworm" then
        print("Target is not a rotworm")  -- Debugging line
        return true
    end

    local cid = player:getId()
    local mission1DirtyBeginning = 25003
    local currentCount = player:getStorageValue(mission1DirtyBeginning)

    print("Rotworm killed by player ID: " .. cid)  -- Debugging line

    if currentCount >= 0 and currentCount < 16 then
        player:setStorageValue(mission1DirtyBeginning, currentCount + 1)
        print("Player ID: " .. cid .. " has killed a rotworm. Count: " .. (currentCount + 1))
    end

    return true
end

And here it is my quests.xml to be easier to understand the missionstates id.

XML: 
<?xml version="1.0" encoding="UTF-8"?>
<quests>
<quest name="Questing, the chest" startstorageid="80555" startstoragevalue="1">
        <mission name="A Dirty Beginning" storageid="25003" startvalue="0" endvalue="17">
            <missionstate id="0" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 0 of 15 rotworms killed."/>
            <missionstate id="1" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 1 of 15 rotworms killed."/>
            <missionstate id="2" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 2 of 15 rotworms killed."/>
            <missionstate id="3" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 3 of 15 rotworms killed."/>
            <missionstate id="4" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 4 of 15 rotworms killed."/>
            <missionstate id="5" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 5 of 15 rotworms killed."/>
            <missionstate id="6" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 6 of 15 rotworms killed."/>
            <missionstate id="7" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 7 of 15 rotworms killed."/>
            <missionstate id="8" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 8 of 15 rotworms killed."/>
            <missionstate id="9" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 9 of 15 rotworms killed."/>
            <missionstate id="10" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 10 of 15 rotworms killed."/>
            <missionstate id="11" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 11 of 15 rotworms killed."/>
            <missionstate id="12" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 12 of 15 rotworms killed."/>
            <missionstate id="13" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 13 of 15 rotworms killed."/>
            <missionstate id="14" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 14 of 15 rotworms killed."/>
            <missionstate id="15" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 15 of 15 rotworms killed."/>
            <missionstate id="16" description="You killed all the dirty beasts. You should probably go and talk to Questing now."/>
            <missionstate id="17" description="You proved yourself to Questing. If you help unlock him from the chest and his curse, you will be trully rewarded."/>
        </mission>
    </quest>
</quests>

My npc is working excellent, so it is just that I cant manage to storage the monster killing count
Thank you so much, I'm very rusty with scripting so I imagine I made some mistakes. I don't remember too so much how to call some functions as I used to work with tfs .3 and .4
 
Solution
Xikini
Szka said:
Hello, I'm using TFS 1.5 the Nekiro downgraded version 8.60. And I managed to get the questlog working perfectly, but I'm trying to get the player an update eachtime a rotworm gets killed.
For now, I'm not getting the missionstate updated when the rotworm is getting killed, and I use a "print" to check if the script is being trigerred but it is not.

Here it is my script when killing a rotworm, I added it on creaturescripts.xml as an "kill" event type.


Lua: 
function onKill(player, target)
    print("onKill function triggered")  -- Debugging line

    if target:getName():lower() ~= "rotworm" then
        print("Target is not a rotworm")  -- Debugging line
        return true
    end

    local cid = player:getId()
    local...
Click to expand...
Sort by date Sort by votes
Szka said:
Hello, I'm using TFS 1.5 the Nekiro downgraded version 8.60. And I managed to get the questlog working perfectly, but I'm trying to get the player an update eachtime a rotworm gets killed.
For now, I'm not getting the missionstate updated when the rotworm is getting killed, and I use a "print" to check if the script is being trigerred but it is not.

Here it is my script when killing a rotworm, I added it on creaturescripts.xml as an "kill" event type.


Lua: 
function onKill(player, target)
    print("onKill function triggered")  -- Debugging line

    if target:getName():lower() ~= "rotworm" then
        print("Target is not a rotworm")  -- Debugging line
        return true
    end

    local cid = player:getId()
    local mission1DirtyBeginning = 25003
    local currentCount = player:getStorageValue(mission1DirtyBeginning)

    print("Rotworm killed by player ID: " .. cid)  -- Debugging line

    if currentCount >= 0 and currentCount < 16 then
        player:setStorageValue(mission1DirtyBeginning, currentCount + 1)
        print("Player ID: " .. cid .. " has killed a rotworm. Count: " .. (currentCount + 1))
    end

    return true
end

And here it is my quests.xml to be easier to understand the missionstates id.

XML: 
<?xml version="1.0" encoding="UTF-8"?>
<quests>
<quest name="Questing, the chest" startstorageid="80555" startstoragevalue="1">
        <mission name="A Dirty Beginning" storageid="25003" startvalue="0" endvalue="17">
            <missionstate id="0" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 0 of 15 rotworms killed."/>
            <missionstate id="1" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 1 of 15 rotworms killed."/>
            <missionstate id="2" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 2 of 15 rotworms killed."/>
            <missionstate id="3" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 3 of 15 rotworms killed."/>
            <missionstate id="4" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 4 of 15 rotworms killed."/>
            <missionstate id="5" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 5 of 15 rotworms killed."/>
            <missionstate id="6" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 6 of 15 rotworms killed."/>
            <missionstate id="7" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 7 of 15 rotworms killed."/>
            <missionstate id="8" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 8 of 15 rotworms killed."/>
            <missionstate id="9" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 9 of 15 rotworms killed."/>
            <missionstate id="10" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 10 of 15 rotworms killed."/>
            <missionstate id="11" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 11 of 15 rotworms killed."/>
            <missionstate id="12" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 12 of 15 rotworms killed."/>
            <missionstate id="13" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 13 of 15 rotworms killed."/>
            <missionstate id="14" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 14 of 15 rotworms killed."/>
            <missionstate id="15" description="Questing has been cursed and is trapped in a chest. He asked you to kill 15 rotworms below the city to see if you can handle yourself. 15 of 15 rotworms killed."/>
            <missionstate id="16" description="You killed all the dirty beasts. You should probably go and talk to Questing now."/>
            <missionstate id="17" description="You proved yourself to Questing. If you help unlock him from the chest and his curse, you will be trully rewarded."/>
        </mission>
    </quest>
</quests>

My npc is working excellent, so it is just that I cant manage to storage the monster killing count
Thank you so much, I'm very rusty with scripting so I imagine I made some mistakes. I don't remember too so much how to call some functions as I used to work with tfs .3 and .4
Click to expand...
You need to register the onKill event to the player in login.lua (near the bottom with the other registered events)
Then the event will have a way to be triggered.

probably worth to check that the target is a monster as well, otherwise a player named "rotworm" could be used to trigger the quest status.
 
Upvote 0 Downvote
Solution
Upvote 0 Downvote
Xikini said:
You need to register the onKill event to the player in login.lua (near the bottom with the other registered events)
Then the event will have a way to be triggered.

probably worth to check that the target is a monster as well, otherwise a player named "rotworm" could be used to trigger the quest status.
Click to expand...
Okay, I will check around the registered events at login.lua, will edit this comment if its work

highsanta said:
otland.net

Feature - TFS[1.4.2] Questlog/Task counter: Storage tracker in description as string

Greetings! I was in need of a task tracker inside the questlog and i did not find anything here on the forum, except for TFS 0.X versions. So i wanted to share this, as i think many could need it. I am fairly new to C++ so It is made with assistance from ChatGPT and it has 1 flaw, it does not...
otland.net otland.net
use this its way better
Click to expand...
I will try first with my script, maybe it is just that at login.lua I never register the event and then will try out with this one

Thank you lads
 
Upvote 0 Downvote
highsanta said:
otland.net

Feature - TFS[1.4.2] Questlog/Task counter: Storage tracker in description as string

Greetings! I was in need of a task tracker inside the questlog and i did not find anything here on the forum, except for TFS 0.X versions. So i wanted to share this, as i think many could need it. I am fairly new to C++ so It is made with assistance from ChatGPT and it has 1 flaw, it does not...
otland.net otland.net
use this its way better
Click to expand...

This is the better way indeed.
You just add storage to whatever your STATE is.

Now you have to create 15 different mission states, for like one setting...
Lua: 
<quest name="Character Statistics" startstorageid="1001" startstoragevalue="0">
        <mission name="General" storageid="249" startvalue="1" endvalue="2">
            <missionstate id="1" description="Discovered Locations: |STATE|250|"/>
        </mission>

With this, you can just add storage to 250 and it will count the STATE a number up and keep your quest file somewhat organized.

I just have to add for my example whenever someone walks on specific tiles the following:

Code: 
player:setStorageValue(250, 1)

4d1957881b7fa0c221a88b96d87d1861.png
 
Upvote 0 Downvote
Xikini said:
You need to register the onKill event to the player in login.lua (near the bottom with the other registered events)
Then the event will have a way to be triggered.

probably worth to check that the target is a monster as well, otherwise a player named "rotworm" could be used to trigger the quest status.
Click to expand...
I needed to register the event... Thank you very much !!
This was the solution to get it work!
 
Upvote 0 Downvote

Similar threads

B
  • Question
portal quest scripts, TFS 1.4.2
Replies
0
Views
417
bravespiritz
B
D
  • Question
TFS1.5 Downgraded to 8.6 Quest Log Support
Replies
6
Views
430
dyl12189
D
B
  • Solved
Lua Script Error: [Test Interface]
2
Replies
29
Views
2K
bravespiritz
B
VitoxMaster
  • Question
Solved Server crash - onLookInShop for container
Replies
1
Views
293
VitoxMaster
VitoxMaster
Narg
  • Question
OTClient Help adding and displaying Icons for custom Conditions in OTClient?
Replies
0
Views
105
Narg
Narg
ralke
  • Question
Lua Wrath of emperor mission 11 payback time
Replies
0
Views
175
ralke
ralke
J
  • Solved
tfs 1.5 8.6 You see a pool of beer. when use a great spirit potion on the floor. only monsters You see a pool of lifefluid.
Replies
2
Views
372
Jeyci
J
Back
Top