TFS 0.X Upgrade Staff - Prevent use itself

[potinho]

Hello guys,

I have a working script for an upgrade staff (upgrade system), the item has the ID 5114 and I want it to be impossible for players to use it on it, could you help me?

function onUse(cid, item, fromPosition, itemEx, toPosition)
if isCreature(itemEx.uid) then    
    return doPlayerSendDefaultCancel(cid, RETURNVALUE_NOTPOSSIBLE)
end

local obj = UpgradeHandler:new(itemEx)

if(obj == false) then
    return doPlayerSendCancel(cid, UpgradeHandler.message.notupgradeable)
end

local status = obj:refine(cid, item)
if status == "success" then
    doSendAnimatedText(toPosition, "Success!", COLOR_GREEN)
    doSendMagicEffect(toPosition, CONST_ME_MAGIC_GREEN)
elseif status == "fail" then
    doSendAnimatedText(toPosition, "Fail!", COLOR_RED)
    doSendMagicEffect(toPosition, CONST_ME_POFF)
else
    doSendMagicEffect(toPosition, CONST_ME_POFF)
end
return true
end

 

[Ramon Bernardo]

Try this

if cid == itemEx.uid then  
    ...
end

or

if cid == itemEx.uid or isCreature(itemEx.uid) then   
    return doPlayerSendDefaultCancel(cid, RETURNVALUE_NOTPOSSIBLE)
end

 

[potinho]

Works, but got error in console:



Actual script:

function onUse(cid, item, fromPosition, itemEx, toPosition)
if cid.uid == itemEx.uid then   
    return doPlayerSendDefaultCancel(cid, RETURNVALUE_NOTPOSSIBLE)
end

if isCreature(itemEx.uid) then    
    return doPlayerSendDefaultCancel(cid, RETURNVALUE_NOTPOSSIBLE)
end


local obj = UpgradeHandler:new(itemEx)

if(obj == false) then
    return doPlayerSendCancel(cid, UpgradeHandler.message.notupgradeable)
end

local status = obj:refine(cid, item)
if status == "success" then
    doSendAnimatedText(toPosition, "Success!", COLOR_GREEN)
    doSendMagicEffect(toPosition, CONST_ME_MAGIC_GREEN)
elseif status == "fail" then
    doSendAnimatedText(toPosition, "Fail!", COLOR_RED)
    doSendMagicEffect(toPosition, CONST_ME_POFF)
else
    doSendMagicEffect(toPosition, CONST_ME_POFF)
end
return true
end

 

[Ramon Bernardo]

Remove .uid from cid

cid == itemEx.uid

 

[potinho]

Remove .uid from cid

cid == itemEx.uid

Now staff is gone, and got error in console

 

[Xikini]

cid is the creature. item is the item being used. itemex is the target of crosshairs.

cid is useless in this situation.

just use

if item.uid == itemEx.uid then
       print("item used on itself")
end

 

[potinho]

cid is the creature. item is the item being used. itemex is the target of crosshairs.

cid is useless in this situation.

just use

if item.uid == itemEx.uid then
       print("item used on itself")
end

Works Xiki, thank you