• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

C++ vocation.cpp edit

Makin

Makin

New Member
Joined
Sep 17, 2018
Messages
37
Solutions
1
Reaction score
2
Hi, how can i redo this code
C++: 
/**
* The Forgotten Server - a free and open-source MMORPG server emulator
* Copyright (C) 2016  Mark Samman <[email protected]>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/

#include "otpch.h"

#include "vocation.h"

#include "pugicast.h"
#include "tools.h"

bool Vocations::loadFromXml()
{
    pugi::xml_document doc;
    pugi::xml_parse_result result = doc.load_file("data/XML/vocations.xml");
    if (!result) {
        printXMLError("Error - Vocations::loadFromXml", "data/XML/vocations.xml", result);
        return false;
    }

    for (auto vocationNode : doc.child("vocations").children()) {
        pugi::xml_attribute attr;
        if (!(attr = vocationNode.attribute("id"))) {
            std::cout << "[Warning - Vocations::loadFromXml] Missing vocation id" << std::endl;
            continue;
        }

        uint16_t id = pugi::cast<uint16_t>(attr.value());

        auto res = vocationsMap.emplace(id, id);
        Vocation& voc = res.first->second;

        if ((attr = vocationNode.attribute("name"))) {
            voc.name = attr.as_string();
        }

        if ((attr = vocationNode.attribute("clientid"))) {
            voc.clientId = pugi::cast<uint16_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("effect"))) {
            voc.effect = pugi::cast<uint32_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("effectInterval"))) {
            voc.effectInterval = pugi::cast<uint32_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("description"))) {
            voc.description = attr.as_string();
        }

        if ((attr = vocationNode.attribute("gaincap"))) {
            voc.gainCap = pugi::cast<uint32_t>(attr.value()) * 100;
        }

        if ((attr = vocationNode.attribute("gainhp"))) {
            voc.gainHP = pugi::cast<uint32_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("gainmana"))) {
            voc.gainMana = pugi::cast<uint32_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("gainhpticks"))) {
            voc.gainHealthTicks = pugi::cast<uint32_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("gainhpamount"))) {
            voc.gainHealthAmount = pugi::cast<uint32_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("gainmanaticks"))) {
            voc.gainManaTicks = pugi::cast<uint32_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("gainmanaamount"))) {
            voc.gainManaAmount = pugi::cast<uint32_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("manamultiplier"))) {
            voc.manaMultiplier = pugi::cast<float>(attr.value());
        }

        if ((attr = vocationNode.attribute("attackspeed"))) {
            voc.attackSpeed = pugi::cast<uint32_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("basespeed"))) {
            voc.baseSpeed = pugi::cast<uint32_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("soulmax"))) {
            voc.soulMax = pugi::cast<uint16_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("gainsoulticks"))) {
            voc.gainSoulTicks = pugi::cast<uint16_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("kidamage"))) {
            voc.magicDamage = pugi::cast<uint16_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("fromvoc"))) {
            voc.fromVocation = pugi::cast<uint32_t>(attr.value());
        }

        for (auto childNode : vocationNode.children()) {
            if (strcasecmp(childNode.name(), "skill") == 0) {
                pugi::xml_attribute skillIdAttribute = childNode.attribute("id");
                if (skillIdAttribute) {
                    uint16_t skill_id = pugi::cast<uint16_t>(skillIdAttribute.value());
                    if (skill_id <= SKILL_LAST) {
                        voc.skillMultipliers[skill_id] = pugi::cast<float>(childNode.attribute("multiplier").value());
                    }
                    else {
                        std::cout << "[Notice - Vocations::loadFromXml] No valid skill id: " << skill_id << " for vocation: " << voc.id << std::endl;
                    }
                }
                else {
                    std::cout << "[Notice - Vocations::loadFromXml] Missing skill id for vocation: " << voc.id << std::endl;
                }
            }
            else if (strcasecmp(childNode.name(), "skills") == 0) {
                pugi::xml_attribute meleeDamageAttribute = childNode.attribute("meledamage");
                if (meleeDamageAttribute) {
                    voc.meleeDamageMultiplier = pugi::cast<float>(meleeDamageAttribute.value());
                }

                pugi::xml_attribute distDamageAttribute = childNode.attribute("distdamage");
                if (distDamageAttribute) {
                    voc.distDamageMultiplier = pugi::cast<float>(distDamageAttribute.value());
                }

                pugi::xml_attribute defenseAttribute = childNode.attribute("defense");
                if (defenseAttribute) {
                    voc.defenseMultiplier = pugi::cast<float>(defenseAttribute.value());
                }

                pugi::xml_attribute armorAttribute = childNode.attribute("armor");
                if (armorAttribute) {
                    voc.armorMultiplier = pugi::cast<float>(armorAttribute.value());
                }
            }
        }
    }
    return true;
}

Vocation* Vocations::getVocation(uint16_t id)
{
    auto it = vocationsMap.find(id);
    if (it == vocationsMap.end()) {
        std::cout << "[Warning - Vocations::getVocation] Vocation " << id << " not found." << std::endl;
        return nullptr;
    }
    return &it->second;
}

int32_t Vocations::getVocationId(const std::string& name) const
{
    for (const auto& it : vocationsMap) {
        if (strcasecmp(it.second.name.c_str(), name.c_str()) == 0) {
            return it.first;
        }
    }
    return -1;
}

uint16_t Vocations::getPromotedVocation(uint16_t vocationId) const
{
    for (const auto& it : vocationsMap) {
        if (it.second.fromVocation == vocationId && it.first != vocationId) {
            return it.first;
        }
    }
    return VOCATION_NONE;
}

uint32_t Vocation::skillBase[SKILL_LAST + 1] = { 50, 50, 50, 50, 30, 100, 20 };

Vocation::Vocation(uint16_t id)
    : name("none"), id(id)
{
    gainHealthTicks = 6;
    gainHealthAmount = 1;
    gainManaTicks = 6;
    gainManaAmount = 1;
    gainSoulTicks = 120;
    soulMax = 100;

    clientId = 0;
    fromVocation = VOCATION_NONE;

    gainCap = 500;
    gainMana = 5;
    magicDamage = 1;
    gainHP = 5;
    attackSpeed = 1500;
    baseSpeed = 220;
    manaMultiplier = 4.0;
    meleeDamageMultiplier = 1;
    distDamageMultiplier = 1;
    defenseMultiplier = 1;
    armorMultiplier = 1;
    skillMultipliers[0] = 1.5f;
    skillMultipliers[1] = 2.0f;
    skillMultipliers[2] = 2.0f;
    skillMultipliers[3] = 2.0f;
    skillMultipliers[4] = 2.0f;
    skillMultipliers[5] = 1.5f;
    skillMultipliers[6] = 1.1f;
}

uint64_t Vocation::getReqSkillTries(uint8_t skill, uint16_t level)
{
    if (skill > SKILL_LAST) {
        return 0;
    }

    auto it = cacheSkill[skill].find(level);
    if (it != cacheSkill[skill].end()) {
        return it->second;
    }

    uint64_t tries = static_cast<uint64_t>(skillBase[skill] * std::pow(static_cast<double>(skillMultipliers[skill]), level - 11));
    cacheSkill[skill][level] = tries;
    return tries;
}

uint64_t Vocation::getReqMana(uint32_t magLevel)
{
    auto it = cacheMana.find(magLevel);
    if (it != cacheMana.end()) {
        return it->second;
    }

    uint64_t reqMana = static_cast<uint64_t>(400 * std::pow<double>(manaMultiplier, static_cast<int32_t>(magLevel) - 1));
    uint32_t modResult = reqMana % 20;
    if (modResult < 10) {
        reqMana -= modResult;
    }
    else {
        reqMana -= modResult + 20;
    }

    cacheMana[magLevel] = reqMana;
    return reqMana;
}

make it look like this
XML: 
<vocation id="241" name="Ultimate Namekjin GT" description="a namekjin" gaincap="50" effect="14" effectInterval="1000" gainhp="250" gainmana="250" gainhpticks="6" gainhpamount="400" gainmanaticks="3" gainmanaamount="400" manamultiplier="1.1" attackspeed="200" soulmax="200" gainsoulticks="120" lostexp="3" lostmlv="3" lostskill="3" distdamage="150"  meledamage="250" kidamage="12" corpse="3046" charge="23">
<skill id="0" multiplier="3.0"/>
<skill id="1" multiplier="3.0"/>
<skill id="2" multiplier="3.0"/>
<skill id="3" multiplier="2.0"/>
<skill id="4" multiplier="1.1"/>
<skill id="5" multiplier="1.1"/>
<skill id="6" multiplier="1.1"/>
</vocation>

not like that
XML: 
<vocation id="241" name="Ultimate Namekjin GT" description="a namekjin" gaincap="50" effect="14" effectInterval="1000" gainhp="250" gainmana="250" gainhpticks="6" gainhpamount="400" gainmanaticks="3" gainmanaamount="400" manamultiplier="1.1" attackspeed="200" soulmax="200" gainsoulticks="120" lostexp="3" lostmlv="3" lostskill="3"> 
<skills distdamage="150"  meledamage="250" kidamage="12" corpse="3046" charge="23"/>
<skill id="0" multiplier="3.0"/>
<skill id="1" multiplier="3.0"/>
<skill id="2" multiplier="3.0"/>
<skill id="3" multiplier="2.0"/>
<skill id="4" multiplier="1.1"/>
<skill id="5" multiplier="1.1"/>
<skill id="6" multiplier="1.1"/>
</vocation>

ps. I know that my English sucks
 
Sort by date Sort by votes
I would like to delete or modify this part of the code.
That all attribute be in one form

C++: 
for (auto childNode : vocationNode.children()) {
            if (strcasecmp(childNode.name(), "skill") == 0) {
                pugi::xml_attribute skillIdAttribute = childNode.attribute("id");
                if (skillIdAttribute) {
                    uint16_t skill_id = pugi::cast<uint16_t>(skillIdAttribute.value());
                    if (skill_id <= SKILL_LAST) {
                        voc.skillMultipliers[skill_id] = pugi::cast<float>(childNode.attribute("multiplier").value());
                    } else {
                        std::cout << "[Notice - Vocations::loadFromXml] No valid skill id: " << skill_id << " for vocation: " << voc.id << std::endl;
                    }
                } else {
                    std::cout << "[Notice - Vocations::loadFromXml] Missing skill id for vocation: " << voc.id << std::endl;
                }
            } else if (strcasecmp(childNode.name(), "formula") == 0) {
                pugi::xml_attribute meleeDamageAttribute = childNode.attribute("meleeDamage");
                if (meleeDamageAttribute) {
                    voc.meleeDamageMultiplier = pugi::cast<float>(meleeDamageAttribute.value());
                }

                pugi::xml_attribute distDamageAttribute = childNode.attribute("distDamage");
                if (distDamageAttribute) {
                    voc.distDamageMultiplier = pugi::cast<float>(distDamageAttribute.value());
                }

                pugi::xml_attribute defenseAttribute = childNode.attribute("defense");
                if (defenseAttribute) {
                    voc.defenseMultiplier = pugi::cast<float>(defenseAttribute.value());
                }

                pugi::xml_attribute armorAttribute = childNode.attribute("armor");
                if (armorAttribute) {
                    voc.armorMultiplier = pugi::cast<float>(armorAttribute.value());
                }
            }
        }
    }
    return true;
}
 
Upvote 0 Downvote

Similar threads

Murilo35
  • Solved
C++ TFS 1.0 - v8.6 Remove Player Respawn Block
Replies
2
Views
319
Murilo35
Murilo35
Piifafa
  • Solved
TFS 1.X+ Help, protocolstatus.cpp
Replies
2
Views
428
Piifafa
Piifafa
alejandro762
  • Question
Solved SkillsTries and cap Level Skill Fist
Replies
1
Views
506
NvSo
NvSo
R
  • Locked
  • Question
[TFS] 1.5 Source edit to prevent skill lose when player dies (SOLVED)
Replies
3
Views
587
Redz
R
johnsamir
  • Question
TFS 1.X+ [TFS-1.4 - 8.6]Cast system screen problem
Replies
5
Views
326
johnsamir
johnsamir
Mateus Robeerto
  • Solved
I ask for help to fix the bug that causes the server to crash after adding code in the source
Replies
9
Views
837
lursky
L
Back
Top