Solved Wall lever with reset timer issues on 1.1

[Caduceus]

I am trying to remove wall with lever & on timer reset, create walls back on tfs 1.1. My timer is resetting my lever, but not removing my walls. What am I doing wrong?

local wallPos = {
           [1] = {x=1012, y=782, z=10, stackpos=1},
           [2] = {x=1012, y=781, z=10, stackpos=1},
           [3] = {x=1019, y=776, z=10, stackpos=1},
           [4] = {x=1020, y=776, z=10, stackpos=1}
        }

        local time_ = 10 -- seconds

        function onUse(player, item, fromPosition, target, toPosition, isHotkey)
            local function reset()
                -- reset switch
                item:transform(1945)
                -- reset walls
                    Game.createItem(9118, 1, wallPos[1])
                    Game.createItem(9118, 1, wallPos[2])
                    Game.createItem(9119, 1, wallPos[3])
                    Game.createItem(9119, 1, wallPos[4])                  
                end

           -- check if lever is currently used
           if item.itemid == 1946 then
             player:sendTextMessage(MESSAGE_INFO_DESCR, "Switch is already active.")
             return false
           end
     
           -- transform lever, and add reset
           item:transform(1946)
           addEvent(reset, time_ * 1000)
     
           -- remove walls, send message
                   doRemoveItem(wallPos[1].uid,1)
                   doRemoveItem(wallPos[2].uid,1)
                   doRemoveItem(wallPos[3].uid,1)
                   doRemoveItem(wallPos[4].uid,1)
           player:sendTextMessage(MESSAGE_INFO_DESCR, "Reward Chamber is now open!")
           return true
        end

 

[Codex NG]

wallPos the table its index is a location but not an item

        local wallPos = {
            [1] = {x=1012, y=782, z=10, stackpos=1},
            [2] = {x=1012, y=781, z=10, stackpos=1},
            [3] = {x=1019, y=776, z=10, stackpos=1},
            [4] = {x=1020, y=776, z=10, stackpos=1}
        }

        local time_ = 10 -- seconds

        function onUse(player, item, fromPosition, target, toPosition, isHotkey)
            local function reset()
                -- reset switch
            item:transform(1945)
                -- reset walls
                    Game.createItem(9118, 1, wallPos[1])
                    Game.createItem(9118, 1, wallPos[2])
                    Game.createItem(9119, 1, wallPos[3])
                    Game.createItem(9119, 1, wallPos[4])                 
                end

           -- check if lever is currently used
            if item.itemid == 1946 then
                player:sendTextMessage(MESSAGE_INFO_DESCR, "Switch is already active.")
                return false
            end
    
            -- transform lever, and add reset
            item:transform(1946)
            addEvent(reset, time_ * 1000)
    
            -- remove walls, send message
            for i = 1, #wallPos do
                doRemoveItem(getThingfromPos(wallPos[i]).uid,1)
            end
           
            player:sendTextMessage(MESSAGE_INFO_DESCR, "Reward Chamber is now open!")
            return true
        end

 

[Caduceus]

So it's not defining the item?

 

[Codex NG]

So it's not defining the item?

You can't slap on a property to a position, uid is a property of a item so is itemid, you need to tell the server to get the item from that position then you can request the uid.
I already altered your code in the thread above.

 

[Caduceus]

Thank you, I'm just trying to understand the code. I am extremely new to this format. Which I'm sure is flamingly obvious. It still doesn't remove the wall from the pos.

 

[Codex NG]

Thank you, I'm just trying to understand the code. I am extremely new to this format. Which I'm sure is flamingly obvious. It still doesn't remove the wall from the pos.

reload your server, like completely shut it down, then try the script again, remove the 1 from
doRemoveItem(getThingfromPos(wallPos).uid)

 

[Codex NG]

Explanation is in the code

        local wallPos = {
            [1] = {x=1012, y=782, z=10, stackpos=1},
            [2] = {x=1012, y=781, z=10, stackpos=1},
            [3] = {x=1019, y=776, z=10, stackpos=1},
            [4] = {x=1020, y=776, z=10, stackpos=1}
        }

        local time_ = 10 -- seconds

        function onUse(player, item, fromPosition, target, toPosition, isHotkey)
            local function reset()
                -- reset switch
            item:transform(1945)
                -- reset walls
                    Game.createItem(9118, 1, wallPos[1])
                    Game.createItem(9118, 1, wallPos[2])
                    Game.createItem(9119, 1, wallPos[3])
                    Game.createItem(9119, 1, wallPos[4])               
                end

           -- check if lever is currently used
            if item.itemid == 1946 then
                player:sendTextMessage(MESSAGE_INFO_DESCR, "Switch is already active.")
                return false
            end
  
            -- transform lever, and add reset
            item:transform(1946)
            addEvent(reset, time_ * 1000)
  
            -- remove walls, send message
            --[[
                1st getThingfromPos is called and passed a wallPos at the index of i, the item is return and then we ask for
                one of it's properties in this case its uid, we then pass that to doRemoveItem, which removes the item
            ]]
            for i = 1, #wallPos do
                doRemoveItem(getThingfromPos(wallPos[i]).uid)
            end
         
            player:sendTextMessage(MESSAGE_INFO_DESCR, "Reward Chamber is now open!")
            return true
        end

 

[Caduceus]

Thanks, It worked. I'm trying to understand. Your explanations are superb.

 

[demon088]

Explanation is in the code

        local wallPos = {
            [1] = {x=1012, y=782, z=10, stackpos=1},
            [2] = {x=1012, y=781, z=10, stackpos=1},
            [3] = {x=1019, y=776, z=10, stackpos=1},
            [4] = {x=1020, y=776, z=10, stackpos=1}
        }

        local time_ = 10 -- seconds

        function onUse(player, item, fromPosition, target, toPosition, isHotkey)
            local function reset()
                -- reset switch
            item:transform(1945)
                -- reset walls
                    Game.createItem(9118, 1, wallPos[1])
                    Game.createItem(9118, 1, wallPos[2])
                    Game.createItem(9119, 1, wallPos[3])
                    Game.createItem(9119, 1, wallPos[4])              
                end

           -- check if lever is currently used
            if item.itemid == 1946 then
                player:sendTextMessage(MESSAGE_INFO_DESCR, "Switch is already active.")
                return false
            end
 
            -- transform lever, and add reset
            item:transform(1946)
            addEvent(reset, time_ * 1000)
 
            -- remove walls, send message
            --[[
                1st getThingfromPos is called and passed a wallPos at the index of i, the item is return and then we ask for
                one of it's properties in this case its uid, we then pass that to doRemoveItem, which removes the item
            ]]
            for i = 1, #wallPos do
                doRemoveItem(getThingfromPos(wallPos[i]).uid)
            end
        
            player:sendTextMessage(MESSAGE_INFO_DESCR, "Reward Chamber is now open!")
            return true
        end

It removes every item on the position, even the tiles. The wall is removed but without that tile you can't walk through.

 

[Caduceus]

It removes every item on the position, even the tiles. The wall is removed but without that tile you can't walk through.

check your stackpos