Lua Wand damage half to players

[kablaff]

How to make a wand damage half to players, but normal damage to monsters??
Here's what I've done so far:

local combat = createCombatObject()
setCombatParam(combat, COMBAT_PARAM_TYPE, COMBAT_HOLYDAMAGE)
setCombatParam(combat, COMBAT_PARAM_DISTANCEEFFECT, 28)

function onGetFormulaValues(cid, level, skill, attack, element, factor)
	local minDamage = math.random(150, 250)
	return minDamage
end

setCombatCallback(combat, CALLBACK_PARAM_SKILLVALUE, "onGetFormulaValues")

function onUseWeapon(cid, var)
	local ret = doCombat(cid, combat, var)
	
	return ret
end

 

[WarOfTheTitans]

local combat = createCombatObject()
setCombatParam(combat, COMBAT_PARAM_TYPE, COMBAT_HOLYDAMAGE)
setCombatParam(combat, COMBAT_PARAM_DISTANCEEFFECT, 28)
function onGetFormulaValues(cid, level, skill, attack, element, factor)
	local minDamage = math.random(150, 250)
	return minDamage
end
setCombatCallback(combat, CALLBACK_PARAM_SKILLVALUE, "onGetFormulaValues")

function onUseWeapon(cid, var)
	local target = getCreatureTarget(cid)
	if(isMonster(target)) then
		doCombat(cid, combat, var)
	else
		doSendDistanceShoot(getCreaturePosition(cid), getCreaturePosition(target), 28)
		doTargetCombatHealth(cid, target, COMBAT_HOLYDAMAGE, getCreatureMaxHealth(target)/100*50, getCreatureMaxHealth(target)/100*50, CONST_ME_HOLYAREA)
	end
	
	return true
end

 

[kablaff]

doesna work.

 

[WarOfTheTitans]

Any error?

 

[kablaff]

Nop, but no damage on monsters..
Hmm could the demon be immune against it ?

 

[WarOfTheTitans]

Hm.. Does it hit on players then?

 

[kablaff]

Hmm I have mindamage="0" and maxdamage"0" in weapons.xml, does it matter, should I remove it??

 

[WarOfTheTitans]

Ye remove that:

local combat = createCombatObject()
setCombatParam(combat, COMBAT_PARAM_TYPE, COMBAT_HOLYDAMAGE)
setCombatParam(combat, COMBAT_PARAM_DISTANCEEFFECT, 28)
function onGetFormulaValues(cid, level, skill, attack, element, factor)
	local minDamage = math.random(150, 250)
	return minDamage
end
setCombatCallback(combat, CALLBACK_PARAM_SKILLVALUE, "onGetFormulaValues")
 
function onUseWeapon(cid, var)
	local target = getCreatureTarget(cid)
	if(isPlayer(target)) then
		doSendDistanceShoot(getCreaturePosition(cid), getCreaturePosition(target), 28)
		doTargetCombatHealth(cid, target, COMBAT_HOLYDAMAGE, getCreatureMaxHealth(target)/100*50, getCreatureMaxHealth(target)/100*50, CONST_ME_HOLYAREA)
	else
		doCombat(cid, combat, var)
	end
 
	return true
end