TFS 1.X+ Weapon and Defense system

[CastorFlynn]

I noticed that using a one handed weapon + shield it ignores the weapon's defense, is this normal? If weapon have extradef this count, but normal def not.

 

[Przemyslaw1101]

Yes it's normal. By default def consider only higher value of weapon or shield.

 

[Glaszcz Koldre]

weapon + shield = only shield deff counts and shielding skill
Only weapon either 1 or 2 handed = weapon deff counts and melee skill.

For example 30 deff shield and 100 shielding is the same as 30 deff from weapon and 100 melee skill.

 

[chucky91]

I verified that if you use a two-handed weapon with defense, like enchanted staff that has 45 defense, don't defend anything.
Because I've been watching some tibia videos old time, and that a player could defend the attack even with low weapon defense, and it wasn't block armor. so i made some changes in player.cpp
And now work weapon+shield or only weapon or shield.

if (weapon) {
        totalDefense = weapon->getDefense() + 1;

        switch (weapon->getWeaponType()) {
            case WEAPON_AXE:
                defenseSkill = getSkillLevel(SKILL_SHIELD);
                break;
            case WEAPON_SWORD:
                defenseSkill = getSkillLevel(SKILL_SHIELD);
                break;
            case WEAPON_CLUB:
                defenseSkill = getSkillLevel(SKILL_SHIELD);
                break;
            case WEAPON_DISTANCE:
            case WEAPON_AMMO:
                defenseSkill = getSkillLevel(SKILL_SHIELD);
                break;
            default:
                break;
        }
    }

 

[chucky91]

The previous behavior was supposed to be with getSkillLevel()

if (weapon) {
        totalDefense = weapon->getDefense() + 1;

        switch (weapon->getWeaponType()) {
            case WEAPON_AXE:
                defenseSkill = getSkillLevel(SKILL_AXE);
                break;
            case WEAPON_SWORD:
                defenseSkill = getSkillLevel(SKILL_SWORD);
                break;
            case WEAPON_CLUB:
                defenseSkill = getSkillLevel(SKILL_CLUB);
                break;
            case WEAPON_DISTANCE:
            case WEAPON_AMMO:
                defenseSkill = getSkillLevel(SKILL_SHIELD);
                break;
            default:
                break;
        }
    }

 

[Felipe93]

The previous behavior was supposed to be with getSkillLevel()

if (weapon) {
        totalDefense = weapon->getDefense() + 1;

        switch (weapon->getWeaponType()) {
            case WEAPON_AXE:
                defenseSkill = getSkillLevel(SKILL_AXE);
                break;
            case WEAPON_SWORD:
                defenseSkill = getSkillLevel(SKILL_SWORD);
                break;
            case WEAPON_CLUB:
                defenseSkill = getSkillLevel(SKILL_CLUB);
                break;
            case WEAPON_DISTANCE:
            case WEAPON_AMMO:
                defenseSkill = getSkillLevel(SKILL_SHIELD);
                break;
            default:
                break;
        }
    }

Where should the code be placed?

 

[chucky91]

Where should the code be placed?

player.cpp

 

[Felipe93]

player.cpp

thank you a lot !

 

[marcelomnzs]

@chucky91 look your pm