What is here wrong ? And how to change max hp with function movements.

[darex11]

Hello in this function is bug. I don't know where...

...just kills you.
I very need this functions to change max hp and mana at weapon equip.

luascript.cpp

	//doCreatureChangeMaxHealth(cid, newHealth)
	lua_register(m_luaState, "doCreatureChangeMaxHealth", LuaScriptInterface::luaDoCreatureChangeMaxHealth);

int32_t LuaScriptInterface::luaDoCreatureChangeMaxHealth(lua_State* L)
{
	//doCreatureChangeMaxHealth(uid,newHealth)
	int32_t healthChange = (int32_t)popNumber(L);
	uint32_t cid = popNumber(L);
	ScriptEnviroment* env = getScriptEnv();
	Creature* creature = env->getCreatureByUID(cid);
	if(creature)
	{
 	    creature->changeMaxHealth(healthChange);
		lua_pushnumber(L, LUA_NO_ERROR);
	}
	else
	{
		reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND));
		lua_pushnumber(L, LUA_ERROR);
	}
	return 1;
}

luascript.h

        static int32_t luaDoCreatureChangeMaxHealth(lua_State* L);

creature.cpp

void Creature::changeMaxHealth(int32_t healthChange)
{
   
    healthMax = (int32_t)healthChange;

	g_game.addCreatureHealth(this);
}

creature.h

        virtual void changeMaxHealth(int32_t healthChange);

When using this script, as I said, it kills you and when you relog, you login with 0 HP so you die again and when you login the second time you don't die.

And in movements I make function:

function onEquip(cid, item)
    doCreatureChangeMaxHealth(cid, (getMaxHealth+50))
	return TRUE
end

and

function onDeEquip(cid, item)
    doCreatureChangeMaxHealth(cid, (getMaxHealth-50))
	return TRUE
end

And don't works. Any help ?

 

[slaw]

not

getMaxHealth

but

getCreatureMaxHealth(cid)