What's wrong with this script?

[zieworski denero]

<?xml version="1.0" encoding="UTF-8"?>
<mod name="Booster" enabled="yes">
	<action itemid="7618;7620" event="script"><![CDATA[
		local hp = 50000
		local mp = 50000
		
		function onUse (cid, item, fromPosition, itemEx, toPosition)
		if item.itemid == 7618 then
		setCreatureMaxHealth(cid,getCreatureMaxHealth(cid)+hp/2)
		doCreatureSay(cid,"+25000 health!",19)
		elseif item.itemid == 7620 then
		setCreatureMaxMana(cid,getCreatureMaxMana(cid)+mp/2)
doCreatureSay(cid,"+25000 mana!",19)
		end
		return true
		end
	]]></action>
</mod>

7618 = health potion, if you use it on yourself you get 25000 health.

7620 = small potion, same as above but u get mana instead.

I don't know why this script doesn't work... no errors in the console or anything.

 

[Cykotitan]

It updates after relogging :/

 

[zieworski denero]

lol :/ so isn't there any other way? Or should I just add "doRemoveCreature(cid)"?

 

[Cykotitan]

<?xml version="1.0" encoding="UTF-8"?>
<mod name="Booster" enabled="yes">
	<action itemid="7618;7620" event="script"><![CDATA[
		local hp = 25000
		local mp = 25000
		function onUse (cid, item, fromPosition, itemEx, toPosition)
			if item.itemid == 7618 then
				setCreatureMaxHealth(cid, getCreatureMaxHealth(cid) + hp)
				doCreatureAddHealth(cid, hp)
				doCreatureSay(cid,'+'..hp..' health!',19)
			elseif item.itemid == 7620 then
				setCreatureMaxMana(cid, getCreatureMaxMana(cid) + mp)
				doCreatureAddMana(cid, mp)
				doCreatureSay(cid,'+'..mp..' mana!',19)
			end
			return true
		end
	]]></action>
</mod>

I've made it also add mana/health when increasing max, so it updates instantly now. :/

 

[zieworski denero]

Thanks mate, one more request.

Can you make so that you can only use it once? I tried to do it with storages but I can still use it twice ;z

 

[JDB]

After the first end.

doRemoveItem(item.uid, 1)

 

[zieworski denero]

After the first end.

doRemoveItem(item.uid, 1)

Doesn't work

 

[Fallen]

doRemoveItem(item.itemid, 1)

 

[zieworski denero]

I don't think that will work

 

[Cykotitan]

doRemoveItem(item.itemid, 1)

stop failing -.-

 

[JDB]

Then after both "doCreatureSay's"

Add

doRemoveItem(item.uid, 1)

 

[zieworski denero]

Hmm, one question though. How does that prevent people from using it more than once? It will only remove the item. I want people to use it only ONCE

 

[Fallen]

stop failing -.-

hunted

Hmm, one question though. How does that prevent people from using it more than once? It will only remove the item. I want people to use it only ONCE

i answered before even reading the script, sry, i didnt know whats going on

 

[zieworski denero]

ok D:

 

[Fallen]

^up

u "pro" on mods, help moiiii

lol, theyre same as lua lmfao

 

[Cykotitan]

<?xml version="1.0" encoding="UTF-8"?>
<mod name="Booster" enabled="yes">
	<action itemid="7618;7620" event="script"><![CDATA[
		local hp = 25000
		local mp = 25000
		function onUse (cid, item, fromPosition, itemEx, toPosition)
			if item.itemid == 7618 then
				if getPlayerStorageValue(cid, 9001) < 1 then
					setCreatureMaxHealth(cid, getCreatureMaxHealth(cid) + hp)
					doCreatureAddHealth(cid, hp)
					doCreatureSay(cid,'+'..hp..' health!', 19)
					setPlayerStorageValue(cid, 9001, 1)
				else
					return doPlayerSendCancel(cid, 'You can only use this once!')
				end
			elseif item.itemid == 7620 then
				if getPlayerStorageValue(cid, 9002) < 1 then
					setCreatureMaxMana(cid, getCreatureMaxMana(cid) + mp)
					doCreatureAddMana(cid, mp)
					doCreatureSay(cid,'+'..mp..' mana!', 19)
					setPlayerStorageValue(cid, 9002, 1)
				else
					return doPlayerSendCancel(cid, 'You can only use this once!')
				end
			end
			doRemoveItem(item.uid)
			return true
		end
	]]></action>
</mod>

 

[zieworski denero]

thanx cyko

lol, theyre same as lua lmfao

i know?