C++ You lose x mana blocking an attack by (null).

[115820]

In my server when player use UTAMO VITA, description attack :

• You lose x mana blocking an attack by (null).

dont show player name attacker.

 

[Marcus]

1: What server
2: What version

1 + 2 = faster help

 

[115820]

1: What server
2: What version

1 + 2 = faster help

Version 0.4, i use that sources 8.60 / Tfs 0.4 ( BROKEN 2B HP AND MP LIMIT same for Monsters ) OFFICAL RELEASE
Server is my own.

 

[ralke]

I misunderstood this sorry

 

[Infernum]

Version 0.4, i use that sources 8.60 / Tfs 0.4 ( BROKEN 2B HP AND MP LIMIT same for Monsters ) OFFICAL RELEASE
Server is my own.

you downloaded a broken source lol

 

[115820]

Yeah, but when i lose HP, show You lose X hitpoits ... by PLAYERNAME, not (null).

 

[Hashirama479]

you downloaded a broken source lol

Why broken?

About the problem I had the problem befor too but I think ( unsure ) it was something in datapack xD

 

[Infernum]

Why broken?

About the problem I had the problem befor too but I think ( unsure ) it was something in datapack xD

that damage string is handled in the source in combat.cpp
the source is broken because not everything was converted to uint64_t/int64_t, thats why people are having problems with that source that he linked

 

[115820]

But the error is only in mana. When I attack to take life, it appears normally.
If I change the uint64_t / int64_t mana, can I fix this error?

 

[Infernum]

But the error is only in mana. When I attack to take life, it appears normally.
If I change the uint64_t / int64_t mana, can I fix this error?

i wasnt saying the problem is the mana values
its just an example of how the source you downloaded is broken
the damage string should be somewhere in combat.cpp

 

[115820]

i wasnt saying the problem is the mana values
its just an example of how the source you downloaded is broken
the damage string should be somewhere in combat.cpp

Uhm. I dont know how to FIX. AFFF

 

[Infernum]

post the function at line 1791 in player.cpp
should look like this

void Player::drainMana(Creature* attacker, CombatType_t combatType, int64_t damage)
{
    Creature::drainMana(attacker, combatType, damage);
    char buffer[150];
    if(attacker)
        sprintf(buffer, "You lose %d mana blocking an attack by %s.", damage, attacker->getNameDescription().c_str());
    else
        sprintf(buffer, "You lose %d mana.", damage);

    sendStats();
    sendTextMessage(MSG_EVENT_DEFAULT, buffer);
}

 

[115820]

void Player::drainMana(Creature* attacker, CombatType_t combatType, int64_t damage)
{
    Creature::drainMana(attacker, combatType, damage);
    char buffer[150];
    if(attacker)
        sprintf(buffer, "You lose %d mana blocking an attack by %s.", damage, attacker->getNameDescription().c_str());
    else
        sprintf(buffer, "You lose %d mana.", damage);

    sendStats();
    sendTextMessage(MSG_EVENT_DEFAULT, buffer);
}

 

[Infernum]

is the attacker always (null)? even if you get hit by another player
attacker->getNameDescription().c_str() must return NULL for some reason
is this in your creature.h

virtual const std::string& getNameDescription() const = 0;

 

[115820]

virtual const std::string& getName() const = 0;
        virtual const std::string& getNameDescription() const = 0;
        virtual std::string getDescription(int32_t lookDistance) const;