- Joined
- Sep 7, 2015
- Messages
- 2,686
- Solutions
- 127
- Reaction score
- 2,134
Are we talking about empty talk or want to change anything this time? It's great that you have ideas, but we are seeing similar threads dozen of times and yet nothing changes.
Having config options for everything is just delusional, if you aren't a developer you got no perspective of how hard this is actually to do and how messy the code gets.
As long as you are not getting administration (code owners on github) into the topic, you can only fork or create new forgottenserver and start working on it.
I would advise anyone that want a change to just start their fork and actually try to keep it alive and maintain it, because all I see is the talk about how bad tfs is maintainted and how dead it is, just try to maintain a similar project yourself and keep it decent quality.
Funny enough most of the people that are commenting on the state of tfs never donated a line of code.
If anyone care about my opinion here it is:
I don't think the move to higher protocol was a good thing, while just bumping it up to certain client and keeping it there is okay. I wouldn't bother with implementing anything other than protocol to just support this version. TFS has lots of "design" flaws or just in general bad/old code.
Manual reference counting, raw pointers being problematic in some places (causing undefined behaviour), hidden crashes (ex dropping spear on ground while getting kicked out), memory leaks in (bad) npc system, poor/missing logging system, bad monster AI, optional helpful features like metrics support, there is lots to do just in the core to keep the code more "modern".
I view tfs as the "skeleton" to do your thing on, it should be the working base with minimal features, stable and working, no cip features, because they are useless if you don't need them or if you need them spin off a second repository or special branch for all the cip features (I don't think there is enough contributors).
Personally I did not fork the repo once since the transition to client 12.x. I just can't bother to find a proper client and spin up a login server just to login to tfs.
Also moving to newer protocol without even having tools to edit the new appearances sounds stupid.
Having config options for everything is just delusional, if you aren't a developer you got no perspective of how hard this is actually to do and how messy the code gets.
As long as you are not getting administration (code owners on github) into the topic, you can only fork or create new forgottenserver and start working on it.
I would advise anyone that want a change to just start their fork and actually try to keep it alive and maintain it, because all I see is the talk about how bad tfs is maintainted and how dead it is, just try to maintain a similar project yourself and keep it decent quality.
Funny enough most of the people that are commenting on the state of tfs never donated a line of code.
If anyone care about my opinion here it is:
I don't think the move to higher protocol was a good thing, while just bumping it up to certain client and keeping it there is okay. I wouldn't bother with implementing anything other than protocol to just support this version. TFS has lots of "design" flaws or just in general bad/old code.
Manual reference counting, raw pointers being problematic in some places (causing undefined behaviour), hidden crashes (ex dropping spear on ground while getting kicked out), memory leaks in (bad) npc system, poor/missing logging system, bad monster AI, optional helpful features like metrics support, there is lots to do just in the core to keep the code more "modern".
I view tfs as the "skeleton" to do your thing on, it should be the working base with minimal features, stable and working, no cip features, because they are useless if you don't need them or if you need them spin off a second repository or special branch for all the cip features (I don't think there is enough contributors).
Personally I did not fork the repo once since the transition to client 12.x. I just can't bother to find a proper client and spin up a login server just to login to tfs.
Also moving to newer protocol without even having tools to edit the new appearances sounds stupid.