[Avesta] Help with script

Veterana · Apr 19, 2013

Can someone help me with this promotion script?

I want it to check if the player is allready promoted and if he is, it should not promote him.
Also, if the player has "No Vocation" it should not promote him.

It should also check if the player is level 20 or higher.

Someone got the skills to add this into the script? Thank you!

--- Written by X_anero
function onUse(cid, item, frompos, item2, topos)
if item.itemid == 2279 then
local playerpos = getCreaturePosition(cid)
doRemoveItem(item.uid,2279)
doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
doSendMagicEffect(playerpos, 12)
doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
end
end

StreamSide · Apr 19, 2013

LUA:

function onUse(cid, item, frompos, item2, topos)
	if item.itemid == 2279 and isInArray({1, 2, 3, 4}, getPlayerVocation(cid)) and getPlayerLevel(cid) => 20 then
		local playerpos = getCreaturePosition(cid)
		doRemoveItem(item.uid, 2279)
		doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
	end
	doPlayerSendTextMessage(cid,22,"Sorry, not possible.")
end

Veterana · Apr 19, 2013

StreamSide said:

LUA:

function onUse(cid, item, frompos, item2, topos)
	if item.itemid == 2279 and isInArray({1, 2, 3, 4}, getPlayerVocation(cid)) and getPlayerLevel(cid) => 20 then
		local playerpos = getCreaturePosition(cid)
		doRemoveItem(item.uid, 2279)
		doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
	end
	doPlayerSendTextMessage(cid,22,"Sorry, not possible.")
end

Not working.

Now the item is not working at all.

Colors · Apr 19, 2013

I never tried Avesta, but why don't use doPlayerSetPromotionLevel(cid, 1) instead of doPlayerSetVocation(cid, getPlayerVocation(cid)+4)?

ond · Apr 19, 2013

StreamSide said:

LUA:

function onUse(cid, item, frompos, item2, topos)
	if item.itemid == 2279 and isInArray({1, 2, 3, 4}, getPlayerVocation(cid)) and getPlayerLevel(cid) => 20 then
		local playerpos = getCreaturePosition(cid)
		doRemoveItem(item.uid, 2279)
		doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
	end
	doPlayerSendTextMessage(cid,22,"Sorry, not possible.")
end

Change getCreaturePosition(cid) to getPlayerPosition(cid) and it will work

Colors · Apr 19, 2013

LUA:

local noVoc = {0}

function onUse(cid, item, frompos, item2, topos)
	if item.itemid == 2279 and not isInArray(noVoc, getPlayerVocation(cid)) and getPlayerLevel(cid) >= 20 then
		local playerpos = getCreaturePosition(cid)
		doRemoveItem(item.uid, 2279)
		--doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
		doPlayerSetPromotionLevel(cid, 1)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid, 22, "You just got Promoted!.")
	else
		doPlayerSendTextMessage(cid, 22, "Sorry, not possible.")
	end
	return TRUE
end

That should work

ond · Apr 19, 2013

Cthugha said:
That should work

It will not

Colors · Apr 19, 2013

ond said:
It will not

And that's because...?

Veterana · Apr 19, 2013

ond said:
Change getCreaturePosition(cid) to getPlayerPosition(cid) and it will work

Still doesnt work.

- - - Updated - - -

Cthugha said:

LUA:

local noVoc = {0}

function onUse(cid, item, frompos, item2, topos)
	if item.itemid == 2279 and not isInArray(noVoc, getPlayerVocation(cid)) and getPlayerLevel(cid) >= 20 then
		local playerpos = getCreaturePosition(cid)
		doRemoveItem(item.uid, 2279)
		--doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
		doPlayerSetPromotionLevel(cid, 1)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid, 22, "You just got Promoted!.")
	else
		doPlayerSendTextMessage(cid, 22, "Sorry, not possible.")
	end
	return TRUE
end

That should work

Now it is just saying "Sorry, not possible." in green text.

Calon · Apr 19, 2013

make sure that you got in action.xml

LUA:

<action itemid="2279" event="script" value="xxxx.lua"/>

LUA:

function onUse(cid, item, frompos, item2, topos)
                               local playerpos = getCreatureByName(cid)
	if  getPlayerLevel(cid) => 20 and getPlayerVocation(cid) == 0 then 
		doRemoveItem(item.uid, 1)
		doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
	end
	doPlayerSendTextMessage(cid,22,"Sorry, not possible.")
end

Veterana · Apr 19, 2013

Chriso said:

make sure that you got in action.xml

LUA:

<action itemid="2279" event="script" value="xxxx.lua"/>

LUA:

function onUse(cid, item, frompos, item2, topos)
                               local playerpos = getCreatureByName(cid)
	if  getPlayerLevel(cid) => 20 and getPlayerVocation(cid) == 0 then 
		doRemoveItem(item.uid, 1)
		doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
	end
	doPlayerSendTextMessage(cid,22,"Sorry, not possible.")
end

Not working!

Calon · Apr 19, 2013

Are you sure that your vocation is 0 ?

try this

LUA:

function onUse(cid, item, frompos, item2, topos)
                               local playerpos = getCreatureByName(cid)
	if  getPlayerLevel(cid) >= 20 and getPlayerVocation(cid) == 0 then 
		doRemoveItem(item.uid, 1)
		doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
	end
	doPlayerSendTextMessage(cid,22,"Sorry, not possible.")
end

Colors · Apr 19, 2013

Veterana said:
Now it is just saying "Sorry, not possible." in green text.

Are you sure that you have the right vocation(s) and the level?

Chriso said:
LUA:

if getPlayerLevel(cid) => 20 and getPlayerVocation(cid) == 0 then

You are doing right the thing that he DON'T want to

Calon · Apr 19, 2013

Cthugha said:
Are you sure that you have the right vocation(s) and the level?

You are doing right the thing that he DON'T want to

oh aright sorry.. then mmm

LUA:

function onUse(cid, item, frompos, item2, topos)
                               local playerpos = getCreatureByName(cid)
        if  getPlayerVocation(cid) == 0 or getPlayerStorageValue (cid, 3333) == 1 then
             doPlayerSendTextMessage(cid,22,"You have no vocation or already promoted!")
return true
end
	if  getPlayerLevel(cid) >= 20 then
		doRemoveItem(item.uid, 1)
		doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
                setPlayerStorageValue(cid, 3333, 1)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
else
	doPlayerSendTextMessage(cid,22,"Sorry, not possible.")
end
return true
end

Veterana · Apr 19, 2013

Chriso said:

oh aright sorry.. then mmm

LUA:

function onUse(cid, item, frompos, item2, topos)
                               local playerpos = getCreatureByName(cid)
        if  getPlayerVocation(cid) == 0 or getPlayerVocation(cid) == 1 or  getPlayerVocation(cid) == 2 or  getPlayerVocation(cid) == 3 or  getPlayerVocation(cid) == 4 then
return true
end
	if  getPlayerLevel(cid) >= 20 then
		doRemoveItem(item.uid, 1)
		doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
	end
	doPlayerSendTextMessage(cid,22,"Sorry, not possible.")
return true
end

Nothing is happening when i click the item.
Not working at all.

Calon · Apr 19, 2013

Well lets try a global value

LUA:

function onUse(cid, item, frompos, item2, topos)
                               local playerpos = getCreatureByName(cid)
        if  getPlayerVocation(cid) == 0 or getPlayerStorageValue(cid, 3333) == 1 then
             doPlayerSendTextMessage(cid,22,"You have no vocation or already promoted!")
return true
end
	if  getPlayerLevel(cid) >= 20 then
		doRemoveItem(item.uid, 1)
		doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
                setPlayerStorageValue(cid, 3333, 1)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
 else
	doPlayerSendTextMessage(cid,22,"Sorry, not possible.")
	end
return true
end

Veterana · Apr 19, 2013

Chriso said:

Well lets try a global value

LUA:

function onUse(cid, item, frompos, item2, topos)
                               local playerpos = getCreatureByName(cid)
        if  getPlayerVocation(cid) == 0 or getPlayerStorageValue (cid, 3333) == 1 then
             doPlayerSendTextMessage(cid,22,"You have no vocation or already promoted!")
return true
end
	if  getPlayerLevel(cid) >= 20 then
		doRemoveItem(item.uid, 1)
		doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
                setPlayerStorageValue(cid, 3333, 1)
		doSendMagicEffect(playerpos, 12)
		doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
 else
	doPlayerSendTextMessage(cid,22,"Sorry, not possible.")
	end
return true
end

Not working either.
The item ID is 5545 by the way!

This script adds vocation up, but doesnt check if the player is allready promoted or non vocation or level 20:

--- Written by X_anero
function onUse(cid, item, frompos, item2, topos)
if item.itemid == 2279 then
local playerpos = getCreaturePosition(cid)
doRemoveItem(item.uid,2279)
doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
doSendMagicEffect(playerpos, 12)
doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
end
end

If we somehow just could edit this script so it check if the player is allready promoted, got non vocation or level 20+ ? if not it should not allow the person to use the item.

Colors · Apr 19, 2013

Can you give us the download link of the server that you are using? I tried my code and works perfectly on TFS...

Veterana · Apr 19, 2013

Cthugha said:
Can you give us the download link of the server that you are using? I tried my code and works perfectly on TFS...

I am not using TFS, i am using Avesta as it says in the topic.
There is no download link for the server and i dont plan on uploading my whole server right now.

Calon · Apr 19, 2013

Veterana said:
Not working either.
The item ID is 5545 by the way!

This script adds vocation up, but doesnt check if the player is allready promoted or non vocation or level 20:

If we somehow just could edit this script so it check if the player is allready promoted, got non vocation or level 20+ ? if not it should not allow the person to use the item.

k
in actions.xml

LUA:

<action itemid="5545" event="script" value="promotion.lua"/>

in actions/scrips/
add promotion.lua

LUA:

function onUse(cid, item, fromPosition, itemEx, toPosition)
if item.itemid == 5545 then
local playerpos = getCreaturePosition(cid)
doRemoveItem(item.uid,1)
doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
doSendMagicEffect(playerpos, 12)
doPlayerSendTextMessage(cid,22,"You just got Promoted!.")
end
return true
end

[Avesta] Help with script

Oldschool Player

Joseluis Gonzalez

Oldschool Player

♥

Veteran OT User

♥

Veteran OT User

♥

Oldschool Player

Experienced Member

Oldschool Player

Experienced Member

♥

Experienced Member

Oldschool Player

Experienced Member

Oldschool Player

♥

Oldschool Player

Experienced Member