Myaac bug guild new rank

[ori_kasimiro]

Hello ...

I have big problem .

New name rank in myaac..


@slawkens

 

[slaw]

In what scenario does this error occur? What did you do so it happen?

 

[ori_kasimiro]

In what scenario does this error occur? What did you do so it happen?

" new create rank "

 

[slaw]

" new create rank "

Does it happen when you press on "Add" button?

 

[ori_kasimiro]

Does it happen when you press on "Add" button?

Yes
And no add New rank guild for bug above

 

[slaw]

Hello,

Thanks for your report. It was a bug in MyAAC.

The fix is here: Fixed guilds "Add new rank function" · slawkens/myaac@4d56650 (https://github.com/slawkens/myaac/commit/4d566500e9684bf7694659463309b37557dbb914)

Its enough if you replace content of system/pages/guilds/add_rank.php with this:

<?php
/**
 * Add rank
 *
 * @package   MyAAC
 * @author    Gesior <[email protected]>
 * @author    Slawkens <[email protected]>
 * @copyright 2017 MyAAC
 * @link      http://my-aac.org
 */
defined('MYAAC') or die('Direct access not allowed!');

$guild_name = isset($_REQUEST['guild']) ? urldecode($_REQUEST['guild']) : null;
$rank_name = isset($_REQUEST['rank_name']) ? $_REQUEST['rank_name'] : null;
if(!Validator::guildName($guild_name)) {
   $errors[] = Validator::getLastError();
}

if(empty($errors)) {
   if(!Validator::rankName($rank_name)) {
      $errors[] = 'Invalid rank name format.';
   }
   if(!$logged) {
      $errors[] = 'You are not logged.';
   }
   $guild = new OTS_Guild();
   $guild->find($guild_name);
   if(!$guild->isLoaded()) {
      $errors[] = 'Guild with name <b>'.$guild_name.'</b> doesn\'t exist.';
   }
   if(empty($errors)) {
      $guild_leader_char = $guild->getOwner();
      $rank_list = $guild->getGuildRanksList();
      $rank_list->orderBy('level', POT::ORDER_DESC);
      $guild_leader = false;
      $account_players = $account_logged->getPlayers();
      foreach($account_players as $player) {
         if($guild_leader_char->getId() == $player->getId()) {
            $guild_vice = true;
            $guild_leader = true;
            $level_in_guild = 3;
         }
      }
      if($guild_leader) {
         $new_rank = new OTS_GuildRank();
         $new_rank->setGuild($guild);
         $new_rank->setLevel(1);
         $new_rank->setName($rank_name);
         $new_rank->save();
         header("Location: ?subtopic=guilds&guild=".$guild->getName()."&action=manager");
         echo 'New rank added. Redirecting...';
      }
      else {
         $errors[] = 'You are not a leader of guild!';
      }
   }
   if(!empty($errors)) {
      $twig->display('error_box.html.twig', array('errors' => $errors));

      $twig->display('guilds.back_button.html.twig', array(
         'new_line' => true,
         'action' => '?subtopic=guilds&guild='.$guild_name.'&action=show'
      ));
   }
}
else
{
   if(!empty($errors)) {
      $twig->display('error_box.html.twig', array('errors' => $errors));

      $twig->display('guilds.back_button.html.twig', array(
         'new_line' => true
      ));
   }
}

?>

 

[ori_kasimiro]

Hello,

Thanks for your report. It was a bug in MyAAC.

The fix is here: Fixed guilds "Add new rank function" · slawkens/myaac@4d56650 (https://github.com/slawkens/myaac/commit/4d566500e9684bf7694659463309b37557dbb914)

Its enough if you replace content of system/pages/guilds/add_rank.php with this:

<?php
/**
* Add rank
*
* @package   MyAAC
* @author    Gesior <[email protected]>
* @author    Slawkens <[email protected]>
* @copyright 2017 MyAAC
* @link      http://my-aac.org
*/
defined('MYAAC') or die('Direct access not allowed!');

$guild_name = isset($_REQUEST['guild']) ? urldecode($_REQUEST['guild']) : null;
$rank_name = isset($_REQUEST['rank_name']) ? $_REQUEST['rank_name'] : null;
if(!Validator::guildName($guild_name)) {
   $errors[] = Validator::getLastError();
}

if(empty($errors)) {
   if(!Validator::rankName($rank_name)) {
      $errors[] = 'Invalid rank name format.';
   }
   if(!$logged) {
      $errors[] = 'You are not logged.';
   }
   $guild = new OTS_Guild();
   $guild->find($guild_name);
   if(!$guild->isLoaded()) {
      $errors[] = 'Guild with name <b>'.$guild_name.'</b> doesn\'t exist.';
   }
   if(empty($errors)) {
      $guild_leader_char = $guild->getOwner();
      $rank_list = $guild->getGuildRanksList();
      $rank_list->orderBy('level', POT::ORDER_DESC);
      $guild_leader = false;
      $account_players = $account_logged->getPlayers();
      foreach($account_players as $player) {
         if($guild_leader_char->getId() == $player->getId()) {
            $guild_vice = true;
            $guild_leader = true;
            $level_in_guild = 3;
         }
      }
      if($guild_leader) {
         $new_rank = new OTS_GuildRank();
         $new_rank->setGuild($guild);
         $new_rank->setLevel(1);
         $new_rank->setName($rank_name);
         $new_rank->save();
         header("Location: ?subtopic=guilds&guild=".$guild->getName()."&action=manager");
         echo 'New rank added. Redirecting...';
      }
      else {
         $errors[] = 'You are not a leader of guild!';
      }
   }
   if(!empty($errors)) {
      $twig->display('error_box.html.twig', array('errors' => $errors));

      $twig->display('guilds.back_button.html.twig', array(
         'new_line' => true,
         'action' => '?subtopic=guilds&guild='.$guild_name.'&action=show'
      ));
   }
}
else
{
   if(!empty($errors)) {
      $twig->display('error_box.html.twig', array('errors' => $errors));

      $twig->display('guilds.back_button.html.twig', array(
         'new_line' => true
      ));
   }
}

?>

I Love You <3