Feature [0.2.4+/0.3.4+]NG/Elf Lookbot detection

[Evil Hero]

Hello there!

Note! This code was tested on tfs 0.2.4+

Information:
This code detects people which use the well known feature from NG, which calculates Players/Monsters health points by spamming the look package from client to the server.

If a player is suspicious, there'll popup a message in your console/gui ("Anti Bot: is suspecting Evil Hero of using a bot.")
don't worry, you don't have to watch your console/gui always.
It'll also be saved in your logs/otadmin.txt file, after the message was send 3x to the console/gui.

If there are still questions about it, feel free to ask.
I'm also taking suggestions to improve the entire system, since it's pretty basic for now.

Implementation:

Player.cpp:

after

nextStepEvent = 0;

add this

//NG Lookbot detection, made by: Evil Hero and Nicaw
	lastLookTime = OTSYS_TIME() / 1000;
	lookCount = 0;
	lookCount2 = 0;

goto the bottom of the file and add this
Server version 0.2.4+

//NG Lookbot detection, made by: Evil Hero and Nicaw
void Player::onLookAt(const Position pos)
{
     if(lookCount2 > 3) 
     {
          Logger* logger = Logger::getInstance();
          logger->logMessage(NULL, LOGTYPE_WARNING, 0,getName() + " is suspected of using a lookbot.", NULL);
          lookCount2 = -1;
     }
     if(lookCount2 == -1) 
         return;
     
     lookCount++;
     if(lookCount > 100) 
     {
         std::cout << "Anti Bot: is suspecting " << getName() << " of using a bot." << std::endl;
         //<< (OTSYS_TIME() / 1000 - lastLookTime) << " seconds." << std::endl;
         //so if this time is too low player is suspicious
         if( (OTSYS_TIME() / 1000 - lastLookTime) < 55 ) 
         {
             lookCount2++;
         }
         
         lookCount = 0;
         lastLookTime = OTSYS_TIME() / 1000;
     }
}

Server version 0.3.4+

//NG Lookbot detection, made by: Evil Hero and Nicaw
void Player::onLookAt(const Position pos)
{
     if(lookCount2 > 3) 
     {
          Logger* logger = Logger::getInstance();
	  logger->eFile("admin.txt", getName() + " is suspected of using a lookbot.", true);
          lookCount2 = -1;
     }
     if(lookCount2 == -1) 
         return;
     
     lookCount++;
     if(lookCount > 100) 
     {
         std::cout << "Anti Bot: is suspecting " << getName() << " of using a bot." << std::endl;
         //<< (OTSYS_TIME() / 1000 - lastLookTime) << " seconds." << std::endl;
         //so if this time is too low player is suspicious
         if( (OTSYS_TIME() / 1000 - lastLookTime) < 55 ) 
         {
             lookCount2++;
         }
         
         lookCount = 0;
         lastLookTime = OTSYS_TIME() / 1000;
     }
}

#include "textlogger.h"

Player.h:

after

bool hasLearnedInstantSpell(const std::string& name) const;

add this

//NG Lookbot detection, made by: Evil Hero and Nicaw
		void onLookAt(const Position pos);

after

uint32_t lastIP;

add this

//NG Lookbot detection, made by: Evil Hero and Nicaw
		uint32_t lastLookTime;
		uint16_t lookCount;
		int16_t lookCount2;

Game.cpp:

search for the function

bool Game::playerLookAt(uint32_t playerId, const Position& pos, uint16_t spriteId, uint8_t stackPos)

after

Player* player = getPlayerByID(playerId);
	if(!player || player->isRemoved())
		return false;

add this

//NG Lookbot detection, made by: Evil Hero and Nicaw
	player->onLookAt(pos);

If you use 0.3.4+ then add this!

Textlogger.cpp:

#include "player.h"

Now we are done.

kind regards, Evil Hero.

 

[Synthetic_]

Looks cool

 

[IMac]

nice anti bot feature

 

[Diazapam]

Very nice, great job.
I'll sure use this.

 

[Sync]

haha, very nice ^^

 

[MartyX]

This function is possible in 0.3 or 0.4?

 

[Evil Hero]

Thanks for the comments so far.

I'll post the version for 0.3.4+ later on.
eace:

kind regards, Evil Hero

 

[Beo]

Nice feature!
Repped.

 

[TracerS]

how to check whether the code works?
(- What should be included in the Ng "Creature Spy" ?)

 

[Evil Hero]

how to check whether the code works?
(- What should be included in the Ng "Creature Spy" ?)

I can't really remember what it was exactly called (kinda long ago, since I've lastly used NG).


kind regards, Evil Hero.

 

[EvulMastah]

I'm kinda sure that you've missunderstood what this thread is about.
It's not giving your ng a nice new feature, it helps people who host servers to detect people using it.


kind regards, Evil Hero.

I'm kinda sure that you've missunderstood what he is asking.
He wanted to know how to check if this code works (what to enable in ng to make it log the users).

 

[Evil Hero]

I'm kinda sure that you've missunderstood what he is asking.
He wanted to know how to check if this code works (what to enable in ng to make it log the users).

dumb me, hehe ^^

The way he was asking was not really clear to me, sounded like he wants to know what will be added by that code in ng.

but thanks for clearing my mind

 

[Pewo]

nice work rep++

 

[zieworski denero]

Have you tested it? XD

 

[DarkstaR]

I'm kinda sure that you've missunderstood what he is asking.
He wanted to know how to check if this code works (what to enable in ng to make it log the users).

NG and Elf both send look packets erratically at other players in order to get their vocation and level. Thats what this checks.

 

[Grehy]

I'm kinda sure that you've missunderstood what he is asking.
He wanted to know how to check if this code works (what to enable in ng to make it log the users).

Anyway, in NG it would be something like show player levels, etc

 

[Syntax]

tugbot ftw

 

[Atleta]

tfs 0.4 no compiling ;/

 

[Evil Hero]

I've added the 0.3.4+ version, check the first post.


kind regards, Evil Hero.

 

[chojrak]

tugbot ftw

Nope, ElfBot Pwnz d: