NPC Advance Guard [Attacking Pk's and Monsters with options] [TFS 1.x]

[Printer]

Hello,

Here is a guard npc, that will protect the city from intruders!

<?xml version="1.0" encoding="UTF-8"?>
<npc name="Guard" script="guard.lua" walkinterval="0" floorchange="0">
    <health now="100" max="100" />
    <look type="139" head="20" body="39" legs="45" feet="7" addons="0" />
</npc>

local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)

function onCreatureDisappear(cid)           npcHandler:onCreatureDisappear(cid)         end
function onCreatureSay(cid, type, msg)      npcHandler:onCreatureSay(cid, type, msg)    end

local config = {
    attackRadius = {x = 7, y = 5, targetDistance = 2, walkDistance = 7},
    attackPK = {value = true, skulls = {SKULL_WHITE, SKULL_RED}},
    attackMonster = {value = true, ignore = {"Rat", "Cave Rat"}, ignoreSummon = true},
    damageValue = {min = 10, max = 20}
}

-- Do not touch
local targetId = 0
local masterPosition

function Creature.isAttackable(self)
    if not self:isNpc() then
        if self:isPlayer() and not self:getGroup():getAccess() then
            if config.attackPK.value and isInArray(config.attackPK.skulls, self:getSkull()) then
                return true
            end
        end

        if self:isMonster() and config.attackMonster.value then
            local master = self:getMaster()
            if (config.attackMonster.ignoreSummon and master and not master:isPlayer()) or not isInArray(config.attackMonster.ignore, self:getName()) then
                return true
            end
        end

    end

    return false
end

function Npc.searchTarget(self)
    local attackRadius = config.attackRadius
    for _, spectator in ipairs(Game.getSpectators(self:getPosition(), false, false, attackRadius.x, attackRadius.x, attackRadius.y, attackRadius.y)) do
        if spectator:isAttackable() then
            targetId = spectator:getId()
        end
    end
end

function onThink()
    local npc = Npc()
    local target = Creature(targetId)

    -- If we have not a target, then we shall search for one
    if not target then
        npc:searchTarget()
        return
    end
 
    -- Let's get target offset position
    local npcPosition = npc:getPosition()
    local targetPosition = target:getPosition()
    local offsetX = npcPosition.x - targetPosition.x
    local offsetY = npcPosition.y - targetPosition.y

    -- Target is out of reach, search for new one
    local radius = config.attackRadius
    if math.abs(offsetX) > radius.x or math.abs(offsetY) > radius.y then
        npc:searchTarget()
        return
    end

    -- Back to spawn position
    if npcPosition:getDistance(masterPosition) >= radius.walkDistance then
        npcPosition:sendMagicEffect(CONST_ME_TELEPORT)
        npc:teleportTo(masterPosition)
        return
    end

    -- If target is found
    local npcId = npc:getId()
    doTargetCombatHealth(npcId, targetId, COMBAT_FIREDAMAGE, -config.damageValue.min, -config.damageValue.max, CONST_ME_HITBYFIRE)
    npcPosition:sendDistanceEffect(targetPosition, CONST_ANI_FIRE)
    doNpcSetCreatureFocus(targetId)
 
    -- Follow Target
    local distance = radius.targetDistance
    local path = npc:getPathTo(targetPosition, 0, distance, true, true)
    if path and npcPosition:getDistance(targetPosition) > distance then
        doMoveCreature(npcId, path[1])
    end

    npcHandler:onThink()                    
end

function onCreatureAppear(self)
    if self == Npc() and not masterPosition then
        masterPosition = self:getPosition()
    end
       
    npcHandler:onCreatureAppear(self)         
end

 

[Lava Titan]

Thank you! <3

 

[Eldin]

I will for sure test this out soon.
Thank You Printer.

Kind Regards,
Eldin.

 

[Geekbuddys]

Nice! It should follow target should be awesome.

 

[Apollos]

Great job, worked perfectly. Someone have a way to make the npc only attack certain vocations that are skulled?

 

[zygus0001]

good work is work on 1.2?

can you edit npc atak witch sword or ice

 

[Eldin]

Ideas for Updates:
-The NPC will follow it's target to walk back/teleport back if out of reach.
(Maybe even set keep away x sqm from target like a monster so you can make range or melee guards)
-Option (true/false) to attack and be able to kill the NPC (and get a skull like attacking a player)
-Maybe let the Guard NPC be able to ignore summons instead of killing them?
-An example/easy way to add existing spells for the NPC and and rate when used to make him more advanced.

Kind Regards,
Eldin.

 

[Mandizinho]

I found it very interesting NPC .
I tried to make him follow the target, the more I could not.

 

[Printer]

I may consider update it and add new features and some of those you guys suggested.

 

[Eldin]

Another note: @Printer
If the Guard attack a target he will "freeze" once the attack is over, if you speak to him and go away/say bye the Guard will go back to normal and walk around again.

Kind Regards,
Eldin.

 

[Printer]

Added so he follows the target, also get teleported back to it's spawn position after reaching a certain distance and does not attack player summons.

Make sure recopy the xml file aswell.

 

[Geekbuddys]

Added so he follows the target, also get teleported back to it's spawn position after reaching a certain distance and does not attack player summons.

Make sure recopy the xml file aswell.

Awesome! But there is something wrong with ignore. The guard attack ignore monsters and ignore the unignore monsters.

 

[Eldin]

@Printer
Up already noted it.

Amazing work Printer.

Wanted features:
-Option (true/false) to attack and be able to kill the NPC (and get a skull like attacking a player)
-An example/easy way to add existing spells for the NPC and and rate when used to make him more advanced. Add spell like on a monster or so.

Kind Regards,
Eldin.

 

[Codex NG]

@Printer
Up already noted it.

Amazing work Printer.

Wanted features:
-Option (true/false) to attack and be able to kill the NPC (and get a skull like attacking a player)
-An example/easy way to add existing spells for the NPC and and rate when used to make him more advanced. Add spell like on a monster or so.

Kind Regards,
Eldin.

I am still waiting on Eldin's World!

 

[primate]

Begins to attack players without the skull.

TFS 1.2 shows no errors!

 

[Printer]

Begins to attack players without the skull.

Awesome! But there is something wrong with ignore. The guard attack ignore monsters and ignore the unignore monsters.

Fixed.

@Printer
Up already noted it.

Amazing work Printer.

Wanted features:
-Option (true/false) to attack and be able to kill the NPC (and get a skull like attacking a player)
-An example/easy way to add existing spells for the NPC and and rate when used to make him more advanced. Add spell like on a monster or so.

Kind Regards,
Eldin.

First, need to check if it's possible to kill a npc, asfar i know. It's not.
Second, there is no easy way to do that, without any source edit.

 

[primate]

Is perfect thank you very much.

 

[Eldin]

I'm so glad you upgraded this Printer, it's basicly perfect now, thank you for that.

Kind Regards,
Eldin.

 

[danick10]

Help please, i'm using this, the script load correctly, but the guard wont attack any player or monster....
it seems that he can't find any target... !

 

[danick10]

Ok, I find out now,, the problem happen only when there is more than 1 guard on the map
when I added 10 guard by city, it bugs