TFS 1.X+ Attack attribute on shields

[WikiArk21]

I noticed that it's possible to add an attack to the shield, which appears in the look, but that damage isn't calculated in the final damage. Does anyone have an explanation for this? And where do I need to change it so that the shield's attack is accounted for?

 

[Gesior.pl]

On OTS it's not 'attacking', it's 'using weapon'.

When you attack with basic attack, it goes to weapons.cpp and calculates damage for weapon you wear (by type: club, axe, sword, distance or wand), not check all equipped items 'attack'.
There are 3 functions that calculate weapon damage in TFS 1.4:
1. Melee (club, axe, sword):

forgottenserver/src/weapons.cpp at 1.4 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

2. Distance:

forgottenserver/src/weapons.cpp at 1.4 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

3. Wand:

forgottenserver/src/weapons.cpp at 1.4 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

You have Player* player variable in these functions, so you can add in player.cpp and player.h function ex. getShieldAttack() that will check both hands (left/right hand inventory slots), find shield and return it's attack attribute and call it in these functions ex. for 'melee' you can add shield attack to weapon (item) attack (in forgottenserver/src/weapons.cpp at 1.4 · otland/forgottenserver (https://github.com/otland/forgottenserver/blob/1.4/src/weapons.cpp#L593) ):

int32_t attackValue = std::max<int32_t>(0, item->getAttack() + player->getShieldAttack());

 

[Codinablack]

This function contains the logic you seek!

forgottenserver/src/combat.cpp at f169c6c3dc0d3f1f20ce09d3fdc32c81b05794ca · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

Inside that function is exactly where you need to add your check for the other hand... if you had a system which allows attack to be added to armors or legs or w/e and wanted to include a bunch of slots, you would simply iterate over all the slots, continue on the ones you wish to ignore, and the rest would be grabbing the item from the players inventory and counting it's attack.

I have given you exactly enough information to be able to work the problem out. I recommend trying to write the code yourself, but you could always get AI to help you if you basic questions about the language...

 

[WikiArk21]

I looked at both answers and they both gave me some guidance on how to do this, and I managed to do it. Thanks, guys.

 

[Tenzhiro]

Gesior and Codina for president!