TFS 1.X+ bank talkaction error

[Moody]

i am using this bank talkaction with bank npc too but i have this error when i use !transfer player, amount
can i fix it without removing bank npc? i see 1 reply to fix it but it destroy bank npc

attempt to concatenate field 'guid' (a nil value)

[TFS 1.4] Virtual Bank TalkAction

Banking through in-game commands. Allows player to deposit gold anywhere, ect. Not a new script. !deposit !withdraw !transfer name, amount !balance local banking = TalkAction("!balance","!deposit","!withdraw","!transfer") function banking.onSay(player, words, param) if (words ==...

otland.net

 

[Moody]

bump

 

[Moody]

bump

 

[beenii]

Try change

local targetPlayer = Player(target.guid)

To:

local targetPlayer = Player(target)

 

[Moody]

Try change

local targetPlayer = Player(target.guid)

To:

local targetPlayer = Player(target)

when i change this transfer command work but bank npc stop working
anyway to make both work

 

[mano368]

when i change this transfer command work but bank npc stop working
anyway to make both work

Post npc please

 

[beenii]

Try make new fuction, maybe problem is in

function Player.transferMoneyTo(self, target, amount)
    if not target then
        return false -- target isn't set return false --
    end

    -- See if you can afford this transfer
    local balance = self:getBankBalance()
    if amount > balance then
        return false
    end

    -- See if player is online
    local targetPlayer = Player(target.guid) -- If player isn't online this will cause an error (unless you already checked if he is online and sent userdata --
    if targetPlayer then -- Do a check that should of been done already because otherwise there is an error with above line --
        targetPlayer:setBankBalance(targetPlayer:getBankBalance() + amount)
    else -- Code will never reach this if player is not online. --
        db.query("UPDATE `players` SET `balance` = `balance` + " .. amount .. " WHERE `id` = '" .. target.guid .. "'")
    end

    self:setBankBalance(self:getBankBalance() - amount)
    return true
end

Try call diferent the fuction and call in the system, for example:

function Player.transferMoneyToTalkaction(self, target, amount)
    if not target then
        return false -- target isn't set return false --
    end

    -- See if you can afford this transfer
    local balance = self:getBankBalance()
    if amount > balance then
        return false
    end

    -- See if player is online
    local targetPlayer = Player(target.guid) -- If player isn't online this will cause an error (unless you already checked if he is online and sent userdata --
    if targetPlayer then -- Do a check that should of been done already because otherwise there is an error with above line --
        targetPlayer:setBankBalance(targetPlayer:getBankBalance() + amount)
    else -- Code will never reach this if player is not online. --
        db.query("UPDATE `players` SET `balance` = `balance` + " .. amount .. " WHERE `id` = '" .. target.guid .. "'")
    end

    self:setBankBalance(self:getBankBalance() - amount)
    return true
end

Put the second modified function at the top of the entire script.

And change in line 82

player:transferMoneyTo(target, amount)

To:

player:transferMoneyToTalkaction(target, amount)

and keep first changes in target

local targetPlayer = Player(target)

 

[Moody]

Post npc please

forgottenserver/data/npc/scripts/bank.lua at master · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

Post automatically merged: Feb 9, 2023

Try make new fuction, maybe problem is in

function Player.transferMoneyTo(self, target, amount)
    if not target then
        return false -- target isn't set return false --
    end

    -- See if you can afford this transfer
    local balance = self:getBankBalance()
    if amount > balance then
        return false
    end

    -- See if player is online
    local targetPlayer = Player(target.guid) -- If player isn't online this will cause an error (unless you already checked if he is online and sent userdata --
    if targetPlayer then -- Do a check that should of been done already because otherwise there is an error with above line --
        targetPlayer:setBankBalance(targetPlayer:getBankBalance() + amount)
    else -- Code will never reach this if player is not online. --
        db.query("UPDATE `players` SET `balance` = `balance` + " .. amount .. " WHERE `id` = '" .. target.guid .. "'")
    end

    self:setBankBalance(self:getBankBalance() - amount)
    return true
end

Try call diferent the fuction and call in the system, for example:

function Player.transferMoneyToTalkaction(self, target, amount)
    if not target then
        return false -- target isn't set return false --
    end

    -- See if you can afford this transfer
    local balance = self:getBankBalance()
    if amount > balance then
        return false
    end

    -- See if player is online
    local targetPlayer = Player(target.guid) -- If player isn't online this will cause an error (unless you already checked if he is online and sent userdata --
    if targetPlayer then -- Do a check that should of been done already because otherwise there is an error with above line --
        targetPlayer:setBankBalance(targetPlayer:getBankBalance() + amount)
    else -- Code will never reach this if player is not online. --
        db.query("UPDATE `players` SET `balance` = `balance` + " .. amount .. " WHERE `id` = '" .. target.guid .. "'")
    end

    self:setBankBalance(self:getBankBalance() - amount)
    return true
end

Put the second modified function at the top of the entire script.

And change in line 82

player:transferMoneyTo(target, amount)

To:

player:transferMoneyToTalkaction(target, amount)

and keep first changes in target

local targetPlayer = Player(target)

i will try, thankyou

 

[beenii]

Post npc please

forgottenserver/data/npc/scripts/bank.lua at master · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

Post automatically merged: Feb 9, 2023

i will try, thankyou

It's the first thing that occurred to me, I read about the problem, Sara mentioned it, I'm on my cell phone, try that, let me know if it works or not, so I can review it calmly from my computer

 

[mano368]

forgottenserver/data/npc/scripts/bank.lua at master · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

Post automatically merged: Feb 9, 2023

i will try, thankyou

@beenii told you how to solve

 

[Moody]

@beenii @mano368
it works good if player online but when he is offline I get same bug and if I change this target.guid in db.qury to target it say transferred but nothing transferred to player

 

[mano368]

@beenii @mano368
it works good if player online but when he is offline I get same bug and if I change this target.guid in db.qury to target it say transferred but nothing transferred to player

@Moody
Have you tried removing the .guid from target.guid?

Change this part too:

`id` = '" .. target.guid

to

`name` = '" .. target

 

[Moody]

Have you tried removing the .guid from target.guid?

Change this part too:

id = '" .. target.guid to name = '" .. target

iwilltry

Post automatically merged: Feb 9, 2023

@Moody
Have you tried removing the .guid from target.guid?

Change this part too:

`id` = '" .. target.guid

to

`name` = '" .. target

now worked, thanks