TFS 1.X+ Boss Reward Fix

[Ascuas Funkeln]

TFS 1.2

Hello, i need to fix this script, its work, but reward is given only to "Last Hit" player not for all who damage monster.
CreatureEvent - Boss Reward (https://otland.net/threads/boss-reward.243418/)

Any suggestions?

 

[HjugO]

TFS 1.2

Hello, i need to fix this script, its work, but reward is given only to "Last Hit" player not for all who damage monster.
CreatureEvent - Boss Reward (https://otland.net/threads/boss-reward.243418/)

Any suggestions?

getDamageMap

 

[Ascuas Funkeln]

getDamageMap

Already trying... and have no i idea for now how to setup this to work...

function onKill(creature, target)

local monster = "Puppet"
    if not monster then
        return true
    end

    for pid, _ in pairs(monster:getDamageMap()) do
        local attackPlayer = Player(pid)
            if attackPlayer then
                player:addItem(26767)
            end
        end
    end

 

[HjugO]

Already trying... and have no i idea for now how to setup this to work...

function onKill(creature, target)

local monster = "Puppet"
    if not monster then
        return true
    end

    for pid, _ in pairs(monster:getDamageMap()) do
        local attackPlayer = Player(pid)
            if attackPlayer then
                player:addItem(26767)
            end
        end
    end

local attackPlayer = Player(pid)

You want to kill player or monster?

 

[Ascuas Funkeln]

local attackPlayer = Player(pid)

You want to kill player or monster?

Thats not helping

 

[zxmatzx]

Tested.
data/creaturescripts/scripts/bossReward.lua:

function onKill(creature, target)
    local monsterName = "Puppet" --boss name to give reward
    if target:getName() ~= monsterName then --check if killed monster(target) is the boss
        return true --if not, return true
    end
    
    for pid, _ in pairs(target:getDamageMap()) do --get damageMap from target killed
        local attackerPlayer = Player(pid) --get userData of each player that damaged the target
        if attackerPlayer then --if player exist
            attackerPlayer:addItem(26767) --give reward
        end
    end
    return true
end

data/creaturescripts/creaturescripts.xml:

<event type="kill" name="bossReward" script="bossReward.lua"/>

data/creaturescripts/scripts/login.lua:
Above return true, put:

player:registerEvent("bossReward")

EDIT:
Commented code

 

[Ascuas Funkeln]

Tested.
data/creaturescripts/scripts/bossReward.lua:

function onKill(creature, target)
    local monsterName = "Puppet" --boss name to give reward
    if target:getName() ~= monsterName then --check if killed monster(target) is the boss
        return true --if not, return true
    end
   
    for pid, _ in pairs(target:getDamageMap()) do --get damageMap from target killed
        local attackerPlayer = Player(pid) --get userData of each player that damaged the target
        if attackerPlayer then --if player exist
            attackerPlayer:addItem(26767) --give reward
        end
    end
    return true
end

data/creaturescripts/creaturescripts.xml:

<event type="kill" name="bossReward" script="bossReward.lua"/>

data/creaturescripts/scripts/login.lua:
Above return true, put:

player:registerEvent("bossReward")

EDIT:
Commented code

Already do it in this way

function onKill(cid, target)
   local mob = Creature('Puppet')
   local damageMap = mob:getDamageMap()

   for id, damage in pairs(damageMap) do
     local creature = Creature(id)
     creature:addItem(26767)
   end
end

Anyway thanks for you time and ofc i will use aswell you script