• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

TFS 0.X [C++] Player does not get PZ after attacking PK

potinho

potinho

Advanced OT User
Joined
Oct 11, 2009
Messages
1,403
Solutions
17
Reaction score
151
Location
Brazil
Good morning everyone, today I realized that my server is behaving (I don't know if expected) but unwanted, let's think about the following scenario:

Player 1 Attacks Player 2 (and takes White Skull)
Player 2 attacks player 1 back and manages to enter a Protection Zone (shouldn't/would't)
After leaving the PZ, player 2 attacks player 1 again and turns Yellow Skull, and now it has PZ lock

I would like Player 2 to have PZ lock on the first attack, could you help me?

C++: 
void Player::onTarget(Creature* target)
{
    Creature::onTarget(target);

    if(target == this)
    {
        addInFightTicks(false);
        return;
    }

    if(hasFlag(PlayerFlag_NotGainInFight))
        return;

    Player* targetPlayer = target->getPlayer();
    if(targetPlayer && !isPartner(targetPlayer) && !isAlly(targetPlayer))
    {
        if(!pzLocked && g_game.getWorldType() == WORLDTYPE_HARDCORE)
        {
            pzLocked = true;
            sendIcons();
        }

        if(getSkull() == SKULL_NONE && getSkullType(targetPlayer) == SKULL_YELLOW)
        {
            addAttacked(targetPlayer);
            targetPlayer->sendCreatureSkull(this);
        }
        else if(!targetPlayer->hasAttacked(this))
        {
            if(!pzLocked)
            {
                pzLocked = true;
                sendIcons();
            }

            if(!Combat::isInPvpZone(this, targetPlayer) && !isEnemy(this))
            {
                addAttacked(targetPlayer);

                if(targetPlayer->getSkull() == SKULL_NONE && getSkull() == SKULL_NONE && (!guildId || !targetPlayer->getGuildId()))
                {
                    setSkull(SKULL_WHITE);
                    g_game.updateCreatureSkull(this);
                }

                if(getSkull() == SKULL_NONE)
                    targetPlayer->sendCreatureSkull(this);
            }
        }
    }

    addInFightTicks(false);
}
 
Sort by date Sort by votes
potinho said:
Good morning everyone, today I realized that my server is behaving (I don't know if expected) but unwanted, let's think about the following scenario:

Player 1 Attacks Player 2 (and takes White Skull)
Player 2 attacks player 1 back and manages to enter a Protection Zone (shouldn't/would't)
After leaving the PZ, player 2 attacks player 1 again and turns Yellow Skull, and now it has PZ lock

I would like Player 2 to have PZ lock on the first attack, could you help me?

C++: 
void Player::onTarget(Creature* target)
{
    Creature::onTarget(target);

    if(target == this)
    {
        addInFightTicks(false);
        return;
    }

    if(hasFlag(PlayerFlag_NotGainInFight))
        return;

    Player* targetPlayer = target->getPlayer();
    if(targetPlayer && !isPartner(targetPlayer) && !isAlly(targetPlayer))
    {
        if(!pzLocked && g_game.getWorldType() == WORLDTYPE_HARDCORE)
        {
            pzLocked = true;
            sendIcons();
        }

        if(getSkull() == SKULL_NONE && getSkullType(targetPlayer) == SKULL_YELLOW)
        {
            addAttacked(targetPlayer);
            targetPlayer->sendCreatureSkull(this);
        }
        else if(!targetPlayer->hasAttacked(this))
        {
            if(!pzLocked)
            {
                pzLocked = true;
                sendIcons();
            }

            if(!Combat::isInPvpZone(this, targetPlayer) && !isEnemy(this))
            {
                addAttacked(targetPlayer);

                if(targetPlayer->getSkull() == SKULL_NONE && getSkull() == SKULL_NONE && (!guildId || !targetPlayer->getGuildId()))
                {
                    setSkull(SKULL_WHITE);
                    g_game.updateCreatureSkull(this);
                }

                if(getSkull() == SKULL_NONE)
                    targetPlayer->sendCreatureSkull(this);
            }
        }
    }

    addInFightTicks(false);
}
Click to expand...
otland.net

TFS 0.X - player isn't getting frag if the attacked fight back

Hello, I'm using tfs 0.4 Fir3element/3777 (https://github.com/Fir3element/3777) and I'm having this problem with my frag system If a player kills another without the attacked fighting back, the injust kill works just fine and the player (attacker) get the frag If let's say I get attack...
otland.net otland.net
otland.net

TFS 1.X+ - Yellow Skull TFS 1.5

I have a problem with a yellow skull in TFS 1.5 downgrade by @Nekiro I had even commented on the post by @potinho, but in order not to disturb his solution, which is from another version, I decided to create this topic. My test is: Player 3 (Orange) - Attack Player 1 (get white skull) Player...
otland.net otland.net
 
Upvote 0 Downvote
pips said:
otland.net

TFS 0.X - player isn't getting frag if the attacked fight back

Hello, I'm using tfs 0.4 Fir3element/3777 (https://github.com/Fir3element/3777) and I'm having this problem with my frag system If a player kills another without the attacked fighting back, the injust kill works just fine and the player (attacker) get the frag If let's say I get attack...
otland.net otland.net
otland.net

TFS 1.X+ - Yellow Skull TFS 1.5

I have a problem with a yellow skull in TFS 1.5 downgrade by @Nekiro I had even commented on the post by @potinho, but in order not to disturb his solution, which is from another version, I decided to create this topic. My test is: Player 3 (Orange) - Attack Player 1 (get white skull) Player...
otland.net otland.net
Click to expand...
I've had already fixed Yellow skull gone problem, my problem is just when fight back, its not getting pz lock.
 
Upvote 0 Downvote
potinho said:
I've had already fixed Yellow skull gone problem, my problem is just when fight back, its not getting pz lock.
Click to expand...
ok, there's 2 places in that code that u can change in order to achieve that..
first option, dont check world type, and always add pzlock if anyone attack another

C++: 
// FROM
        if(!pzLocked && g_game.getWorldType() == WORLDTYPE_HARDCORE)
        {
            pzLocked = true;
            sendIcons();
        }

// TO
        if(!pzLocked)
        {
            pzLocked = true;
            sendIcons();
        }


second option, dont check if player 'hasAttacked' u first, before adding pzlock

C++: 
// FROM
        else if(!targetPlayer->hasAttacked(this))
        {
            if(!pzLocked)
            {
                pzLocked = true;
                sendIcons();
            }
            
// TO
            else
        {
            if(!pzLocked)
            {
                pzLocked = true;
                sendIcons();
            }
 
Upvote 1 Downvote
pips said:
ok, there's 2 places in that code that u can change in order to achieve that..
first option, dont check world type, and always add pzlock if anyone attack another

C++: 
// FROM
        if(!pzLocked && g_game.getWorldType() == WORLDTYPE_HARDCORE)
        {
            pzLocked = true;
            sendIcons();
        }

// TO
        if(!pzLocked)
        {
            pzLocked = true;
            sendIcons();
        }


second option, dont check if player 'hasAttacked' u first, before adding pzlock

C++: 
// FROM
        else if(!targetPlayer->hasAttacked(this))
        {
            if(!pzLocked)
            {
                pzLocked = true;
                sendIcons();
            }
           
// TO
            else
        {
            if(!pzLocked)
            {
                pzLocked = true;
                sendIcons();
            }
Click to expand...
Used second choice, works! Thanks!!!
 
Upvote 0 Downvote

Similar threads

potinho
  • Question
TFS 0.X Yellow skull fight back
Replies
2
Views
197
riderovsky
R
Jpstafe
  • Question
C++ Skull system, help me do this
Replies
11
Views
801
Jpstafe
Jpstafe
donabimbo
  • Question
C++ Take Condition Infight only when you take damage.
Replies
3
Views
526
emil92b
emil92b
L
  • Question
TFS 0.X Help! "You may not attack this creature"
Replies
5
Views
392
lSenturion2
L
Back
Top