Client "XP Gain Rate" display

[Michael Orsino]

In the newer clients we have a value called "XP Gain Rate". Its function is pretty self explanatory.
The question is: should the "XP Gain Rate" percentage include the config.lua/stages.xml EXP modifier or not?

EXAMPLES:
Option 1: 10x exp rate (in config.lua/stages.xml) would display as 1000%.
Option 2: 10x exp rate (in config.lua/stages.xml) would display as 100%

 

[Infernum]

Option 1, since that wording implies nothing about a bonus, it implies your current XP rate.

 

[Michael Orsino]

I tend to agree, but it then raises deeper questions about how bonus exp % should be applied.
Note that the client's tooltips specify that they add 50%.

50% extra of the modified EXP, or 50% of the unmodified exp?

Option A: 10x exp rate (in config.lua/stages.xml) + 50% stamina bonus = 1500%
Option B: 10x exp rate (in config.lua/stages.xml) + 50% stamina bonus = 1050%

I think that historically we have applied the experience as per Option A here.

 

[Infernum]

Again, A would be better here since we're using literal math, a bonus of 50% to 1000% xp should display as 1500%.

 

[Michael Orsino]

Agreed.
If anybody watching this is playing around with the otservbr tibia12 server, be aware that there are issues in the way this value displays and potentially in the way exp gain is calculated. I'll work on it when I'm home from work tonight.

 

[Michael Orsino]

@Stigma
With multiple boosts, for example stamina +50% and store +50%, should subsequent boosts multiply on the accumulative experience, or on the 'raw' experience (being the 10x exp rate in this example)

Option X: 10x exp rate (in config.lua/stages.xml) + 50% stamina bonus + 50% store bonus = 2000%
Option Y: 10x exp rate (in config.lua/stages.xml) + 50% stamina bonus + 50% store bonus = 2250%

 

[Infernum]

Depends on the actual implementation of your bonuses, if the bonuses work off of base XP% gain then X, otherwise Y.

 

[Michael Orsino]

The bonuses in the otservbr release calculate as Y. I suspect this is wrong though.
I am clarifying all of these points as I prepare to refactor the onGainExperience section of player.lua

 

[Michael Orsino]

Fixed: player.lua & login.lua update to calculate exp gain correctly & display 'XP Gain Rate' correctly by thatmichaelguy · Pull Request #313 · opentibiabr/OTServBR-Global (https://github.com/opentibiabr/OTServBR-Global/pull/313)

 

[Nemphis]

I didnt read all of the posts here but.
If it says 100% exp gain rate it is 1x. NORMAL.
If it says 200% exp gain rate it is 2x. Double
And the bonus of 50% exp gain rate would increase from 100 to 150. 200 to 250. (1x to 1.5x, 2x to 2.5)


understand?

If you have 8x exp gain rate it would be 800%

 

[Michael Orsino]

@Nemphis Yes that is clear.
What I wanted to confirm was:
1.) Should we...

• INCLUDE the exp rate of the server as part of this display (e.g. a 10x exp rate server would display as 1000%, with bonuses adding on top of that e.g. 1500% with stamina, and 2000% with stamina + stone bonus) or;
• EXCLUDE the exp rate of the server in the display (e.g. a 10x exp rate server would display as 100% normal, with bonuses adding on top of that e.g. 150% with stamina and 200% with stamina + store bonus)

2.) If the stamina and store bonuses added together, or if they multiplied together.
e.g. stamina bonus 50% + store bonus 50% = 100% bonus OR;
stamina bonus 50% * store bonus 50% = 125% bonus

#1 I've made it possible to toggle between both modes
#2 Seems obvious, but it was coded incorrectly on the OTServBR-Global release so I wanted to clarify it before I submitted a pull request.