Solved close channel network message

[whitevo]

Can i use network message to close a channel 10?
I tried something but client keeps crashing
working solution:

local msg = NetworkMessage()
msg:addByte(0xB3)
    msg:addU16(0x0A) -- channelID in ASCII
    msg:sendToPlayer(player)
    msg:delete()

void ProtocolGame::parseCloseChannel(NetworkMessage& msg)
{
   uint16_t channelId = msg.get<uint16_t>();
   addGameTask(&Game::playerCloseChannel, player->getID(), channelId);

 

[Infernum]

edit

in protocolgame i think it only parses the channel when the function in game.cpp Game:layerOpenChannel is executed

you could source edit a new function to close channel, it would be pretty much the same function as playerpenChannel(channelId)

int LuaScriptInterface::luaPlayerCloseChannel(lua_State* L)
{
    // player:closeChannel(channelId)
    uint16_t channelId = getNumber<uint16_t>(L, 2);
    Player* player = getUserdata<Player>(L, 1);
    if (player) {
        g_game.playerCloseChannel(player->getId(), channelId);
        pushBoolean(L, true);
    } else {
        lua_pushnil(L);
    }
    return 1;
}

 

[whitevo]

is there not a built in function to close channel for players?

not that i know of.

also you have msg:sendToPlayer(player) but im pretty sure networkmessage uses cid instead of userdata

what is that for then?
player->getID()

 

[whitevo]

I don't have that luascript.

I already found how source is doing it. I even showed it on opening post.
I don't know how to make it happen with Lua function using network message (if its even possible)

 

[Infernum]

I dont have that luascript

thats what im saying, you can add it easily
it's the same luascript function but uses Game:layerCloseChannel instead of Game:layerOpenChannel in game.cpp
just register it in luascript.cpp with registerMethod and in luascript.h

 

[whitevo]

thats what im saying, you can add it easily
it's the same luascript function but uses Game:layerCloseChannel instead of Game:layerOpenChannel in game.cpp
just register it in luascript.cpp with registerMethod and in luascript.h

I cant do that.

 

[StreamSide]

thats what im saying, you can add it easily
it's the same luascript function but uses Game:layerCloseChannel instead of Game:layerOpenChannel in game.cpp
just register it in luascript.cpp with registerMethod and in luascript.h

you can also do a pr

 

[whitevo]

you can also do a pr

what is pr?

I prefer network message solution. This should be possible. I just don't understand that at all. Do i need insert some byte code or what?

 

[Infernum]

i guess try this then since you cant source edit for whatever reason

local msg = NetworkMessage()
msg:addByte(0x99) -- Byte for protocolgame::parseCloseChannel
msg:addU16(xxxxx) -- Channel id
msg:addU32(player:getId())
msg:sendToPlayer(player)
msg:delete()

 

[whitevo]

case 0x99: parseCloseChannel(msg); break;

found this case. I assume this is the byte i need to add?

Even still, it will crash xD

 

[whitevo]

i guess try this then since you cant source edit for whatever reason

local msg = NetworkMessage()
msg:addByte(0x98) -- Byte for protocolgame::parseCloseChannel
msg:addU16(xxxxx) -- Channel id
msg:addU32(player:getId())
msg:sendToPlayer(player)
msg:delete()

doesn't work
You can also see in source it does not require playerID..

 

[Ninja]

I still recommend you to modify the source code because you still need to remove the user from the channel itself.

function Player.sendCloseChannel(self, channelId)
    local networkMessage = NetworkMessage()
    networkMessage:addByte(0xB3)
    networkMessage:addU16(channelId)
    networkMessage:sendToPlayer(self)
    networkMessage:delete()
    return true
end

 

[whitevo]

makes me question how did you know privateChat byte code works for this channel xD?

 

[Ninja]

makes me question how did you know privateChat byte code works for this channel xD?

By inspecting the flash client: https://github.com/comedinha/Flash-News/blob/master/scripts/tibia/network/Communication.as#L508

 

[Shadow_]

edit

in protocolgame i think it only parses the channel when the function in game.cpp Game:layerOpenChannel is executed

you could source edit a new function to close channel, it would be pretty much the same function as playerpenChannel(channelId)

int LuaScriptInterface::luaPlayerCloseChannel(lua_State* L)
{
    // player:closeChannel(channelId)
    uint16_t channelId = getNumber<uint16_t>(L, 2);
    Player* player = getUserdata<Player>(L, 1);
    if (player) {
        g_game.playerCloseChannel(player->getId(), channelId);
        pushBoolean(L, true);
    } else {
        lua_pushnil(L);
    }
    return 1;
}

it didn't gave me any errors while compiling but i got this error in console

Lua Script Error: [Chat Interface]
data/chatchannels/scripts/antibot.lua:onSpeak
data/chatchannels/scripts/antibot.lua:41: attempt to call method 'closeChannel' (a nil value)

This is the line in my script

        player:closeChannel(ANTI_BOT_SYSTEM.config.channelId)