C++ config exp per player

[Makin]

hi, how can I make 0.75 work in config and not 1. I use tfs 1.2.
I don't know much about c ++

it works
expenfo = 1
it doesn't work anymore
expenfo = 0.75


I know my English is poor

 

[Lucifer]

Take a look on my thread Exp from players (TFS 1.3 CLIENT 8.6) (https://otland.net/threads/exp-from-players-tfs-1-3-client-8-6.266942/#post-2577954)

 

[Makin]

player.cpp

uint64_t Player::getGainedExperience(Creature* attacker) const
{
    if (g_config.getBoolean(ConfigManager::EXPERIENCE_FROM_PLAYERS)) {
        Player* attackerPlayer = attacker->getPlayer();
        if (attackerPlayer && attackerPlayer != this && skillLoss && std::abs(static_cast<int32_t>(attackerPlayer->getLevel() - level)) <= g_config.getNumber(ConfigManager::EXP_FROM_PLAYERS_LEVEL_RANGE)) {
            return std::max<uint64_t>(0, std::floor(getLostExperience() * getDamageRatio(attacker) * g_config.getNumber(ConfigManager::EXP_ENFO_PLAYER)));
        }
    }
    return 0;
}

I've already added to
configmanager.cpp
integer[EXP_ENFO_PLAYER] = getGlobalNumber(L, "expenfo");
configmanager.h
EXP_ENFO_PLAYER,
config.lua
expenfo = 1
and only full numbers work. And I want them to work after the decimal point.
for example
expenfo = 0.75

 

[Makin]

f5

 

[Evil Puncker]

@roriscrave got the same request/problem as you, I don't remember if he got it or no but worth tagging

 

[Infernum]

Look at my code here (strictly configmanager.cpp/h), this is how I created config keys that accept decimal values: monster levels · delusionx/forgottenserver@3db1107 (https://github.com/delusionx/forgottenserver/commit/3db1107ed2708d369670d6b69e757a5b19232ca1#diff-6df5d8dfbf829d832803f8fad5657ac4)

 

[roriscrave]

have a simple solution, go to data/events/player.lua
check for

return exp

change to

return exp / 100

now u can use in xml exp 75 -> will be 0.75

 

[Makin]

thanks for the help. I had to change the code a little, but it works fine

 

[roriscrave]

thanks for the help. I had to change the code a little, but it works fine

Describe the solution you have found so others can do it

 

[Makin]

add configmanager.cpp

    floating[EXP_ENFO_PLAYER] = getGlobalFloat(L, "expenfo", 0.75);

under

int32_t ConfigManager::getNumber(integer_config_t _what) const
{
    if (_what >= LAST_INTEGER_CONFIG) {
        std::cout << "[Warning - ConfigManager::getNumber] Accessing invalid index: " << _what << std::endl;
        return 0;
    }
    return integer[_what];
}

add

float ConfigManager::getFloat(floating_config_t _what) const
{
    if (_what >= LAST_FLOATING_CONFIG) {
        std::cout << "[Warning - ConfigManager::getFloat] Accessing invalid index: " << _what << std::endl;
        return 0.0f;
    }
    return floating[_what];
}

under

int32_t ConfigManager::getGlobalNumber(lua_State* L, const char* identifier, const int32_t _default)
{
    lua_getglobal(L, identifier);
    if (!lua_isnumber(L, -1)) {
        return _default;
    }

    int32_t val = lua_tonumber(L, -1);
    lua_pop(L, 1);
    return val;
}

add

float ConfigManager::getGlobalFloat(lua_State* L, const char* identifier, const float defaultValue)
{
    lua_getglobal(L, identifier);
    if (!lua_isnumber(L, -1)) {
        lua_pop(L, 1);
        return defaultValue;
    }

    float val = lua_tonumber(L, -1);
    lua_pop(L, 1);
    return val;
}

configmanager.h
under

LAST_INTEGER_CONFIG /* this must be the last one */
        };

add

enum floating_config_t {
            EXP_ENFO_PLAYER,
           
            LAST_FLOATING_CONFIG
        };

under

        bool getBoolean(boolean_config_t _what) const;

add

        float getFloat(floating_config_t _what) const;

under

        static int32_t getGlobalNumber(lua_State* L, const char* identifier, const int32_t _default = 0);

add

        float getGlobalFloat(lua_State* L, const char* identifier, const float defaultValue = 0.0f);

under

        bool boolean[LAST_BOOLEAN_CONFIG];

add

        float floating[LAST_FLOATING_CONFIG];