TFS 1.X+ Creating / adding custom new skill

[Goku97]

-empty-

 

[Nekiro]

So you didnt edit otclient protocol? Your otclient needs to know how many skills you send from server, currently you are sending one more, but otc still thinks its one less. That's why you get parse message exception.

 

[Goku97]

-empty-

 

[Erexo]

in ProtocolGame:arsePlayerSkills
change
int lastSkill = Otc::Fishing + 1;
to
int lastSkill = Otc::Mining + 1;

In tfs add that mining skill to 0xA1 opcode.

look for and update all onSkillChange/onBaseSkillChange lua events.

 

[Goku97]

-empty-

 

[Nekiro]

Did you change SKILL_LAST in tfs? It's fishing by default. If you don't you are sending one skill less from server.

 

[Goku97]

-empty-

 

[Erexo]

For me it seems that this new skill is not covered properly in skills module (that is onSkillChange event)

You can try to debug LocalPlayer::setSkill method in OTC and check what values are there when skill == Otc::Mining.

And for debug purposes you can edit tfs message to something like this, it will always send the Mining skill at 123lv with 36% to go, if after that change OTC still isn't working, this is otc-sided fault (which I'm 98% sure it is).

void ProtocolGame::AddPlayerSkills(NetworkMessage& msg)
{
    msg.addByte(0xA1);
    for (uint8_t i = SKILL_FIRST; i < SKILL_LAST; ++i) {
        msg.addByte(std::min<int32_t>(player->getSkillLevel(i), std::numeric_limits<uint16_t>::max()));
        msg.addByte(player->getSkillPercent(i));
    }
    msg.addByte(123);
    msg.addByte(36);
}

 

[Goku97]

-empty-

 

[Goku97]

-empty-

 

[Goku97]

-empty-

 

[Veoas]

Did you figure out how to add it Goku97? Trying to do it myself and having problems.

 

[kuhi]

typical ask and run when solved
guys asking for help but they can't help others, this is the world we live