Lua [Creaturescript] Count kills

[Northnorial]

It doesn't work ...

function onKill(cid, target)
	if (isPlayer(target) == FALSE and getCreatureName(target) == "Demon" and getPlayerStorageValue(cid, 76672) == 2) then
	if getPlayerStorageValue(cid, 55667) < 100 then 
		local killedMonsters = getPlayerStorageValue(cid, 55667)
            if (killedMonsters == -1) then
                killedMonsters = 1
			end
			setPlayerStorageValue(cid, 55667, killedMonsters + 1)
			doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "You have killed " .. killedMonsters .. " of 100 demons.")
		else
			doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "You have killed enough demons.")
			setPlayerStorageValue(cid, 76672, 3)
		end
	end
	return TRUE
end

Could you fix it for me?

 

[devianceone]

If you tell us whats wrong, maybe.. your tabbing is a mess.

 

[hodleo]

here, grab

local s, t = 76672, 55667

function onKill(cid, target, lastHit)
    if isMonster(target) and getCreatureName(target):lower() == 'demon' and isPlayer(cid) and getCreatureStorage(cid, s) == 2 then
        if getCreatureStorage(cid, t) < 100 then 
            doCreatureSetStorage(cid, t, math.max(1,getCreatureStorage(cid, t)+1))
            doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, 'You have killed ' .. getCreatureStorage(cid, t) .. ' of 100 demons.')
        else
            doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, 'You have killed enough demons.')
            doCreatureSetStorage(cid, s, 3)
        end
    end
    return true
end

 

[Northnorial]

If you tell us whats wrong, maybe.. your tabbing is a mess.

Sorry, I edited the script without tabbing.

here, grab

local s, t = 76672, 55667

function onKill(cid, target, lastHit)
    if isMonster(target) and getCreatureName(target):lower() == 'demon' and isPlayer(cid) and getCreatureStorage(cid, s) == 2 then
        if getCreatureStorage(cid, t) < 100 then 
            doCreatureSetStorage(cid, t, math.max(1,getCreatureStorage(cid, t)+1))
            doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, 'You have killed ' .. getCreatureStorage(cid, t) .. ' of 100 demons.')
        else
            doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, 'You have killed enough demons.')
            doCreatureSetStorage(cid, s, 3)
        end
    end
    return true
end

Ok, thank you. It works now.

 

[Calon]

could someone add the creatureevents.xml line ?

 

[hodleo]

registerCreatureEvent(cid, 'demon')

<event type="kill" name="demon" event="script" value="demon.lua"/>