Renato Foot
Member
- Joined
- Nov 30, 2017
- Messages
- 13
- Reaction score
- 17
Crystal Server
- Thread starter Tryller
- Start date
El Bringy
Advanced OT User
- Joined
- Jan 5, 2013
- Messages
- 241
- Solutions
- 4
- Reaction score
- 163
Canary based on OTServbr yeahI don't want to go offtopic but it seems you're being too extremist, no?
We don't start every repository thanking the 5 million people that contributed to our society and technology advances we have today, do we?
The way you speak it seems like canary is a fork of tfs and that is simply not true at all. Canary is built upon otservbr which used OTX which used parts of TFS. If you sum all the commit history of those projects they go WAAAAAAAAAY above the 4k commits TFS has today. You're a dev, I shouldn't be explaining you this... just git compare both repositories
Also, back when we were developing otservbr, we had forgottenserver credit, therefore it is credit by reference. Today they are quintessentially different projects, even on purpose and vision.
Canary was never cloning TFS, we just cherry-picked (and mostly rewritten) bug fixes by contributors we thought were worth it, regardless of which base they were contributing to.
It wasn't unreliable, we just opted for a design pattern that you seem to not understand: Canary Deployment.
We had gigantic servers using it back then, some peaking with 400 players simultaneously. Of course that is through the iteration and feedback of this large stress testing we were able to improve the base further;
1) Open source just means anyone can use it, test it and improve it. There's no such thing as development team... Again, you can check this by seeing the contributor list in github, but you know this, right?
2) I don't understand what you're trying to say here, you clearly don't understand what you're saying either. You don't understand canary, you don't understand the premise, challenges.... hell, you don't even seem to understand what we do as a core or what our objective is. The fact that you're writting a wall of text being this clueless speaks mountains to me.
3) I don't understand what you're saying, do you think internet points make you a better developer or maintainer of a repository?
If so, I must be the best programmer of this community by a large margin
OtservBR was based on? Minecraft?
Your discussions are always the same Pointless & meaningless
not a single point you discussed deserves a reply tbh so @Jungian Is clearly right, this is how you talk when you got no reply but i will give you my 2 cents on this.
1) Credits is not for who created the repository its for anybody that had game changing contributions which is basically should be given to the core developers of the engine (TFS developers) when you changed its name from otservbr-global to canary.
2) what is your objective when it is not reliable i don't get, as much as you move further from TFS development your source code becomes more unreliable and useless. congratulations your canary deployment already fails in all versions.
3) as any open-source code in the world that used another open-source code as its fork credits should be given to the original fork but you don't even consider ethics.
4) Check how its done in TFS 1.4.2 Credits list to every single contributor maybe you can have a simple idea on how to lead open-source development like a professional project manager.
Take my last cent on this you really need it if you want to improve.
Why you shouldn't apply more features to current issues :
- It breaks the feedback loop
- The goal of a canary is to test small, incremental changes.
- If you add more features before fixing detected bugs, you're polluting your results and making debugging harder.
- It increases risk :
- New features may introduce new bugs, compounding the existing problems.
- You might end up deploying a bundle of unstable code.
- It defeats the purpose
- Canary deployments are about mitigating risk.
- Ignoring bugs and continuing forward is closer to a rolling release, not a cautious test phase.
which proofs forward you have no idea what are you talking about, perhaps you should read more before copy-pasting.
- It reflects bad release hygiene
- Clearly signals a lack of discipline in release management, CI/CD pipeline misuse, or pressure to push features regardless of quality.
References:
Ethics of Open Source Software Licensing - Escrow London (https://www.escrowlondon.com/news/ethics-of-open-source-software-licensing/) (Basic information about Ethics in open-source development this will help you be better)
Google SRE - Canary Release: Deployment Safety and Efficiency (https://sre.google/workbook/canarying-releases/) (Basic information about how to do canary deployment that you claim you already do this will help you do better)
Night Wolf
I don't bite.
- Joined
- Feb 10, 2008
- Messages
- 609
- Solutions
- 8
- Reaction score
- 967
- Location
- Spain
- GitHub
- andersonfaaria
we did applied some minecraft concepts, I'm glad you noticed!
Please compare the 2 repositories before we continue this discussion. Then I want you to go to GitHub - otland/forgottenserver: A free and open-source MMORPG server emulator written in C++ (https://github.com/otland/forgottenserver) and point me where in TFS you have what you're demanding us to have in Canary.
You say this based on what exactly? Can you run 14.x version in TFS with all global systems, map and quests having a better performance than what Canary delivers today? I'm quite willing to say I'm wrong once you prove me this.
At least in Github our buildings are passing
You're confusing ethics with moral, I cannot consider ethics since it's a collective understanding (with me included). I can consider my own morality, which in this case I'm 100% with the fact that open src communities should not be ego showdowns for people fighting over "most lines updates" status. Again, your premise is wrong. You'll understand it once you compare the 2 repositories.
It's exactly like canary, no credit information. There's a link to an old repo with list of some contributors but it's missing a lot of folks that had significant contribution even coaching some of folks in the list
It's also missing credits to Linus Torvalds, Bjarne, Lua developers, to Petrobras, to Brazillian Government, to PUC-Rio among many and many others.
I wish it was your real take on it and not just some gibberish you got from chatgpt.
Personally, I don't have any issues over you assuming you understand better CI/CD or canary process than me. The fact is you're completely oblivious to what are the challenges we have with current architecture, lack of testers, lack of feedback and even lack of developers.
I'm more than ready to take your advice, just join our discord and I'll love to spend hours discussing with you solutions and how to do better.
Contrary to what you think, I don't have any problems with someone that thinks they have a solution to every problem. I even feel a professional curiosity towards what you can deliver or propose. But I've been around for 20y and will probably stay for 20 more, I don't take decisions based on your short term feelings.
Post automatically merged:
aren't you the guy who was going from server to server to try and scam them for bug fixes? We must really be a pain in your ass delivering fixes so quickly, huh? No hard feelings
you probably mistook me for someone else or you didn't read carefully, it's rude to accuse someone without evidencearen't you the guy who was going from server to server to try and scam them for bug fixes? We must really be a pain in your ass delivering fixes so quickly, huh? No hard feelings
Night Wolf
I don't bite.
- Joined
- Feb 10, 2008
- Messages
- 609
- Solutions
- 8
- Reaction score
- 967
- Location
- Spain
- GitHub
- andersonfaaria
It's not so fun when others do it with you, right?you probably mistook me for someone else or you didn't read carefully, it's rude to accuse someone without evidence
Next time bring some evidence too of what you said about us not working on existing issues
After all, the list of bugs and the code are publicly available on GitHub. Even I (or rather my client/partner) experienced a bug where a character wouldn’t disappear upon death, still received party experience, and it ended up duplicating items because the character wasn’t saved properly xD.
On top of that, there were tons of crashes and other issues. Many attempts at “innovation” followed by patching them with workarounds doesn’t leave a good impression either.
I do appreciate some of the features, and parts of the code are well written, but personally, I wouldn’t use Canary if I didn’t want to eventually feel ashamed running a large server with it.
Effort is admirable and deserves respect - especially considering the time that was likely invested - but that doesn’t change the overall picture.
On top of that, there were tons of crashes and other issues. Many attempts at “innovation” followed by patching them with workarounds doesn’t leave a good impression either.
I do appreciate some of the features, and parts of the code are well written, but personally, I wouldn’t use Canary if I didn’t want to eventually feel ashamed running a large server with it.
Effort is admirable and deserves respect - especially considering the time that was likely invested - but that doesn’t change the overall picture.
Night Wolf
I don't bite.
- Joined
- Feb 10, 2008
- Messages
- 609
- Solutions
- 8
- Reaction score
- 967
- Location
- Spain
- GitHub
- andersonfaaria
I've been actively reviewing the list of open issues for a few years, there was a saving issue that lasted for < 20d while we were working in implementing the new system of tibia to not logout after dying. (I hope this is what you're talking about, otherwise please point me the issue you opened)
I'm sorry to hear this affected you, but this was over a year now and the time this bug was open relatively to how many years the project is being developed and improved don't seem to be a good representative of the work everyone else is putting into it.
Crashes, again, seems like you're talking about before Eduardo did the migration to smart pointers last year. Unfortunately it's very difficult to manage big and necessary reworks while maintaining full stability.
Give it a try again and send me a note if you have any issues. I'll personally investigate and try to fix any crashes you show me are replicable in the base repository.
- Joined
- Sep 7, 2015
- Messages
- 2,734
- Solutions
- 127
- Reaction score
- 2,203
would this mean that my engine (private one for darkrest) is no longer tfs, because it has 5.5k commits in total? (it was not forked this is the raw value from 3 years of development)
I have 0 intention to contribute to this talk, but I just want to point it out, that this means nothing.
My server is tfs (heavily edited) but still tfs. As it's canary, changing the project structure, formatting and copyright headers doesn't make you brand new project without any legacy. You are using tfs code in most places of the project even literally untouched. Rewrite the core code and then we can re-evaluate if it's still tfs or not, last time I checked it was the same.
Last edited:
Night Wolf
I don't bite.
- Joined
- Feb 10, 2008
- Messages
- 609
- Solutions
- 8
- Reaction score
- 967
- Location
- Spain
- GitHub
- andersonfaaria
I understand what you're coming from and partly I agree, pretty much all the bases that are and that there will be can refer to TFS for reference, even if they are entirely written from scratch or completely re-done. Even if we just check how it was done so we don't make the same mistakes.
I'm not trying to descredit influence of the project, I've used TFS for a big portion of my life as a dev and partly contributed to it myself.
But there has to be a point where it doesn't make sense anymore saying they are the same thing (you can refer to this paradox).
If you rewrite your entire project and call it TFS, won't it be TFS?
If you commit all your changes to original TFS and then call your project "Nekiro Base", won't it be TFS?
If I replace every single line of code either by new architecture, libraries or entire reworks, will it be TFS?
In the end, everything is built on top of something else. Even you as a human is an amalgamation of what you experienced and learned since childhood. What you understand as your own thoughts are merely a stack of what you seen in life + some genectic predisposition. Does that mean you're not you? Should I say Nekiro as a human being is always just his parents + everyone else he interacted?
Post automatically merged:
on top of that...
TFS was built on top of OpenTibia, which was built on top of a few different projects leaked through time. Which were all built on top of reverse engineerings of cipsoft. Why did you guys decided to name it TFS and not "Tibia"?
heitorzinhotc
Viva la Vida!
- Joined
- Aug 8, 2008
- Messages
- 123
- Reaction score
- 10
The impression that gives is that there is a jealousy in the air, I'm sorry if I'm wrong.
Luan Luciano
Active Member
kkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkk
admin canary's words translated:
"Alias, our 15 will probably have improvements in relation to what was made available out there, because as far as I know, this other repository does not have so many people engaged there who have a great knowledge about the C++ base and the bytes related to the cip protocol."
Careful, this is the only place that you are still minimally respected and unbanned, try to keep what is left of your dignity. Depois nao va chorar..
Luan Luciano
Active Member
being banned for exporting trade disguised as hypocrites, does that take away my dignity? kkkkkkkkkkkkkkkkkkkkkkkkCareful, this is the only place that you are still minimally respected and unbanned, try to keep what is left of your dignity. Depois nao va chorar..
Sure that's why you were banned, don't lie to yourself, scammer.
Luan Luciano
Active Member
Yes, I am a scammer and you are the one using a fake account? In the last attempt to boycott voices, there was a topic with items from customers speaking well of me and the canary administrators without answers, in the end they deleted the topic
Mateus Robeerto
Legendary OT User
Crystal Server is better. Long live Crystal!
Fake account? Are you dumb or what? Haha 2010 when this account was created you were still a baby.
Yeah, perhaps in OTA you were also banned bc of the evil canary admins, what a joke..
Luan Luciano
Active Member
I don't know you
Vasconcellos
Active Member
- Joined
- Dec 18, 2024
- Messages
- 19
- Reaction score
- 26
- Location
- Brazil
- GitHub
- vllworldbuilding
- Twitch
- vllworldbuilding
- YouTube
- vllworldbuilding
Just an observation, most of Crystal's PRs are ripped off from Canary.
