Does this LUA-script work? (I don't got a server, to lazy)

[lizz]

Hello, I wanna know if this script works. I'm really not sure. Please answer me fast there's so many good scripters here so someone could help me? :$

function onUse(cid, item, fromposition, itemex, toposition)
if item.itemid == 1945 then
doplayersendtextmessage(cid,20,"Cheer's you got a bag.")
docreatureadditem(item.uid,item.itemid 2000)
dotransformitem(item.uid,item.itemid 1946)
elseif item.itemid == 1946
doplayersendtextmessage(cid,21,"Cheer's you got a bag.")
docreatureadditem(item.uid,item.itemid 2000)
dotransformitem(item.uid,item.itemid 1946)
end
return TRUE
end

That should add a item by ID 2000 shouldn't it?:huh:

 

[zieworski denero]

use code tags plx

Lua: demo

 

[hodleo]

first, all those horrible lowercases, all functions will be nil

second, 'docreatureadditem' doesnt exist 'doPlayerAddItem?'

third, missing (,) separation: "docreatureadditem(item.uid,item.itemid 2000)"

4th, docreatureadditem(item.uid,item.itemid 2000) 2000 #itams??

 

[hodleo]

t = {
    [1945] = {msg = 20},
    [1946] = {msg = 21}
    }

function onUse(cid, item, fromPosition, itemEx, toPosition)
    if t[item.itemid] then
        doPlayerSendTextMessage(cid, t[item.itemid].msg, "Cheer's you got a bag.")
        doPlayerAddItem(cid, 2000, 1)        
        doTransformItem(item.uid, 1946)
    end
return TRUE
end

 

[Cykotitan]

local t

It does[?] make a difference

Also,

function onUse(cid, item, fromPosition, itemEx, toPosition)
	doPlayerSendTextMessage(cid, item.itemid == 1945 and 20 or 21, "Cheers, you got a bag!")
	doPlayerAddItem(cid, 2000, 1)     
	return doTransformItem(item.uid, item.itemid == 1945 and 1946 or 1945)
end

because the table was unnecessary

 

[hodleo]

nope, it's just my style (i don't make it for lag concern, which isn't noticed)

 

[Cykotitan]

nope, it's just my style (i don't make it for lag concern, which isn't noticed)

It's about memory usage - hosts already have enough memory leaks and don't want any more (potential) leaks.