OTX2 - trap hit is accumulating.

[tdp157]

Hello, can anyone help me?

I have an OTX 2 07 Server - Codename LORD ZEDD.

And it is now possible to add the damage from traps to kill monsters.

I send my trap.lua movements script for analysis.

function onStepIn(cid, item, pos)
    if (isInArray(TRAP_OFF, item.itemid) == TRUE) then
        if (isPlayer(cid) == TRUE) then
            doTargetCombatHealth(0, cid, COMBAT_PHYSICALDAMAGE, -50, -100, CONST_ME_NONE)
            doTransformItem(item.uid, item.itemid + 1)
        end
    elseif (item.itemid == 2579) then
        if (isPlayer(cid) ~= TRUE) then
            doTargetCombatHealth(0, cid, COMBAT_PHYSICALDAMAGE, -10, -20, CONST_ME_NONE)
            doTransformItem(item.uid, item.itemid - 1)
        end
    end
    return TRUE
end

function onStepOut(cid, item, pos)
    doTransformItem(item.uid, item.itemid - 1)
    return TRUE
end

function onRemoveItem(item, tile, pos)
    if (getDistanceBetween(getThingPos(item.uid), pos) > 0) then
        doTransformItem(item.uid, item.itemid - 1)
        doSendMagicEffect(getThingPos(item.uid), CONST_ME_POFF)
    end
    return TRUE
end

function onAddItem(item, tileitem, pos)
    doTransformItem(item.uid, item.itemid - 1)
    doSendMagicEffect(pos, CONST_ME_POFF)
    return TRUE
end

 

[Xikini]

function onStepIn(cid, item, pos)
    if (isInArray(TRAP_OFF, item.itemid) == TRUE) then
        --if (isPlayer(cid) == TRUE) then
            doTargetCombatHealth(0, cid, COMBAT_PHYSICALDAMAGE, -50, -100, CONST_ME_NONE)
            doTransformItem(item.uid, item.itemid + 1)
        --end
    elseif (item.itemid == 2579) then
        --if (isPlayer(cid) ~= TRUE) then
            doTargetCombatHealth(0, cid, COMBAT_PHYSICALDAMAGE, -10, -20, CONST_ME_NONE)
            doTransformItem(item.uid, item.itemid - 1)
        --end
    end
    return TRUE
end

 

[tdp157]

function onStepIn(cid, item, pos)
    if (isInArray(TRAP_OFF, item.itemid) == TRUE) then
        --if (isPlayer(cid) == TRUE) then
            doTargetCombatHealth(0, cid, COMBAT_PHYSICALDAMAGE, -50, -100, CONST_ME_NONE)
            doTransformItem(item.uid, item.itemid + 1)
        --end
    elseif (item.itemid == 2579) then
        --if (isPlayer(cid) ~= TRUE) then
            doTargetCombatHealth(0, cid, COMBAT_PHYSICALDAMAGE, -10, -20, CONST_ME_NONE)
            doTransformItem(item.uid, item.itemid - 1)
        --end
    end
    return TRUE
end

Continues adding the damage of all traps in the stack

 

[Xikini]

Continues adding the damage of all traps in the stack

View attachment 81121

You'll have to explain better what you want to happen, cuz I don't understand.

 

[chucky91]

This function should avoid stacking the traps on top, accumulating damage.

function onAddItem(item, tileitem, pos)
    doTransformItem(item.uid, item.itemid - 1)
    doSendMagicEffect(pos, CONST_ME_POFF)
    return TRUE
end

function onAddItem(item, tileitem, pos)
    if (item.itemid == 2579) then
        doTransformItem(item.uid, item.itemid - 1)
        doSendMagicEffect(pos, CONST_ME_POFF)
    end
    return true
end

try testing the script separately from each function, and use true and not TRUE.

And check if any of these functions above are not causing damage even when closed.