Experience stages

[nanduzenho]

Good morning, when I set the exp to 0.5x the player doesn't get exp, only when I set it to 1x, but I want to put stages below 1x
I'm using TFS 1.3

<?xml version="1.0" encoding="UTF-8"?>
<stages>
    <config enabled="1" />
    <stage minlevel="8" maxlevel="100" multiplier="50" />
    <stage minlevel="101" maxlevel="150" multiplier="40" />
    <stage minlevel="151" maxlevel="160" multiplier="30" />
    <stage minlevel="161" maxlevel="170" multiplier="20" />
    <stage minlevel="171" maxlevel="180" multiplier="10" />
    <stage minlevel="181" maxlevel="190" multiplier="1" />
    <stage minlevel="191" maxlevel="200" multiplier="0.7" />
    <stage minlevel="201" maxlevel="300" multiplier="0.6" />
    <stage minlevel="301" multiplier="0.5" />
</stages>

 

[Ftilt]

Does it work on 0.7 and 0.6? If so, add a maxlevel to the 0.5 multiplier

 

[nanduzenho]

Does it work on 0.7 and 0.6? If so, add a maxlevel to the 0.5 multiplier

doesn't work

 

[Ftilt]

Move experience stages to Lua by ranisalt · Pull Request #1642 · otland/forgottenserver

Removed experience stages logic from C++, too. The logic is a bit simpler in Lua. The complexity is O(quantity of stages + range of the largest stage), both are runtime constants. Moving to Lua cod...

github.com

 

[nanduzenho]

Move experience stages to Lua by ranisalt · Pull Request #1642 · otland/forgottenserver

Removed experience stages logic from C++, too. The logic is a bit simpler in Lua. The complexity is O(quantity of stages + range of the largest stage), both are runtime constants. Moving to Lua cod...

github.com

there is a synthase error, I don't know how to fix it =/

 

[Evil Puncker]

there is a synthase error, I don't know how to fix it =/

show us the error here, by the way have you had in mind that you are making player earn less exp than they would playing rl tibia?

 

[nanduzenho]

show us the error here, by the way have you had in mind that you are making player earn less exp than they would playing rl tibia?

my source doesn't have config.lua.dist

 

[Evil Puncker]

my source doesn't have config.lua.dist

edit config.lua instead

 

[Lbtg]

how it ended ? seems i have same problem on 1,3 tfs

 

[nanduzenho]

how it ended ? seems i have same problem on 1,3 tfs

it's not over = /

 

[Lbtg]

it's not over = /

we fixed this problem

 

[nanduzenho]

we fixed this problem

how did you solve it?

 

[Lbtg]

how did you solve it?

dont use Xml for stages. use stages in config.lua

Post automatically merged: Dec 3, 2021

dont use Xml for stages. use stages in config.lua

i dont remeber if there was need to edit source. we found solve in otland forum, about what i mention above

 

[nanduzenho]

up

 

[nanduzenho]

up

 

[jestem pro]

Dunno if it works but in game.cpp find function

bool Game::loadExperienceStages()

And set every variable's value:

mul = 1.0f
defStageMultiplier = 1.0f;

to the lowest value you will use:

mul = 0.5f
defStageMultiplier = 0.5f;

so maybe you will be able to use values: 0.5, 0.6, 0.7 etc

I use 0.3.6, so notice that there might be different names, but the idea is to set the value from 1.0f to lower.
Then compile and check.

 

[Loney]

Here you have a workaround if you don't want to edit your sources: TFS 1.X+ - tfs 1.3 not support dotted exp stages. (https://otland.net/threads/tfs-1-3-not-support-dotted-exp-stages.266101/#post-2575571)
Can't guarantee it will work for you since i didn't tested it

 

[nanduzenho]

Dunno if it works but in game.cpp find function

bool Game::loadExperienceStages()

And set every variable's value:

mul = 1.0f
defStageMultiplier = 1.0f;

to the lowest value you will use:

mul = 0.5f
defStageMultiplier = 0.5f;

so maybe you will be able to use values: 0.5, 0.6, 0.7 etc

I use 0.3.6, so notice that there might be different names, but the idea is to set the value from 1.0f to lower.
Then compile and check.

How do I change?

bool Game::loadExperienceStages()
{
    pugi::xml_document doc;
    pugi::xml_parse_result result = doc.load_file("data/XML/stages.xml");
    if (!result) {
        printXMLError("Error - Game::loadExperienceStages", "data/XML/stages.xml", result);
        return false;
    }

    for (auto stageNode : doc.child("stages").children()) {
        if (strcasecmp(stageNode.name(), "config") == 0) {
            stagesEnabled = stageNode.attribute("enabled").as_bool();
        } else {
            uint32_t minLevel, maxLevel, multiplier;

            pugi::xml_attribute minLevelAttribute = stageNode.attribute("minlevel");
            if (minLevelAttribute) {
                minLevel = pugi::cast<uint32_t>(minLevelAttribute.value());
            } else {
                minLevel = 1;
            }

            pugi::xml_attribute maxLevelAttribute = stageNode.attribute("maxlevel");
            if (maxLevelAttribute) {
                maxLevel = pugi::cast<uint32_t>(maxLevelAttribute.value());
            } else {
                maxLevel = 0;
                lastStageLevel = minLevel;
                useLastStageLevel = true;
            }

            pugi::xml_attribute multiplierAttribute = stageNode.attribute("multiplier");
            if (multiplierAttribute) {
                multiplier = pugi::cast<uint32_t>(multiplierAttribute.value());
            } else {
                multiplier = 1;
            }

            if (useLastStageLevel) {
                stages[lastStageLevel] = multiplier;
            } else {
                for (uint32_t i = minLevel; i <= maxLevel; ++i) {
                    stages[i] = multiplier;
                }
            }
        }
    }
    return true;
}

 

[jestem pro]

As I expected its different. Bro Loney gave us the hint.
uint32_t is type of integer, we need float numbers.
Change the line(34 in your post):

multiplier = pugi::cast<uint32_t>(multiplierAttribute.value());

to:

multiplier = pugi::cast<float>(multiplierAttribute.value());

And probably this:

then in data/events/scripts/player.lua

look for that function

function Player: onGainExperience(source, exp, rawExp)
...
exp = exp * 0.1 <-- add this line at the end!!!!
return exp
end

Dunno if it enough

 

[nanduzenho]

As I expected its different. Bro Loney gave us the hint.
uint32_t is type of integer, we need float numbers.
Change the line(34 in your post):

multiplier = pugi::cast<uint32_t>(multiplierAttribute.value());

to:

multiplier = pugi::cast<float>(multiplierAttribute.value());

And probably this:

Dunno if it enough

didn't work = /