help with npc shop

[Flagton]

Can anyone help me I'm trying to create an NPC that has different trades on the same NPC

ex: when the player says runes he opens a trade only with runes, when the player says potions he opens a trade only with potions, I can't make the npc open 2 or more different trades.

 

[Evil Puncker]

like this?

NPC - Multiple Shop NPC

Create a custom shop via table. Use that table to open a trade window. In the example below I used simple keywords to show each different shop.. (Shop A, Shop B, Shop C (A & B merged)) But the uses of this is only limited by your imagination. Few quick examples of things you could do ->...

otland.net

 

[Flagton]

like this?

NPC - Multiple Shop NPC

Create a custom shop via table. Use that table to open a trade window. In the example below I used simple keywords to show each different shop.. (Shop A, Shop B, Shop C (A & B merged)) But the uses of this is only limited by your imagination. Few quick examples of things you could do ->...

otland.net

I had already seen this but it didn't work in 13.21 or I did something wrong.I wanted something like this.each Keyword opens a different Trade.

 

[Evil Puncker]

oh you are using canary, good luck with that

 

[Flagton]

oh you are using canary, good luck with that

Is this not possible to do in Canary?

 

[Renato Foot]

Is this not possible to do in Canary?

No it's because we don't have a XML for that, so he doesn't know how to do

 

[Night Wolf]

Can anyone help me I'm trying to create an NPC that has different trades on the same NPC

ex: when the player says runes he opens a trade only with runes, when the player says potions he opens a trade only with potions, I can't make the npc open 2 or more different trades.

with canary I don't think you will be able to do that, see, the old library of npcs made by Jiddo was ANCIENT (I mean, we are talking about something that probably came even before TFS existed) and this was entired rewritten using newer concepts and pushed to CPP to avoid the Lua spaguetti. The capacity to modify or even have different trade lists was probably something that was missed when the system was rewritten. This doesn't mean you can't modify and make a PR to enable this to be possible, it's open source after all.
But as of now, it's not possible to do it as you can in tfs.

 

[Night Wolf]

@Flagton we discussed internally and @EduardoDantas was kind enough to prioritize your request.
Now you should be able to do this using this PR:

feat: custom npc shop items from lua table by dudantas · Pull Request #1947 · opentibiabr/canary

This introduces a new feature that allows for the creation of NPC shop items from lua dynamic tables. It is now possible to associate specific items with keywords/storage and others methods, and wh...

github.com

Follow the hireling example and you should be fine.
Later please give a feedback on PR confirming if it worked as it should or not.

 

[Flagton]

@Flagton we discussed internally and @EduardoDantas was kind enough to prioritize your request.
Now you should be able to do this using this PR:

feat: custom npc shop items from lua table by dudantas · Pull Request #1947 · opentibiabr/canary

This introduces a new feature that allows for the creation of NPC shop items from lua dynamic tables. It is now possible to associate specific items with keywords/storage and others methods, and wh...

github.com

Follow the hireling example and you should be fine.
Later please give a feedback on PR confirming if it worked as it should or not.

Sorry for the delay, NPC working perfectly now, thank you very much to everyone involved, without you I would never have managed it..