Lua Item Description onLook Range

[Lava Titan]

Hello, could someone please tell me, where can I change item onLook distance?

Like, at this moment it's working like tíbia rl, if you're close to the item you can read description, but if you're far like 3 or 4 sqms away you can't.

I wan't people to see the item description no matter where they are, if 2 sqm, or 7

Thanks in advance <3

 

[president vankk]

https://github.com/otland/forgotten...116262a87ec8b8679e00541b5d/src/item.cpp#L1262

?

 

[Codex NG]

Try changing the argument in Player

function Player:onLook(thing, position, distance)
    local description = "You see " .. thing:getDescription(3)

 

[Lava Titan]

tried this before, doesn't work '-'

just tested again to confirm and yeah doesn't work, it even removed the description from all items, no matter what distance

 

[Codex NG]

tried this before, doesn't work '-'

just tested again to confirm and yeah doesn't work, it even removed the description from all items, no matter what distance

Trial and error
What is the value of distance?
Place this right under this

function Player:onLook(thing, position, distance)

if type(distance) == 'table' then
    print(unpack(distance))
elseif type(distance) == 'number' then
    print(distance)
else
    print(type(distance))
end

So it should look like this

function Player:onLook(thing, position, distance)
if type(distance) == 'table' then
    print(unpack(distance))
elseif type(distance) == 'number' then
    print(distance)
else
    print(type(distance))
end
local description = "You see " .. thing:getDescription(distance)

Edit: Damn clerical errors.

 

[Lava Titan]

it's printing the correct distance of item

 

[Codex NG]

Did you know how to use print?
With print you can add additional arguments to print to the console, just by using a comma ( , )
For instance

print(distance, type(distance))

The values printed to the console will appear formatted with tabs between each value printed, this will give you an idea which is being executed.

This is just one way to trouble shooting a script & frankly the easiest.

 

[Marcelo Druida]

https://github.com/otland/forgotten...116262a87ec8b8679e00541b5d/src/item.cpp#L1262

?

didnt worked?

change this:

if (lookDistance <= 4) {
1263                     if (item) {
1264                         text = &item->getText();
1265                         if (!text->empty()) {
1266                             const std::string& writer = item->getWriter();
1267                             if (!writer.empty()) {
1268                                 s << writer << " wrote";
1269                                 time_t date = item->getDate();
1270                                 if (date != 0) {
1271                                     s << " on " << formatDateShort(date);
1272                                 }
1273                                 s << ": ";
1274                             } else {
1275                                 s << "You read: ";
1276                             }
1277                             s << *text;
1278                         } else {
1279                             s << "Nothing is written on it";
1280                         }
1281                     } else {
1282                         s << "Nothing is written on it";
1283                     }
1284                 } else {
1285                     s << "You are too far away to read it";
1286                 }

to this:

1263                     if (item) {
1264                         text = &item->getText();
1265                         if (!text->empty()) {
1266                             const std::string& writer = item->getWriter();
1267                             if (!writer.empty()) {
1268                                 s << writer << " wrote";
1269                                 time_t date = item->getDate();
1270                                 if (date != 0) {
1271                                     s << " on " << formatDateShort(date);
1272                                 }
1273                                 s << ": ";
1274                             } else {
1275                                 s << "You read: ";
1276                             }
1277                             s << *text;
1278                         } else {
1279                             s << "Nothing is written on it";
1280                         }
1281                     } else {
1282                         s << "Nothing is written on it";
1283                     }

 

[Dream OTs]

thanks I will use this too!!

I will test later and post results