LightX's Scripting Thread

[Alyhide]

Hello, I am here to see if I have increased my scripting abilities at all.. Here are some simple scripts I made..



11/26/2010 || 1:30 AM

function onUse(cid, item, fromPosition, itemEx, toPosition)
		if getPlayerLevel(cid) >= 100 then
				doPlayerSendTextMessage(cid,21,"Congratulations!")
				doPlayerAddMana(cid,500)
				doPlayerAddHealth(cid,500)
		else
				doPlayerSendCancel(cid,"Sorry, Try Gaining Some Levels!"
				doPlayerPopupFYI(cid, "Gain Levels By Hunting or Exploring New Islands!")
		end
		return TRUE
end

11/26/2010 || 1:41 AM

function onStepIn(cid, item, frompos, itemEx, topos)
					doPlayerSendTextMessage(cid,21,"Welcome To Avian!"
end

 

[Clinten]

Why true with caps?

 

[Alyhide]

Why true with caps?

Looks cooler

 

[_Arthur]

Why would you make a script that onUse gives a useless message? XD

What a useless item.

 

[IMac]

your tabbing are all fucked up ;x

 

[Alyhide]

Why would you make a script that onUse gives a useless message? XD

What a useless item.

Idk what to script.. lol

your tabbing are all fucked up ;x

How? How do I fix it?

 

[Evil Mark]

This is how I tab:

Function (no tab)
	if something then--(IF-statements, 1 tab)
		doSomething--(ee.. commands that start with "do" i use 2 tabs)
	elseif --(IF-statement again, so I use 1 tab.)
		doSomething--( 2 tabs)
	else --(1 tab)
                doSomethingElse(2 tabs)
	end--(my first end always has the same tab as the line above started with)
end --(my end below always goes 1 tab in, and it continues that way depending on how many tabs I use)

 

[Alyhide]

This is how I tab:

Function (no tab)
	if something then--(IF-statements, 1 tab)
		doSomething--(ee.. commands that start with "do" i use 2 tabs)
	elseif --(IF-statement again, so I use 1 tab.)
		doSomething--( 2 tabs)
	else --(1 tab)
                doSomethingElse(2 tabs)
	end--(my first end always has the same tab as the line above started with)
end --(my end below always goes 1 tab in, and it continues that way depending on how many tabs I use)

okay neat that helped me a lot

 

[Ecstacy]

wrong tab

function onStepIn(cid, item, frompos, itemEx, topos)
					doPlayerSendTextMessage(cid,21,"Welcome To Avian!"
end

good tabbing

function onStepIn(cid, item, frompos, itemEx, topos)
	doPlayerSendTextMessage(cid,21,"Welcome To Avian!") -- you forgot ')'
end

This is how I tab.

local item = 2149 -- same line as function/if statement. Numbers/strings that don't change during the script, ABOVE the function statement.
function learnTab(script) -- function has no tab.
local lastTab = 0 -- local on the same line as function/if statement. this function changes during the script and needs to be 0 again on read, so put it somewhere UNDER function statement.
	if doUnderstand() then -- every if statement has 1 tab from the last if statement.
	local lastTab = 1 -- same line as if statement now, as it changes during script.
		if reallyUnderstands() then -- basically you need to tab lastTab+1 time. so if lastTab = 1 and you make a new if statement tab 1 more time.
		local lastTab = 2 -- tabbed 2x so it's 2 now.
			doPlayerGiveItem(item) -- lastTab+1 = 3 so 3x tab needed. also gives the itemid of the number that doesn't change during script.
		end -- end under last if statement so it closes
	end -- end under last if statement again so it closes
	return true -- under the last end of an if statement.
end -- 0 tabs as this closes the function.

If you need more help, you can PM me.

 

[hodleo]

^last is kinda wrong:

local item = 2149 -- same line as function/if statement. Numbers/strings that don't change during the script, ABOVE the function statement.
function learnTab(script) -- function has no tab.
    local lastTab = 0 -- local on the same line as function/if statement. this function changes during the script and needs to be 0 again on read, so put it somewhere UNDER function statement.
    if doUnderstand() then -- every if statement has 1 tab from the last if statement.
        local lastTab = 1 -- same line as if statement now, as it changes during script.
        if reallyUnderstands() then -- basically you need to tab lastTab+1 time. so if lastTab = 1 and you make a new if statement tab 1 more time.
            local lastTab = 2 -- tabbed 2x so it's 2 now.
            doPlayerGiveItem(item) -- lastTab+1 = 3 so 3x tab needed. also gives the itemid of the number that doesn't change during script.
        end -- end under last if statement so it closes
    end -- end under last if statement again so it closes
    return true -- under the last end of an if statement.
end -- 0 tabs as this closes the function.

Why true with caps?

it does not matter at all

TRUE = true
FALSE = false
LUA_ERROR = false
LUA_NO_ERROR = true
LUA_NULL = nil

 

[JDB]

Stop correcting the original poster in his thread. If you want to help, PM him and help...don't make him look stupid.

Where is the respect now days?

 

[hodleo]

Well, you're not helping at all..

 

[JDB]

Well, you're not helping at all..

I have via PM.

 

[Ecstacy]

Congratulations, for helping, we are also helping, we are not making him look stupit we are correcting him how he should do it so he gets better, and might help other people.

@CyberM why is it wrong? lol.

 

[hodleo]

@CyberM why is it wrong? lol.

well, i'm used to see any content inside a function tabbed

local item = 2149 -- same line as function/if statement. Numbers/strings that don't change during the script, ABOVE the function statement.
function learnTab(script) -- function has no tab.
[COLOR=red]local lastTab = 0 -- local on the same line as function/if statement. this function changes during the script and needs to be 0 again on read, so put it somewhere [/COLOR]UNDER function statement.
    if doUnderstand() then -- every if statement has 1 tab from the last if statement.
    local lastTab = 1 -- same line as if statement now, as it changes during script.
        if reallyUnderstands() then -- basically you need to tab lastTab+1 time. so if lastTab = 1 and you make a new if statement tab 1 more time.
        local lastTab = 2 -- tabbed 2x so it's 2 now.
            doPlayerGiveItem(item) -- lastTab+1 = 3 so 3x tab needed. also gives the itemid of the number that doesn't change during script.
        end -- end under last if statement so it closes
    end -- end under last if statement again so it closes
    return true -- under the last end of an if statement.
end -- 0 tabs as this closes the function.

 

[Ecstacy]

Well as I said, thats how I tab.
I just find this more organized than creating an extra tab for just a local, but you can't really say it's wrong, lol.

 

[hodleo]

Well as I said, thats how I tab.
I just find this more organized than creating an extra tab for just a local, but you can't really say it's wrong, lol.

Take a look here: lua-users wiki: Source Code Formatter

 

[Ecstacy]

Well it still can't be called wrong, as everyone has his own style, and this is mine.

 

[bilmattan]

Example on the first script, you should use player storage too since a player can go to 100, die, go to 100 and die = lots of hp :d

 

[Mock]

The original

LUA_ERROR = false
LUA_NO_ERROR = true

is:

LUA_ERROR = 0
LUA_NO_ERROR = 1