Compiling Max level edit, client crashes.

[Joriku]

Hi,
Ran past an issue while I edited the max level on TFS 1.3 (Forgottenserver)

Compiling - Editing Max level aka 717k 0.3.6

It's possible, i've seen ot's where players are more than 717k. I do know how to compile, but how do I edit the max level? 0.3.6 0.4 Kind Regards

otland.net

Ran past this old therd explaining it, but I can't manage to find the code in later versions.
Anyone that knows how to get rid of this in the later version?

Error:

 

[Joriku]

Update:
Got this:

After adding this:
Protocolgame.cpp

at:
msg.add<uint64_t>(player->getExperience());

I added this:
if (player->getExperience() > 2147483647) // client debugs after 2,147,483,647 exp
        msg.add<uint64_t>(2147483647);

 

[Nekiro]

You are sending u64 I believe it should be u32

 

[Joriku]

You are sending u64 I believe it should be u32

While doing

msg.add<uint32_t>(player->getExperience());
    if (player->getExperience() > 2147483647) // client debugs after 2,147,483,647 exp
        msg.add<uint32_t>(2147483647);

Instant crash on login

Also this:

msg.add<uint64_t>(player->getExperience());
    if (player->getExperience() > 2147483647) // client debugs after 2,147,483,647 exp
        msg.add<uint32_t>(2147483647);

Still crashing client upon death

 

[Ziker]

I believe that you'll still need the other change, did you apply it? (There may be more changes required, since the thread you linked is for TFS 0.4.x)

 

[Joriku]

I believe that you'll still need the other change, did you apply it? (There may be more changes required, since the thread you linked is for TFS 0.4.x)

What do you mean with the other?
Can you send it or send a sample?

 

[Ziker]

What do you mean with the other?
Can you send it or send a sample?

In the thread you linked to there are two changes required to make it work. From what you're saying you only made one of them (in protocolgame.cpp).

 

[Joriku]

In the thread you linked to there are two changes required to make it work. From what you're saying you only made one of them (in protocolgame.cpp).

Yeah, doesn't work. Instantly dbugging once I level up. Think above 500? unsure, could die on low level tho but once I reach high level or give myself level the character is ripped. instant dbug on login

 

[Ziker]

Yeah, doesn't work. Instantly dbugging once I level up. Think above 500? unsure, could die on low level tho but once I reach high level or give myself level the character is ripped. instant dbug on login

Yeah-what? You only made that single change? In which case it most likely won't work.

 

[Joriku]

Yeah-what? You only made that single change? In which case it most likely won't work.

I got those two changes into the client, It allowed my character to reach above 717k and I max got to 7.9 mil before being satesfied.
The thing that's the issue for me is that the client crashes upon death for the player and you can get into the game again but I want to prevent the crash from happening.
So... how would this be possible to stop the crashes?

 

[Sarah Wesker]

TFS 1.3 already uses uint64_t by default, there is no way to extend the limits further, that is the highest integer numeric type you can use
this limit is: 18446744073709551615 or if you like the hexadecimal format 0xFFFFFFFFFFFFFFFF

As it is by default it is the maximum: uint64_t
msg.add<uint64_t>(player->getExperience());

If you want to use this space to show level instead of experience, then just change player->getExperience() for player->getLevel()
But you cannot change the type of number sent for the level waiting for the CIP client to know how to read this value
the client reads the level with 2 Bytes, and the experience with 8 Bytes

 

[Joriku]

TFS 1.3 already uses uint64_t by default, there is no way to extend the limits further, that is the highest integer numeric type you can use
this limit is: 18446744073709551615 or if you like the hexadecimal format 0xFFFFFFFFFFFFFFFF

As it is by default it is the maximum: uint64_t
msg.add<uint64_t>(player->getExperience());

If you want to use this space to show level instead of experience, then just change player->getExperience() for player->getLevel()
But you cannot change the type of number sent for the level waiting for the CIP client to know how to read this value
the client reads the level with 2 Bytes, and the experience with 8 Bytes

Alright, Sarah. You saw what I couldn't. Thanks alot, replacing the Experience to level solved the crashing part and the level can still be above 10 million thanks to this.
I'll try to explain,
So. Thanks to @Gesior.pl I managed to get rid of all the issues and understand a little bit more but I had to change the client to OTClient in-order for it to not crash.
So the issue for both clients are:
getExperience, change that into getLevel and both clients are fine.

So, this Is how it ended up looking like:
player.h

static uint64_t getExpForLevel(uint64_t lv) {
return ((150ULL * lv * lv) - (50ULL * lv * lv) + (1200ULL)) / 3ULL;
}

Protocolgame.cpp
Changed:

msg.add<uint32_t>(player->getExperience());

Into:

if (player->getExperience() > 12345678ULL) {
        msg.add<uint64_t>(12345678ULL);
    }
    else {
        msg.add<uint64_t>(player->getLevel()); -- changed out getExperience to getLevel which solved the crashing on normal client (tibia cipsoft client)
    }

Thanks you both for the help, this solved my crashing Issue and makes me able to have above 717k level on later client.