Some sites for 'hackers' show message like "Your password is used by XX other accounts of that site" (compare hashes in database), which looks much more scary than some password strength analysis by algorithm.
For sure code that analyses password strength should be added to website (JS), but it should not block possibility to make account with "bad" password (PHP). Sometimes you just want to create account like
gesior/gesior on random OTS to test something on www/OTS and acc. maker code should not block it. It should warn normal OTS users about their weak password.
Requirements like "1 letter" + "1 number" + "1 special character" to create account just make people use same "unique" password on multiple OTSes. Acc. maker should allow people to create account with password like
1. It's safer than forcing people to use 'strong password'.
If you plan to add tool like this into MyAAC, it should read something like
weak_passwords.txt (plain text or hashes - auto detect OTS password format; or use MySQL table for this) and warn players who use these passwords, so OTS owners can warn players about weak password they use (passwords they used before on given OTS - probably also on other OTSes). Most of OTSes have multiple "editions" and owner can create own list of "used hashes" to warn players to use different password.
ex. You go "OTS 1" and set password
gesior. Then you go "OTS 2" that says that your password is not strong, you set password
gesior1. Then you use
gesior1 on XX other OTSes - old acc. makers without
weak_passwords.txt - and come back to new edition of "OTS 1" still using
gesior1 as strong password. It's not strong anymore, XX other OTSes know it!
As MyAAC is only acc. maker that works with latest TFSes and canary (Gesior2012 and Znote - probably - are dead), you should consider security seriously. Your acc. maker security is security of 90% of OTSes now.
I worked for multiple big OTSes and they all get into trouble, because ~5% of top 1000 players get hacked and get reports from players like "OTS is hacked", but it wasn't OTS, it was just players accounts. Often hacked by other OTS owners, who used 'plain' encryption in database and scanned 40k+ "known" account-password pairs. You can reduce it by limiting wrong "logins" to OTS/www per IP per hour (it's already in OTS engine, but not on www), but attackers often use 1k+ IPs and scan slowly. On kasteria.pl I added big red warning on top of account registration site "Do not use same password as on other OTSes! They will try to hack your account!". It helped a lot, at least players planning to go 'top 100' used different passwords.
Also, few years ago there were hackers who promoted fake OTSes start on OTLand, otservlist etc. just to get account-email-password database. OTS never started, there was no OTS at all, just website that collected account-email-password in clear text to hack other OTSes accounts.
Some people messaged me - in last 10 years - on Discord with offers 100-1000$ to sell big OTSes login-password databases, even with MD5/SHA1 passwords (not plain text). They would crack password hashes and use it to scan all new popular OTSes to steal premium points/crystal coins and get a lot of $$$ selling it for RL money.
I don't care about this kind of offers, but some OTS owners - who had 200+ players on start and their OTS failed after X days online - may sell their databases to hackers.